GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-42262: Add Py_NewRef() function by vstinner · Pull Request #23152 · python/cpython

Conversation

vstinner commented Nov 4, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Add Py_NewRef() function to get a strong reference to an object.

https://bugs.python.org/issue42262

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hodgestar, pmp-p, and erlend-aasland reacted with thumbs up emoji

Jongy reacted with hooray emoji

erlend-aasland reacted with heart emoji

All reactions

👍 3 reactions
🎉 1 reaction
❤️ 1 reaction

the-knights-who-say-ni added the CLA signed label

Nov 4, 2020

bedevere-bot added the awaiting core review label

Nov 4, 2020

vstinner commented Nov 4, 2020

Copy link

Copy Markdown

Member Author

Ubuntu failed with a download error:

E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/b/babeltrace/libbabeltrace1_1.5.5-1_amd64.deb Could not connect to azure.archive.ubuntu.com:80 (52.252.75.106), connection timed out

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner closed this

Nov 4, 2020

vstinner reopened this

Nov 4, 2020

vstinner commented Nov 4, 2020

Copy link

Copy Markdown

Member Author

I closed/reopened the PR to re-run the Ubuntu job.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Nov 4, 2020

Copy link

Copy Markdown

Member Author

cc @methane @serhiy-storchaka

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner requested a review from a team as a code owner

November 4, 2020 20:02

methane reviewed

Nov 4, 2020

View reviewed changes

methane left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you improve the doc to describe the difference to Py_INCREF?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner commented Nov 4, 2020

Copy link

Copy Markdown

Member Author

@methane:

Would you improve the doc to describe the difference to Py_INCREF?

I rewrote the function documentation. Is the difference between Py_INCREF() and Py_NewRef() more explicit now?

I also added Py_XNewRef() which accepts NULL.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added 2 commits

November 5, 2020 00:41


          bpo-42262: Add Py_NewRef() function

eb35158

Added Py_NewRef() function to increment the reference count of an
object and return the object.


          Fix Sphinx formatting

c1942ff

Jongy reviewed

Nov 5, 2020

View reviewed changes

Comment thread

Objects/object.c Outdated

		}

		#undef Py_NewRef
		#undef Py_XNewRef

Jongy Nov 5, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps redefine these 2 macros after defining the 2 functions, so this file can enjoy the static inline version as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane reacted with thumbs up emoji

All reactions

👍 1 reaction

vstinner Nov 5, 2020

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I moved the definitions at the bottom of object.c, so object.c gets the fast static inlined flavor as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Jongy Nov 5, 2020

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the definitions at the bottom of object.c,

Even better :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

methane commented Nov 5, 2020

Copy link

Copy Markdown

Member

I rewrote the function documentation. Is the difference between Py_INCREF() and Py_NewRef() more explicit now?

LGTM.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

methane approved these changes

Nov 5, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Nov 5, 2020


          Define functions at the bottom of object.c

146d28d

vstinner merged commit 53a03aa into python:master

Nov 5, 2020

bedevere-bot removed the awaiting merge label

Nov 5, 2020

vstinner deleted the newref branch

November 5, 2020 14:02

vstinner commented Nov 5, 2020

Copy link

Copy Markdown

Member Author

Thanks for the review @methane and @Jongy !

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland mentioned this pull request

Nov 5, 2020

bpo-1635741: sqlite3 now uses Py_NewRef and Py_XNewRef #23170

Merged

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Nov 6, 2020


          Merge remote-tracking branch 'origin/master' into bpo_41832

15e18cc

* origin/master:
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Nov 7, 2020


          Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…

2d72953

…lots1

* origin/master: (80 commits)
  bpo-42282: Fold constants inside named expressions (pythonGH-23190)
  bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
  bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
  Remove outdated reference to pywin32 from platform module (pythonGH-22005)
  bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
  Minor grammar edits for the descriptor howto guide (GH-python#23175)
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  ...

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)

f84560f

Added Py_NewRef() and Py_XNewRef() functions to increment the reference
count of an object and return the object.

Reviewers

methane

methane approved these changes

+1 more reviewer

Jongy

Jongy left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Nov 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner commented Nov 4, 2020

Uh oh!

vstinner commented Nov 4, 2020

Uh oh!

vstinner commented Nov 4, 2020

Uh oh!

methane left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 4, 2020

Uh oh!

Jongy Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

vstinner Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

Jongy Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

methane commented Nov 5, 2020

Uh oh!

vstinner commented Nov 5, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vstinner commented Nov 4, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.