GeezerVison is showing github.com — bpo-40816: [docs] Fix wrongly named AsyncContextManager by Fidget-Spinner · Pull Request #23164 · python/cpython
Conversation
Fidget-Spinner
commented
Nov 5, 2020
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
In commit 178695b, the AsyncContextDecorator class was added, but the documentation in that commit called it AsyncContextManager, I believe this may be wrong.
Also added versionchanged.
I believe this can skip news since it shares the same news entry as the commit.
https://bugs.python.org/issue40816
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Also added versionchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
My bad, I should read the docs update more carefully next time.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Nov 7, 2020
…lots1
* origin/master: (80 commits)
bpo-42282: Fold constants inside named expressions (pythonGH-23190)
bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
Remove outdated reference to pywin32 from platform module (pythonGH-22005)
bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
Minor grammar edits for the descriptor howto guide (GH-python#23175)
bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
[docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
Disable peg generator tests when building with PGO (pythonGH-23141)
bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
...
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Also added versionchanged.
Reviewers
asvetlov
asvetlov approved these changes
1st1
Awaiting requested review from 1st1
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.