GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Docs: improve accuracy of socketserver reference by geryogam · Pull Request #24767 · python/cpython

Conversation

geryogam commented Mar 5, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

In the documentation of the socketserver standard library:

update a restricted statement; the address family difference between TCPServer and UnixStreamServer is also true between UDPServer and UnixDatagramServer, as the second clause of the sentence and the implementation show;
update an obsolete statement; since Python 3.6 the StreamRequestHandler.wfile attribute also supports the io.BufferedIOBase writable interface:

Changed in version 3.6: StreamRequestHandler.wfile also supports the io.BufferedIOBase writable interface.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update socketserver.rst

38d27aa

the-knights-who-say-ni added the CLA signed label

Mar 5, 2021

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Mar 5, 2021

geryogam added 2 commits

March 5, 2021 22:17


          Fix the class diagram

dcea65b


          Remove a no longer valid restriction for wfile

126273b

github-actions Bot commented Apr 8, 2021

Copy link

Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Stale PR or inactive for long period of time. label

Apr 8, 2021

AlexWaygood added the skip news label

May 17, 2022

merwok reviewed

May 24, 2022

View reviewed changes

Comment thread

Doc/library/socketserver.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti removed the CLA signed label

Jul 13, 2022

github-actions Bot removed the stale Stale PR or inactive for long period of time. label

Aug 5, 2022

erlend-aasland reviewed

Nov 27, 2022

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on Éric's review and my own observations, I suggest closing this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/socketserver.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/socketserver.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added the pending The issue will be closed if no feedback is provided label

Nov 27, 2022

geryogam added 2 commits

November 28, 2022 18:34


          Apply Erlend’s change suggestion

62d3aa6


          Revert arrow direction in class diagram

a033dc8

geryogam requested a review from erlend-aasland

November 28, 2022 17:39

erlend-aasland commented Nov 28, 2022

Copy link

Copy Markdown

Contributor

Please update the PR title to reflect the actual change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested a review from merwok

November 28, 2022 21:33


          Apply Erlend’s suggested change

512d06c

geryogam changed the title ~~Update socketserver.rst~~ Update obsolete or restricted statements in the socketserver documentation

Nov 28, 2022

geryogam commented Nov 28, 2022

Copy link

Copy Markdown

Contributor Author

Please update the PR title to reflect the actual change.

Updated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Nov 29, 2022

View reviewed changes

Comment thread

Doc/library/socketserver.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

geryogam added 2 commits

November 29, 2022 10:55


          Update socketserver.rst

f6cd652


          Apply Erlend’s suggestion

57604b9

merwok reviewed

Nov 29, 2022

View reviewed changes

Comment thread

Doc/library/socketserver.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Doc/library/socketserver.rst

a55c279

Co-authored-by: Éric <[email protected]>

erlend-aasland changed the title ~~Update obsolete or restricted statements in the socketserver documentation~~ Docs: improve accuracy of socketserver reference

Nov 29, 2022

erlend-aasland approved these changes

Nov 29, 2022

View reviewed changes

erlend-aasland left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting review label

Nov 29, 2022

bedevere-bot added the awaiting merge label

Nov 29, 2022

erlend-aasland added skip issue needs backport to 3.10 needs backport to 3.11 only security fixes and removed pending The issue will be closed if no feedback is provided labels

Nov 29, 2022

erlend-aasland self-assigned this

Nov 29, 2022

erlend-aasland merged commit 052bc12 into python:main

Nov 29, 2022

miss-islington commented Nov 29, 2022

Copy link

Copy Markdown

Contributor

Thanks @maggyero for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Nov 29, 2022

bedevere-bot commented Nov 29, 2022

Copy link

Copy Markdown

GH-99884 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 29, 2022


          Docs: improve accuracy of socketserver reference (pythonGH-24767)

1f96fe5

(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <[email protected]>

bedevere-bot removed the needs backport to 3.11 only security fixes label

Nov 29, 2022

bedevere-bot commented Nov 29, 2022

Copy link

Copy Markdown

GH-99885 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 29, 2022


          Docs: improve accuracy of socketserver reference (pythonGH-24767)

ca87913

(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <[email protected]>

bedevere-bot removed the needs backport to 3.10 label

Nov 29, 2022

miss-islington added a commit that referenced this pull request

Nov 29, 2022


          Docs: improve accuracy of socketserver reference (GH-24767)

3baaa97

(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <[email protected]>

miss-islington added a commit that referenced this pull request

Nov 29, 2022


          Docs: improve accuracy of socketserver reference (GH-24767)

d7c2e0a

(cherry picked from commit 052bc12)

Co-authored-by: Géry Ogam <[email protected]>

geryogam commented Nov 29, 2022

Copy link

Copy Markdown

Contributor Author

Thanks for the review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geryogam deleted the patch-16 branch

November 29, 2022 21:26

carljm added a commit to carljm/cpython that referenced this pull request

Dec 1, 2022


          Merge branch 'main' into fixinspect

12f7659

* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...

Reviewers

merwok

merwok left review comments

erlend-aasland

erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

geryogam commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2021

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Nov 28, 2022

Uh oh!

geryogam commented Nov 28, 2022

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Nov 29, 2022

Uh oh!

bedevere-bot commented Nov 29, 2022

Uh oh!

bedevere-bot commented Nov 29, 2022

Uh oh!

geryogam commented Nov 29, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

geryogam commented Mar 5, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.