GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-47220: Document the optional callback parameter of weakref.WeakMethod by geryogam · Pull Request #25491 · python/cpython

Conversation

@geryogam

@geryogam geryogam commented Apr 20, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR will bring the following changes to the weakref documentation:

  • document the optional callback parameter of weakref.WeakMethod;
  • normalise the use of ‘proxy’, replacing the mix of ‘proxy’ (8 occurrences) and ‘proxy object’ (3 occurrences);
  • normalise the use of ‘weak reference’, replacing the mix of ‘weak reference’ (37 occurrences), ‘weak reference object’ (7 occurrences), ‘reference’ (7 occurrences), ‘reference object’ (6 occurrences), ‘weakref’ (3 occurrences), and ‘weakref object’ (1 occurrence).

https://bugs.python.org/issue47220

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
domdfcoding reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@geryogam
Update weakref.rst
4d950a8
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 20, 2021
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 20, 2021
geryogam added 2 commits April 22, 2021 12:15
@geryogam
Update weakref.rst
c2d8a6b
@geryogam
Add the undocumented optional callback parameter to WeakMethod
0897c44
@geryogam
geryogam marked this pull request as ready for review April 23, 2021 22:03
@github-actions

github-actions Bot commented Jun 3, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 3, 2021
@JelleZijlstra
JelleZijlstra self-requested a review April 2, 2022 23:20
@JelleZijlstra
Merge branch 'main' into patch-25
37a75fe
@JelleZijlstra JelleZijlstra added skip issue skip news needs backport to 3.9 and removed skip issue skip news labels Apr 3, 2022
@JelleZijlstra

JelleZijlstra commented Apr 3, 2022

Copy link
Copy Markdown
Member

Sorry this had to wait for so long!

  • Documenting the callback parameter to WeakMethod requires an issue and a NEWS entry in my view. Also, the documentation should say what the parameter does.
  • Some of the wording changes feel gratuitous (e.g. "proxy objects" vs. "proxies"). I don't know if the original authors had reasons for using one form or the other, so I'd be hesitant to make changes without a strong reason.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra removed their request for review April 3, 2022 03:30
merwok
merwok reviewed Apr 3, 2022
View reviewed changes
Comment thread Doc/library/weakref.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
geryogam added 2 commits April 4, 2022 22:51
@geryogam
Document the callback parameter to WeakMethod
819a583
@geryogam
Create 2022-04-04-22-54-11.bpo-47167.nCNHsB.rst
7e437b5
@geryogam geryogam changed the title Update weakref.rst bpo-47220: Document the optional callback parameter of weakref.WeakMethod Apr 4, 2022
@geryogam geryogam changed the title bpo-47220: Document the optional callback parameter of weakref.WeakMethod Document the optional callback parameter of weakref.WeakMethod Apr 4, 2022
@geryogam geryogam changed the title Document the optional callback parameter of weakref.WeakMethod bpo-47220: Document the optional callback parameter of weakref.WeakMethod Apr 4, 2022
geryogam added 3 commits April 4, 2022 23:07
@geryogam
Rename 2022-04-04-22-54-11.bpo-47167.nCNHsB.rst to 2022-04-04-22-54-1…
52a0e64 
…1.bpo-47220.L9jYu4.rst
@geryogam
Update 2022-04-04-22-54-11.bpo-47220.L9jYu4.rst
afcabae
@geryogam
Update 2022-04-04-22-54-11.bpo-47220.L9jYu4.rst
da83bd6
@geryogam

geryogam commented Apr 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra @merwok Thanks for the review.

  • Documenting the callback parameter to WeakMethod requires an issue and a NEWS entry in my view. Also, the documentation should say what the parameter does.

Done.

  • Some of the wording changes feel gratuitous (e.g. "proxy objects" vs. "proxies"). I don't know if the original authors had reasons for using one form or the other, so I'd be hesitant to make changes without a strong reason.

I normalised the use of ‘proxy’ because a mix of ‘proxy’ (8 occurrences) and ‘proxy object’ (3 occurrences) was used.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geryogam
Update 2022-04-04-22-54-11.bpo-47220.L9jYu4.rst
b8a0169
@bedevere-bot bedevere-bot removed the awaiting review label Nov 27, 2022
@bedevere-bot

bedevere-bot commented Nov 27, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Nov 27, 2022
geryogam added 2 commits November 28, 2022 17:07
@geryogam
Revert "Update weakref.rst"
f19e8a1 
This reverts commit c2d8a6b.
@geryogam
Revert "Normalise and disambiguate"
b60d38b 
This reverts commit 7a78eeb.
@geryogam

geryogam commented Nov 28, 2022

Copy link
Copy Markdown
Contributor Author

Please remove all unrelated changes.

Reverted. I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Nov 28, 2022
@bedevere-bot

bedevere-bot commented Nov 28, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from erlend-aasland November 28, 2022 16:15
@erlend-aasland
erlend-aasland requested a review from rhettinger November 28, 2022 21:30
rhettinger
rhettinger approved these changes Nov 30, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Nov 30, 2022
@rhettinger rhettinger removed the needs backport to 3.10 label Nov 30, 2022
@rhettinger
rhettinger merged commit 9628136 into python:main Nov 30, 2022
@miss-islington

miss-islington commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 30, 2022
@miss-islington

miss-islington commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Sorry @maggyero and @rhettinger, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 9628136fac997847b4662e6a17faf06d2a0507eb 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned rhettinger Nov 30, 2022
@rhettinger rhettinger added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Nov 30, 2022
@miss-islington

miss-islington commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @maggyero for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Nov 30, 2022

Copy link
Copy Markdown

GH-99909 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 30, 2022
@geryogam @miss-islington
bpo-47220: Document the optional callback parameter of weakref.WeakMe…
eda7e37 
…thod (pythonGH-25491)

(cherry picked from commit 9628136)

Co-authored-by: Géry Ogam <[email protected]>
miss-islington added a commit that referenced this pull request Nov 30, 2022
@miss-islington @geryogam
bpo-47220: Document the optional callback parameter of weakref.WeakMe…
90701eb 
…thod (GH-25491)

(cherry picked from commit 9628136)

Co-authored-by: Géry Ogam <[email protected]>
@geryogam

geryogam commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geryogam
geryogam deleted the patch-25 branch November 30, 2022 20:00
carljm added a commit to carljm/cpython that referenced this pull request Dec 1, 2022
@carljm
Merge branch 'main' into fixinspect
12f7659 
* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@rhettinger rhettinger rhettinger approved these changes
@pitrou pitrou Awaiting requested review from pitrou
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@geryogam @JelleZijlstra @rhettinger @MaxwellDupre @bedevere-bot @miss-islington @merwok @pitrou @erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.