GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Trivial change: Misleading zip64 limit error message by dmjohnsson23 · Pull Request #95892 · python/cpython

Conversation

dmjohnsson23 commented Aug 11, 2022

Copy link

Copy Markdown

Contributor

This error message is confusing as it seems to indicate that the file is already using zip64. This new message makes it more clear what the problem is, and will help guide developers to find the solution. (That is, to use in ZipFile.open(force_zip64=True))

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot commented Aug 11, 2022

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting review label

Aug 11, 2022

ghost commented Aug 11, 2022 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmjohnsson23 commented Aug 11, 2022

Copy link

Copy Markdown

Contributor Author

Trying to sign the CLA results in an internal server error for me. However, I have read and agree.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 requested changes

Nov 27, 2022

View reviewed changes

kumaraditya303 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are merge conflicts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot removed the awaiting review label

Nov 27, 2022

bedevere-bot commented Nov 27, 2022

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting changes label

Nov 27, 2022

dmjohnsson23 closed this

Nov 28, 2022

dmjohnsson23 force-pushed the patch-1 branch from 38ac463 to 1d1bb95 Compare

November 28, 2022 22:25

bedevere-bot commented Nov 28, 2022

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Change confusing error message

7869d7e

This error message can mistakenly confuse people into thinking that the zip file is already using zip64, when in fact the problem is that they are not using zip64.

dmjohnsson23 reopened this

Nov 28, 2022

bedevere-bot commented Nov 28, 2022

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

bedevere-bot commented Nov 28, 2022

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dmjohnsson23 commented Nov 28, 2022

Copy link

Copy Markdown

Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting change review and removed awaiting changes labels

Nov 28, 2022

bedevere-bot commented Nov 28, 2022

Copy link

Copy Markdown

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from kumaraditya303

November 28, 2022 22:46


          Merge branch 'main' into patch-1

e0265fb

bedevere-bot commented Nov 29, 2022

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 added skip issue skip news labels

Nov 29, 2022

kumaraditya303 requested a review from gpshead

November 29, 2022 15:04

gpshead approved these changes

Nov 29, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels

Nov 29, 2022

gpshead assigned kumaraditya303

Nov 29, 2022

kumaraditya303 approved these changes

Nov 30, 2022

View reviewed changes

kumaraditya303 merged commit 59665d0 into python:main

Nov 30, 2022

bedevere-bot removed the awaiting merge label

Nov 30, 2022

carljm added a commit to carljm/cpython that referenced this pull request

Dec 1, 2022


          Merge branch 'main' into fixinspect

12f7659

* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...

Reviewers

gpshead

gpshead approved these changes

kumaraditya303

kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

kumaraditya303

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

dmjohnsson23 commented Aug 11, 2022

Uh oh!

bedevere-bot commented Aug 11, 2022

Uh oh!

ghost commented Aug 11, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmjohnsson23 commented Aug 11, 2022

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 27, 2022

Uh oh!

bedevere-bot commented Nov 28, 2022

Uh oh!

bedevere-bot commented Nov 28, 2022

Uh oh!

bedevere-bot commented Nov 28, 2022

Uh oh!

dmjohnsson23 commented Nov 28, 2022

Uh oh!

bedevere-bot commented Nov 28, 2022

Uh oh!

bedevere-bot commented Nov 29, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghost commented Aug 11, 2022 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.