GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Operator add feast ui deployment by redhatHameed · Pull Request #4930 · feast-dev/feast

Conversation

redhatHameed commented Jan 17, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

What this PR does / why we need it:

Enables deployment of the Feast UI with operator.
Adds OpenShift Route support for the UI,
Adds TLS configuration for UI.
Updates test cases to validate the new functionality.

I am facing the below issue, but I think that might be due to #4772

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

tchughesiv reviewed

Jan 20, 2025

View reviewed changes

Comment thread

infra/feast-operator/config/samples/v1alpha1_featurestore_all_services_default.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

infra/feast-operator/internal/controller/services/services.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed force-pushed the operator-ui-deployment branch from bff0065 to f19c6a7 Compare

January 20, 2025 15:10

tchughesiv requested changes

Jan 20, 2025

View reviewed changes

Comment thread

infra/feast-operator/internal/controller/services/services_types.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed force-pushed the operator-ui-deployment branch from f19c6a7 to 00a7ded Compare

January 20, 2025 16:12

tchughesiv requested changes

Jan 20, 2025

View reviewed changes

Comment thread

infra/feast-operator/internal/controller/services/tls.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed force-pushed the operator-ui-deployment branch 2 times, most recently from a6edaa0 to 602c334 Compare

January 21, 2025 16:28

redhatHameed marked this pull request as ready for review

January 21, 2025 17:02

redhatHameed requested a review from a team as a code owner

January 21, 2025 17:02

redhatHameed added the ok-to-test label

Jan 21, 2025

redhatHameed force-pushed the operator-ui-deployment branch from 602c334 to c77227e Compare

January 21, 2025 21:50

redhatHameed removed the ok-to-test label

Jan 21, 2025

redhatHameed force-pushed the operator-ui-deployment branch from c77227e to ae819f3 Compare

January 22, 2025 14:27


          feat: Operator add feast ui deployment

e6eb3cd

Signed-off-by: Abdul Hameed <[email protected]>

redhatHameed force-pushed the operator-ui-deployment branch from ae819f3 to bec49af Compare

January 22, 2025 14:42

redhatHameed added the ok-to-test label

Jan 22, 2025

redhatHameed force-pushed the operator-ui-deployment branch from bec49af to 4745631 Compare

January 22, 2025 16:47

tchughesiv reviewed

Jan 22, 2025

View reviewed changes

Comment thread

infra/feast-operator/test/e2e/test_util.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed force-pushed the operator-ui-deployment branch from 4745631 to a833b5f Compare

January 22, 2025 20:42

tchughesiv requested changes

Jan 22, 2025

View reviewed changes

Comment thread

infra/feast-operator/internal/controller/services/services.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed force-pushed the operator-ui-deployment branch from a833b5f to cf67d03 Compare

January 23, 2025 15:31

tchughesiv requested changes

Jan 23, 2025

View reviewed changes

Comment thread

infra/feast-operator/config/samples/v1alpha1_featurestore_tls_disable.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

infra/feast-operator/internal/controller/services/services.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

infra/feast-operator/internal/controller/services/services.go Resolved

Uh oh!

There was an error while loading. Please reload this page.


          adding tls config for ui

f3c3d61

Signed-off-by: Abdul Hameed <[email protected]>

redhatHameed force-pushed the operator-ui-deployment branch from cf67d03 to f3c3d61 Compare

January 23, 2025 16:13

tchughesiv approved these changes

Jan 23, 2025

View reviewed changes

tchughesiv left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed reacted with hooray emoji

All reactions

🎉 1 reaction

tchughesiv merged commit b026d0c into feast-dev:master

Jan 23, 2025

franciscojavierarceo pushed a commit that referenced this pull request

Feb 4, 2025


          chore(release): release 0.44.0

aa7224a

# [0.44.0](v0.43.0...v0.44.0) (2025-02-04)

### Bug Fixes

* Adding periodic check to fix the sporadic failures of the operator e2e tests.  ([#4952](#4952)) ([1d086be](1d086be))
* Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee))
* Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f))
* Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962)
* Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85))
* Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d))
* Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939))
* Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9))
* Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52))
* Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703))
* Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3))
* Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102))
* Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68))
* Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55))

### Features

* Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8))
* Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852))
* Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d))
* Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3))
* Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc))
* Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13))
* Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364))
* Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c))
* Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))

Reviewers

tchughesiv

tchughesiv approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

redhatHameed commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tchughesiv left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

redhatHameed commented Jan 17, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.