GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Implementing online_read for MilvusOnlineStore by franciscojavierarceo · Pull Request #4996 · feast-dev/feast

Conversation

franciscojavierarceo commented Jan 31, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

What this PR does / why we need it:

This pull request includes several updates and improvements to the Feast project, focusing on the integration and enhancement of the Milvus online store. Below is a detailed summary of the changes made:

Examples Update
- README.md: Modified the materialization steps for features into the online store by switching to Python code snippets.
- milvus-quickstart.ipynb: Format change.
Milvus Online Store Enhancements
- milvus.py:
  - Removed unused imports.
  - Added VALUE_TYPE_TO_PROTO_VALUE_MAP for mapping value types.
  - Introduced a new method _get_composite_key_name to generate composite key names.
  - Updated methods to utilize _get_composite_key_name for consistency.
  - Implemented the online_read method to handle reading from the Milvus online store.
  - Improved the _extract_proto_values_to_dict method to handle more numeric types and serialization.
Type Map Enhancements
- type_map.py:
  - Added VALUE_TYPE_TO_PROTO_VALUE_MAP for better type conversion.
Feast Types Enhancements
- types.py:
  - Introduced from_feast_type method to convert Feast types to ValueType.
Example Repository Updates
- example_feature_repo_1.py:
  - Updated the schema for document_embeddings to include vector index and search metric attributes.
Unit Tests Enhancements
- test_online_retrieval.py:
  - Modified test_get_online_features for better readability.
  - Added comprehensive tests for Milvus online features retrieval.
  - Added skipping marker for test_local_milvus due to CI issues.

Testing

Comprehensive unit tests have been added and modified to ensure the functionality of the changes made.
Manual testing was performed to validate the integration with the Milvus online store.

Which issue(s) this PR fixes:

Another for #4364

Misc

The test_local_milvus has been marked to be skipped due to CI struggles. Further investigation is needed to address this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo added 3 commits

January 31, 2025 07:12


          feat: Implementing online_read for MilvusOnlineStore

f448b2c

Signed-off-by: Francisco Javier Arceo <[email protected]>


          updated tests and implementation to handle for missing entities

7aa8e77

Signed-off-by: Francisco Javier Arceo <[email protected]>


          ignoring local milvus test

28b05c5

Signed-off-by: Francisco Javier Arceo <[email protected]>

franciscojavierarceo added the ok-to-test label

Feb 1, 2025

franciscojavierarceo marked this pull request as ready for review

February 1, 2025 01:50

franciscojavierarceo requested a review from a team as a code owner

February 1, 2025 01:50

shuchu reviewed

Feb 1, 2025

View reviewed changes

Comment thread

sdk/python/feast/types.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

lokeshrangineni reviewed

Feb 1, 2025

View reviewed changes

Comment thread

sdk/python/tests/unit/online_store/test_online_retrieval.py Outdated

		full_feature_names=False,
		)

		# TODO: Need to fix these tests to actually run corecctly.

lokeshrangineni Feb 1, 2025

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this needs to revisit now or later?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo Feb 1, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to handle that in a follow up PR too. Trying to get a release out soon was the main reason.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo Feb 1, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo added 3 commits

February 1, 2025 05:19


          adding milvus md and incorporating feedback from Lokesh

edba589

Signed-off-by: Francisco Javier Arceo <[email protected]>


          including Milvus in summary page

8c605c1

Signed-off-by: Francisco Javier Arceo <[email protected]>


          linter

cb71592

Signed-off-by: Francisco Javier Arceo <[email protected]>

shuchu approved these changes

Feb 1, 2025

View reviewed changes

shuchu left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo merged commit 92dde13 into master

Feb 1, 2025

dmartinol commented Feb 3, 2025

Copy link

Copy Markdown

Contributor

amazing example notebook, thank you! 💯

franciscojavierarceo reacted with hooray emoji

franciscojavierarceo reacted with heart emoji

All reactions

🎉 1 reaction
❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo pushed a commit that referenced this pull request

Feb 4, 2025


          chore(release): release 0.44.0

aa7224a

# [0.44.0](v0.43.0...v0.44.0) (2025-02-04)

### Bug Fixes

* Adding periodic check to fix the sporadic failures of the operator e2e tests.  ([#4952](#4952)) ([1d086be](1d086be))
* Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee))
* Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f))
* Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962)
* Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85))
* Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d))
* Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939))
* Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9))
* Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52))
* Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703))
* Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3))
* Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102))
* Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68))
* Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55))

### Features

* Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8))
* Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852))
* Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d))
* Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3))
* Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc))
* Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13))
* Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364))
* Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c))
* Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))

Reviewers

lokeshrangineni

lokeshrangineni left review comments

shuchu

shuchu approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

franciscojavierarceo commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Testing

Which issue(s) this PR fixes:

Misc

Uh oh!

Uh oh!

lokeshrangineni Feb 1, 2025

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Feb 1, 2025

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Feb 1, 2025

Choose a reason for hiding this comment

Uh oh!

shuchu left a comment

Choose a reason for hiding this comment

Uh oh!

dmartinol commented Feb 3, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

franciscojavierarceo commented Jan 31, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.