GeezerVison is showing github.com — chore: Add ability to change default feature-server image during Operator deploy by tchughesiv · Pull Request #4940 · feast-dev/feast
Conversation
tchughesiv
commented
Jan 20, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
What this PR does / why we need it:
Related to #4928
This allows a user to set the FS_IMG env variable during Operator manifest generation. The result will be a modified RELATED_IMAGE_FEATURE_SERVER env var in the Operator deployment object.
e.g.
$ make build-installer bundle FS_IMG=localhost/feastdev/feature-server:dev
$ make deploy FS_IMG=localhost/feastdev/feature-server:dev
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tchughesiv
changed the title
chore: Add ability to change feature-server default image during Operator deploy
chore: Add ability to change default feature-server image during Operator deploy
Jan 20, 2025
tchughesiv
added a commit
that referenced
this pull request
Jan 21, 2025
…ator deploy (v0.43-branch) (#4941)
chore: Add ability to change default feature-server image during Operator deploy (#4940)
Signed-off-by: Tommy Hughes <[email protected]>
franciscojavierarceo
added a commit
that referenced
this pull request
Jan 23, 2025
* fix: Update workflows to also use workflow_call
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Also adding workflow_call to release version
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Adding type to release version input
Signed-off-by: Francisco Javier Arceo <[email protected]>
* chore: Fix operator release workflow (v0.43-branch) (#4937)
fix operator release workflow
Signed-off-by: Tommy Hughes <[email protected]>
* fix: Updated type in yaml
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Updating publish.yml
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Update type in publish_images
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Updating publish helm charts
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Updating publish java sdk
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Updating environment variable in the build_wheels
Signed-off-by: Francisco Javier Arceo <[email protected]>
* updating input parameters to build wheels
Signed-off-by: Francisco Javier Arceo <[email protected]>
* formatting issue
Signed-off-by: Francisco Javier Arceo <[email protected]>
* chore: Fix operator release for 0.43.0 (v0.43-branch) (#4939)
fix operator release for 0.43.0
Signed-off-by: Tommy Hughes <[email protected]>
* renaming args and adding more
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Adding outputs to build_wheels workflow
Signed-off-by: Francisco Javier Arceo <[email protected]>
* reverting changes
Signed-off-by: Francisco Javier Arceo <[email protected]>
* chore: Add ability to change default feature-server image during Operator deploy (v0.43-branch) (#4941)
chore: Add ability to change default feature-server image during Operator deploy (#4940)
Signed-off-by: Tommy Hughes <[email protected]>
* chore: CR image no longer needed for e2e (v0.43-branch) (#4943)
CR image no longer needed for e2e
Signed-off-by: Tommy Hughes <[email protected]>
* chore: Fix publish, versions issue (#4944)
fix publish, versions issue
Signed-off-by: Tommy Hughes <[email protected]>
* chore: Fix publish, versions issue (#4945)
fix publish, versions issue
Signed-off-by: Tommy Hughes <[email protected]>
* chore: Fix publish, versions issue (#4946)
fix publish, versions issue
Signed-off-by: Tommy Hughes <[email protected]>
* chore: Fix publish, versions issue (#4947)
fix publish, versions issue
Signed-off-by: Tommy Hughes <[email protected]>
* fix publish, versions issue (#4948)
Signed-off-by: Tommy Hughes <[email protected]>
* fix: adding checkout to publish sdk
Signed-off-by: Francisco Javier Arceo <[email protected]>
* chore: Change get version workflow to an action (#4951)
change get version workflow to an action
Signed-off-by: Tommy Hughes <[email protected]>
* fix: Release Fix - Added the workflow_call element in missing workflows (#4954)
Added the workflow_call element in all the workflows wherever there is a workflow_dispatch element to see if that fixes the problem to be able to call the workflow from another workflow.
Signed-off-by: lrangine <[email protected]>
* chore: Build wheels fix (#4957)
dev
Signed-off-by: Tommy Hughes <[email protected]>
* chore: Fix python-sdk workflow (#4958)
dev
Signed-off-by: Tommy Hughes <[email protected]>
* fix: adding type and workflow_call to build_wheels.yml
Signed-off-by: Francisco Javier Arceo <[email protected]>
* chore: Remove checkout from get-version action (#4959)
dev
Signed-off-by: Tommy Hughes <[email protected]>
* chore: Fixing build wheels pre-release image build (#4960)
dev
Signed-off-by: Tommy Hughes <[email protected]>
* fix: Updating pypi upload to use legacy repo url (#4962)
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Updating repostiry to repostory url
Signed-off-by: Francisco Javier Arceo <[email protected]>
* converting to dash to see if that works
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Updating pypi publish action and adding name
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: moving back to kebab case
Signed-off-by: Francisco Javier Arceo <[email protected]>
* fix: Trying to hardcode gh-action version
Signed-off-by: Francisco Javier Arceo <[email protected]>
* trying new version with oidc false
Signed-off-by: Francisco Javier Arceo <[email protected]>
* trying without attestations
Signed-off-by: Francisco Javier Arceo <[email protected]>
* reverting again to old action and removing checkout action
Signed-off-by: Francisco Javier Arceo <[email protected]>
* reverting code to existing master without actions checkout
Signed-off-by: Francisco Javier Arceo <[email protected]>
* logging token length to validate it and adding quotes to password
Signed-off-by: Francisco Javier Arceo <[email protected]>
* adding logging to the build wheels to see if secret is present there
Signed-off-by: Francisco Javier Arceo <[email protected]>
* adding secrets to jobs keyword
Signed-off-by: Francisco Javier Arceo <[email protected]>
* adding input parameters to build wheels and publish python sdk
Signed-off-by: Francisco Javier Arceo <[email protected]>
* addding inherit
Signed-off-by: Francisco Javier Arceo <[email protected]>
* commenting out the publish python sdk and adding inherit
Signed-off-by: Francisco Javier Arceo <[email protected]>
* commenting out the needs
Signed-off-by: Francisco Javier Arceo <[email protected]>
* removing commented out code and logging to incorporate code that worked
Signed-off-by: Francisco Javier Arceo <[email protected]>
* adding one more change to remove logging
Signed-off-by: Francisco Javier Arceo <[email protected]>
* removing changes outside of actions
Signed-off-by: Francisco Javier Arceo <[email protected]>
* removing makefile change
Signed-off-by: Francisco Javier Arceo <[email protected]>
* removing yamls
Signed-off-by: Francisco Javier Arceo <[email protected]>
* removing changes files and reverting move of file
Signed-off-by: Francisco Javier Arceo <[email protected]>
* reverting changed files
Signed-off-by: Francisco Javier Arceo <[email protected]>
---------
Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: lrangine <[email protected]>
Co-authored-by: Tommy Hughes IV <[email protected]>
Co-authored-by: lokeshrangineni <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|