GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Add ability to change default feature-server image during Operator deploy by tchughesiv · Pull Request #4940 · feast-dev/feast

Conversation

@tchughesiv

@tchughesiv tchughesiv commented Jan 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Related to #4928

This allows a user to set the FS_IMG env variable during Operator manifest generation. The result will be a modified RELATED_IMAGE_FEATURE_SERVER env var in the Operator deployment object.

e.g.

$ make build-installer bundle FS_IMG=localhost/feastdev/feature-server:dev
$ make deploy FS_IMG=localhost/feastdev/feature-server:dev

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tchughesiv tchughesiv added the ok-to-test label Jan 20, 2025
@tchughesiv
tchughesiv force-pushed the feastImgFlag branch from 9d9e61f to c72eb41 Compare January 20, 2025 22:39
@tchughesiv
tchughesiv marked this pull request as ready for review January 20, 2025 22:40
@tchughesiv
tchughesiv requested a review from a team as a code owner January 20, 2025 22:40
@tchughesiv
set feast image during deploy
125933c
Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
tchughesiv force-pushed the feastImgFlag branch from c72eb41 to 125933c Compare January 20, 2025 22:45
@tchughesiv tchughesiv changed the title chore: Add ability to change feature-server default image during Operator deploy chore: Add ability to change default feature-server image during Operator deploy Jan 20, 2025
lokeshrangineni
lokeshrangineni approved these changes Jan 20, 2025
View reviewed changes
@tchughesiv
tchughesiv merged commit d9e6c6a into feast-dev:master Jan 20, 2025
tchughesiv added a commit to tchughesiv/feast that referenced this pull request Jan 21, 2025
@tchughesiv
chore: Add ability to change default feature-server image during Oper…
ef446c6
…ator deploy (feast-dev#4940)
@tchughesiv tchughesiv mentioned this pull request Jan 21, 2025
chore: Add ability to change default feature-server image during Operator deploy (v0.43-branch) #4941
Merged
tchughesiv added a commit to tchughesiv/feast that referenced this pull request Jan 21, 2025
@tchughesiv
chore: Add ability to change default feature-server image during Oper…
fd064c4
…ator deploy (feast-dev#4940)

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv tchughesiv mentioned this pull request Jan 21, 2025
chore: Remove CR image from e2e samples #4942
Merged
tchughesiv added a commit that referenced this pull request Jan 21, 2025
@tchughesiv
chore: Add ability to change default feature-server image during Oper…
7379db3
…ator deploy (v0.43-branch) (#4941)

chore: Add ability to change default feature-server image during Operator deploy (#4940)

Signed-off-by: Tommy Hughes <[email protected]>
tmihalac pushed a commit to opendatahub-io/feast that referenced this pull request Jan 21, 2025
@tchughesiv @tmihalac
chore: Add ability to change default feature-server image during Oper…
2ca1455
…ator deploy (feast-dev#4940)
franciscojavierarceo added a commit that referenced this pull request Jan 23, 2025
@franciscojavierarceo @tchughesiv @lokeshrangineni
fix: Fix GitHub Actions to pass authentication (#4963)
22b9138
* fix: Update workflows to also use workflow_call

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Also adding workflow_call to release version

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Adding type to release version input

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Fix operator release workflow (v0.43-branch) (#4937)

fix operator release workflow

Signed-off-by: Tommy Hughes <[email protected]>

* fix: Updated type in yaml

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Updating publish.yml

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Update type in publish_images

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Updating publish helm charts

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Updating publish java sdk

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Updating environment variable in the build_wheels

Signed-off-by: Francisco Javier Arceo <[email protected]>

* updating input parameters to build wheels

Signed-off-by: Francisco Javier Arceo <[email protected]>

* formatting issue

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Fix operator release for 0.43.0 (v0.43-branch) (#4939)

fix operator release for 0.43.0

Signed-off-by: Tommy Hughes <[email protected]>

* renaming args and adding more

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Adding outputs to build_wheels workflow

Signed-off-by: Francisco Javier Arceo <[email protected]>

* reverting changes

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Add ability to change default feature-server image during Operator deploy (v0.43-branch) (#4941)

chore: Add ability to change default feature-server image during Operator deploy (#4940)

Signed-off-by: Tommy Hughes <[email protected]>

* chore: CR image no longer needed for e2e (v0.43-branch) (#4943)

CR image no longer needed for e2e

Signed-off-by: Tommy Hughes <[email protected]>

* chore: Fix publish, versions issue (#4944)

fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>

* chore: Fix publish, versions issue (#4945)

fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>

* chore: Fix publish, versions issue (#4946)

fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>

* chore: Fix publish, versions issue (#4947)

fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>

* fix publish, versions issue (#4948)

Signed-off-by: Tommy Hughes <[email protected]>

* fix: adding checkout to publish sdk

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Change get version workflow to an action (#4951)

change get version workflow to an action

Signed-off-by: Tommy Hughes <[email protected]>

* fix: Release Fix - Added the workflow_call element in missing workflows  (#4954)

Added the workflow_call element in all the workflows wherever there is a workflow_dispatch element to see if that fixes the problem to be able to call the workflow from another workflow.

Signed-off-by: lrangine <[email protected]>

* chore: Build wheels fix (#4957)

dev

Signed-off-by: Tommy Hughes <[email protected]>

* chore: Fix python-sdk workflow (#4958)

dev

Signed-off-by: Tommy Hughes <[email protected]>

* fix: adding type and workflow_call to build_wheels.yml

Signed-off-by: Francisco Javier Arceo <[email protected]>

* chore: Remove checkout from get-version action (#4959)

dev

Signed-off-by: Tommy Hughes <[email protected]>

* chore: Fixing build wheels pre-release image build (#4960)

dev

Signed-off-by: Tommy Hughes <[email protected]>

* fix: Updating pypi upload to use legacy repo url (#4962)

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Updating repostiry to repostory url

Signed-off-by: Francisco Javier Arceo <[email protected]>

* converting to dash to see if that works

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Updating pypi publish action and adding name

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: moving back to kebab case

Signed-off-by: Francisco Javier Arceo <[email protected]>

* fix: Trying to hardcode gh-action version

Signed-off-by: Francisco Javier Arceo <[email protected]>

* trying new version with oidc false

Signed-off-by: Francisco Javier Arceo <[email protected]>

* trying without attestations

Signed-off-by: Francisco Javier Arceo <[email protected]>

* reverting again to old action and removing checkout action

Signed-off-by: Francisco Javier Arceo <[email protected]>

* reverting code to existing master without actions checkout

Signed-off-by: Francisco Javier Arceo <[email protected]>

* logging token length to validate it and adding quotes to password

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding logging to the build wheels to see if secret is present there

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding secrets to jobs keyword

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding input parameters to build wheels and publish python sdk

Signed-off-by: Francisco Javier Arceo <[email protected]>

* addding inherit

Signed-off-by: Francisco Javier Arceo <[email protected]>

* commenting out the publish python sdk and adding inherit

Signed-off-by: Francisco Javier Arceo <[email protected]>

* commenting out the needs

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing commented out code and logging to incorporate code that worked

Signed-off-by: Francisco Javier Arceo <[email protected]>

* adding one more change to remove logging

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing changes outside of actions

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing makefile change

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing yamls

Signed-off-by: Francisco Javier Arceo <[email protected]>

* removing changes files and reverting move of file

Signed-off-by: Francisco Javier Arceo <[email protected]>

* reverting changed files

Signed-off-by: Francisco Javier Arceo <[email protected]>

---------

Signed-off-by: Francisco Javier Arceo <[email protected]>
Signed-off-by: Tommy Hughes <[email protected]>
Signed-off-by: lrangine <[email protected]>
Co-authored-by: Tommy Hughes IV <[email protected]>
Co-authored-by: lokeshrangineni <[email protected]>
franciscojavierarceo pushed a commit that referenced this pull request Feb 4, 2025
@feast-ci-bot
chore(release): release 0.44.0
aa7224a
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04)

### Bug Fixes

* Adding periodic check to fix the sporadic failures of the operator e2e tests.  ([#4952](#4952)) ([1d086be](1d086be))
* Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee))
* Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f))
* Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962)
* Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85))
* Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d))
* Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939))
* Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9))
* Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52))
* Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703))
* Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3))
* Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102))
* Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68))
* Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55))

### Features

* Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8))
* Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852))
* Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d))
* Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3))
* Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc))
* Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13))
* Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364))
* Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c))
* Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokeshrangineni lokeshrangineni lokeshrangineni approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tchughesiv @lokeshrangineni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.