GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Update manifest to add feature server image for odh by redhatHameed · Pull Request #4973 · feast-dev/feast

Conversation

@redhatHameed

@redhatHameed redhatHameed commented Jan 27, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Update manifest to add feature server image for odh

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@redhatHameed
redhatHameed requested a review from a team as a code owner January 27, 2025 21:53
@redhatHameed
redhatHameed marked this pull request as draft January 27, 2025 22:19
@redhatHameed
redhatHameed force-pushed the add-env branch from 61d3d8b to 6969c01 Compare January 28, 2025 15:06
@redhatHameed
redhatHameed marked this pull request as ready for review January 28, 2025 15:07
@redhatHameed redhatHameed added the ok-to-test label Jan 28, 2025
tchughesiv
tchughesiv requested changes Jan 28, 2025
View reviewed changes

@tchughesiv tchughesiv left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread infra/scripts/release/files_to_bump.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

redhatHameed and others added 2 commits January 28, 2025 10:44
@redhatHameed
fix: update manifest to add feature server image for odh
02a1fc4
Signed-off-by: Abdul Hameed <[email protected]>
@redhatHameed @tchughesiv
Update infra/scripts/release/files_to_bump.txt
b8a4559
Co-authored-by: Tommy Hughes IV <[email protected]>
Signed-off-by: Abdul Hameed <[email protected]>
@redhatHameed
redhatHameed force-pushed the add-env branch from 1cc1bab to b8a4559 Compare January 28, 2025 15:44
tchughesiv
tchughesiv requested changes Jan 28, 2025
View reviewed changes

@tchughesiv tchughesiv left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@redhatHameed
redhatHameed enabled auto-merge (squash) January 28, 2025 15:50
@redhatHameed
redhatHameed requested a review from tchughesiv January 28, 2025 16:09
@redhatHameed
redhatHameed disabled auto-merge January 28, 2025 16:13
@redhatHameed
redhatHameed enabled auto-merge (squash) January 28, 2025 16:13
tchughesiv
tchughesiv approved these changes Jan 28, 2025
View reviewed changes
@redhatHameed
redhatHameed merged commit 6a1c102 into feast-dev:master Jan 28, 2025
redhatHameed added a commit to redhatHameed/feast that referenced this pull request Jan 28, 2025
@redhatHameed @tchughesiv
fix: Update manifest to add feature server image for odh (feast-dev#4973
aa504e8
)

* fix: update manifest to add feature server image for odh

Signed-off-by: Abdul Hameed <[email protected]>

* Update infra/scripts/release/files_to_bump.txt

Co-authored-by: Tommy Hughes IV <[email protected]>
Signed-off-by: Abdul Hameed <[email protected]>

---------

Signed-off-by: Abdul Hameed <[email protected]>
Co-authored-by: Tommy Hughes IV <[email protected]>
@redhatHameed redhatHameed mentioned this pull request Jan 28, 2025
fix: Update manifest to add feature server image for odh (v0.43) #4978
Merged
franciscojavierarceo pushed a commit that referenced this pull request Feb 4, 2025
@feast-ci-bot
chore(release): release 0.44.0
aa7224a
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04)

### Bug Fixes

* Adding periodic check to fix the sporadic failures of the operator e2e tests.  ([#4952](#4952)) ([1d086be](1d086be))
* Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee))
* Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f))
* Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962)
* Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85))
* Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d))
* Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939))
* Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9))
* Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52))
* Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703))
* Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3))
* Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102))
* Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68))
* Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55))

### Features

* Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8))
* Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852))
* Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d))
* Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3))
* Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc))
* Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13))
* Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364))
* Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c))
* Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchughesiv tchughesiv tchughesiv approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@redhatHameed @tchughesiv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.