GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Fix GitHub Actions to pass authentication by franciscojavierarceo · Pull Request #4963 · feast-dev/feast

Conversation

@franciscojavierarceo

@franciscojavierarceo franciscojavierarceo commented Jan 23, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Fixes the publish workflow to propagate secrets.

Which issue(s) this PR fixes:

n/a

Misc

Learnings from release 0.43.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
franciscojavierarceo and others added 30 commits January 20, 2025 11:14
@franciscojavierarceo
fix: Update workflows to also use workflow_call
f347200
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Also adding workflow_call to release version
7f16143
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Adding type to release version input
5efd815
Signed-off-by: Francisco Javier Arceo <[email protected]>
@tchughesiv
chore: Fix operator release workflow (v0.43-branch) (#4937)
79a915a
fix operator release workflow

Signed-off-by: Tommy Hughes <[email protected]>
@franciscojavierarceo
fix: Updated type in yaml
e67106b
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Updating publish.yml
84e4858
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Update type in publish_images
6891c58
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Updating publish helm charts
5300dd6
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Updating publish java sdk
1c5c3d8
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Updating environment variable in the build_wheels
aacb68e
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
updating input parameters to build wheels
31559b7
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
formatting issue
4b60b1e
Signed-off-by: Francisco Javier Arceo <[email protected]>
@tchughesiv
chore: Fix operator release for 0.43.0 (v0.43-branch) (#4939)
1ebf243
fix operator release for 0.43.0

Signed-off-by: Tommy Hughes <[email protected]>
@franciscojavierarceo
renaming args and adding more
ccaf71d
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Adding outputs to build_wheels workflow
d9435b6
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
reverting changes
b95c0d3
Signed-off-by: Francisco Javier Arceo <[email protected]>
@tchughesiv
chore: Add ability to change default feature-server image during Oper…
7379db3
…ator deploy (v0.43-branch) (#4941)

chore: Add ability to change default feature-server image during Operator deploy (#4940)

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
chore: CR image no longer needed for e2e (v0.43-branch) (#4943)
9e1b4db
CR image no longer needed for e2e

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
chore: Fix publish, versions issue (#4944)
c8378a3
fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
chore: Fix publish, versions issue (#4945)
2fd6d1a
fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
chore: Fix publish, versions issue (#4946)
002c075
fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
chore: Fix publish, versions issue (#4947)
c5b2085
fix publish, versions issue

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
fix publish, versions issue (#4948)
ca18b6e
Signed-off-by: Tommy Hughes <[email protected]>
@franciscojavierarceo
fix: adding checkout to publish sdk
3ee27ee
Signed-off-by: Francisco Javier Arceo <[email protected]>
@tchughesiv
chore: Change get version workflow to an action (#4951)
8196d78
change get version workflow to an action

Signed-off-by: Tommy Hughes <[email protected]>
@lokeshrangineni
fix: Release Fix - Added the workflow_call element in missing workflo…
301ef9a
…ws (#4954)

Added the workflow_call element in all the workflows wherever there is a workflow_dispatch element to see if that fixes the problem to be able to call the workflow from another workflow.

Signed-off-by: lrangine <[email protected]>
@tchughesiv
chore: Build wheels fix (#4957)
44ec146
dev

Signed-off-by: Tommy Hughes <[email protected]>
@tchughesiv
chore: Fix python-sdk workflow (#4958)
e93d164
dev

Signed-off-by: Tommy Hughes <[email protected]>
@franciscojavierarceo
fix: adding type and workflow_call to build_wheels.yml
922bd65
Signed-off-by: Francisco Javier Arceo <[email protected]>
@tchughesiv
chore: Remove checkout from get-version action (#4959)
b502f46
dev

Signed-off-by: Tommy Hughes <[email protected]>
tchughesiv and others added 20 commits January 22, 2025 13:29
@tchughesiv
chore: Fixing build wheels pre-release image build (#4960)
33725c3
dev

Signed-off-by: Tommy Hughes <[email protected]>
@franciscojavierarceo
fix: Updating pypi upload to use legacy repo url (#4962)
f392c73
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Updating repostiry to repostory url
6e80c26
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
converting to dash to see if that works
daf2236
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Updating pypi publish action and adding name
cf5d4ab
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: moving back to kebab case
6081fd2
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
fix: Trying to hardcode gh-action version
cfd345f
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
trying new version with oidc false
4b83bd7
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
trying without attestations
62f4c52
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
reverting again to old action and removing checkout action
308b864
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
reverting code to existing master without actions checkout
420ffbb
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
logging token length to validate it and adding quotes to password
c8c4312
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding logging to the build wheels to see if secret is present there
3aa873b
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding secrets to jobs keyword
5927dd4
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding input parameters to build wheels and publish python sdk
8eaa8ec
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
addding inherit
c83e705
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
commenting out the publish python sdk and adding inherit
2be247d
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
commenting out the needs
82c7415
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removing commented out code and logging to incorporate code that worked
242ad7a
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
adding one more change to remove logging
8d43d32
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
franciscojavierarceo requested a review from a team as a code owner January 23, 2025 03:47
franciscojavierarceo added 5 commits January 22, 2025 22:56
@franciscojavierarceo
removing changes outside of actions
9152d60
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removing makefile change
d7d9a5b
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removing yamls
5b5b833
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
removing changes files and reverting move of file
51b330f
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo
reverting changed files
db4a1e7
Signed-off-by: Francisco Javier Arceo <[email protected]>
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Jan 23, 2025
lokeshrangineni
lokeshrangineni approved these changes Jan 23, 2025
View reviewed changes
@franciscojavierarceo
franciscojavierarceo merged commit 22b9138 into master Jan 23, 2025
franciscojavierarceo pushed a commit that referenced this pull request Feb 4, 2025
@feast-ci-bot
chore(release): release 0.44.0
aa7224a
# [0.44.0](v0.43.0...v0.44.0) (2025-02-04)

### Bug Fixes

* Adding periodic check to fix the sporadic failures of the operator e2e tests.  ([#4952](#4952)) ([1d086be](1d086be))
* Adding the feast-operator/bin to the .gitignore directory. Somehow it… ([#5005](#5005)) ([1a027ee](1a027ee))
* Changed Env Vars for e2e tests ([#4975](#4975)) ([fa0084f](fa0084f))
* Fix GitHub Actions to pass authentication ([#4963](#4963)) ([22b9138](22b9138)), closes [#4937](#4937) [#4939](#4939) [#4941](#4941) [#4940](#4940) [#4943](#4943) [#4944](#4944) [#4945](#4945) [#4946](#4946) [#4947](#4947) [#4948](#4948) [#4951](#4951) [#4954](#4954) [#4957](#4957) [#4958](#4958) [#4959](#4959) [#4960](#4960) [#4962](#4962)
* Fix showing selected navigation item in UI sidebar ([#4969](#4969)) ([8ac6a85](8ac6a85))
* Invalid column names in get_historical_features when there are field mappings on join keys ([#4886](#4886)) ([c9aca2d](c9aca2d))
* Read project data from the 'projects' key while loading the registry state in the Feast UI ([#4772](#4772)) ([cb81939](cb81939))
* Remove grpcurl dependency from Operator ([#4972](#4972)) ([439e0b9](439e0b9))
* Removed the dry-run flag to test and we will add it back later. ([#5007](#5007)) ([d112b52](d112b52))
* Render UI navigation items as links instead of buttons ([#4970](#4970)) ([1267703](1267703))
* Resolve Operator CRD bloat due to long field descriptions ([#4985](#4985)) ([7593bb3](7593bb3))
* Update manifest to add feature server image for odh ([#4973](#4973)) ([6a1c102](6a1c102))
* Updating release workflows to refer to yml instead of yaml ([#4935](#4935)) ([02b0a68](02b0a68))
* Use locally built feast-ui package in dev feature-server image ([#4998](#4998)) ([0145e55](0145e55))

### Features

* Added OWNERS file for OpenshiftCI ([#4991](#4991)) ([86a2ee8](86a2ee8))
* Adding Milvus demo to examples ([#4910](#4910)) ([2daf852](2daf852))
* Adding retrieve_online_documents endpoint ([#5002](#5002)) ([6607d3d](6607d3d))
* Adding support to return additional features from vector retrieval for Milvus db ([#4971](#4971)) ([6ce08d3](6ce08d3))
* Creating/updating the stable branch after the release. ([#5003](#5003)) ([e9b53cc](e9b53cc))
* Implementing online_read for MilvusOnlineStore ([#4996](#4996)) ([92dde13](92dde13))
* Improve exception message for unsupported Snowflake data types ([#4779](#4779)) ([5992364](5992364))
* Operator add feast ui deployment ([#4930](#4930)) ([b026d0c](b026d0c))
* Updating documents to highlight v2 api for Vector Similarity Se… ([#5000](#5000)) ([32b82a4](32b82a4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lokeshrangineni lokeshrangineni lokeshrangineni approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@franciscojavierarceo @lokeshrangineni @tchughesiv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.