GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Updated python packages conflicting with kserve dependencies by aniketpalu · Pull Request #5580 · feast-dev/feast

Conversation

@aniketpalu

@aniketpalu aniketpalu commented Aug 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Updated following python packages conflicting with kserve dependencies.

  1. uvicorn dependency version range updated to 0.30.6 to 0.34.0
  2. kubernetes dependency version range updated to 20.13.0 to 23.3.0

Which issue(s) this PR fixes:

RHOAIENG-31060

Misc

kserve/kserve#4646

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@aniketpalu
fix: Upgraded python packages conflicting with kserve dependencies
2813036
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
aniketpalu requested a review from a team as a code owner August 25, 2025 11:43
aniketpalu added 2 commits August 25, 2025 18:02
@aniketpalu
Added hashes for all the requirements
e3a5d1e
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
Updated dependency hashes to be flexible & use latest versions when p…
87970c7
…ossible

Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu aniketpalu changed the title fix: Upgraded python packages conflicting with kserve dependencies fix: Updated python packages conflicting with kserve dependencies Aug 25, 2025
@ntkathole

ntkathole commented Aug 25, 2025

Copy link
Copy Markdown
Member

@aniketpalu Please update the setup.py as well to match pyproject.toml

aniketpalu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ntkathole ntkathole added the ok-to-test label Aug 25, 2025
@franciscojavierarceo

franciscojavierarceo commented Aug 25, 2025

Copy link
Copy Markdown
Member

while we're at it, can you add a test to make sure these are in sync? doesn't have to be overly elaborate but probably we should catch this sooner.

aniketpalu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aniketpalu and others added 3 commits August 25, 2025 19:24
@aniketpalu
Updated setup.py to match dependency version range with pyproject.toml
7503f18
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
Merge branch 'feast-dev:master' into kserve-dependency-conflict
1dd6556
@aniketpalu
Added test to check if kserve & feast can be installed in same enviro…
2ee9b07
…nment

Signed-off-by: Aniket Paluskar <[email protected]>
franciscojavierarceo
franciscojavierarceo reviewed Aug 28, 2025
View reviewed changes
Comment thread sdk/python/tests/unit/infra/test_dependency_conflicts.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

jyejare
jyejare approved these changes Sep 1, 2025
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ntkathole
ntkathole approved these changes Sep 2, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ntkathole
ntkathole requested a review from franciscojavierarceo September 4, 2025 08:15
aniketpalu added 2 commits September 10, 2025 00:09
@aniketpalu
Conflicts resolved
06eaa32
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
Regenerated the requirements hash
7a2e979
Signed-off-by: Aniket Paluskar <[email protected]>
@franciscojavierarceo

franciscojavierarceo commented Sep 10, 2025

Copy link
Copy Markdown
Member

unit tests are failing, please resolve. unit tests shouldn't be flakey.

aniketpalu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aniketpalu and others added 2 commits September 17, 2025 12:26
@aniketpalu
Merge branch 'feast-dev:master' into kserve-dependency-conflict
1838d12
@franciscojavierarceo
Merge branch 'master' into kserve-dependency-conflict
37efd50
franciscojavierarceo
franciscojavierarceo reviewed Sep 17, 2025
View reviewed changes
Comment thread sdk/python/tests/unit/infra/test_dependency_conflicts.py
Ensures no dependency conflict errors occur.
"""
# Command to install KServe
command = [sys.executable, "-m", "pip", "install", "kserve==0.15.2"]

@franciscojavierarceo franciscojavierarceo Sep 17, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this specific version feels kind of brittle

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@franciscojavierarceo
franciscojavierarceo merged commit d56baf4 into feast-dev:master Sep 17, 2025
franciscojavierarceo pushed a commit that referenced this pull request Sep 30, 2025
@feast-ci-bot
chore(release): release 0.54.0
99a321a
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo left review comments
@jyejare jyejare jyejare approved these changes
@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aniketpalu @ntkathole @franciscojavierarceo @jyejare
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.