GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Fix Go feature server entitykey serialization for version 3 by shuchu · Pull Request #5622 · feast-dev/feast

Conversation

@shuchu

@shuchu shuchu commented Sep 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

1, Update the Go version to 1.23. (Prepare for the OTEL implementation)
2, Fix the serialization EntityKey version 3 issue of Go Feature server. Now only version 3 serialization is supported.

Which issue(s) this PR fixes:

#5608

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shuchu
shuchu marked this pull request as ready for review September 20, 2025 02:28
@shuchu
shuchu requested a review from a team as a code owner September 20, 2025 02:28
shuchu added 3 commits September 19, 2025 22:29
@shuchu
fix: Fix the Makefile for Golang unit test.
d3c343d 
Signed-off-by: Shuchu Han <[email protected]>
@shuchu
fix: Update the serialization of EntityKey to version 3 in Go Feature…
262e840 
… server.

Signed-off-by: Shuchu Han <[email protected]>
@shuchu
fix: Add serialization verstion number in the feature_repo.yaml for t…
1bc8085 
…esting.

Signed-off-by: Shuchu Han <[email protected]>
@shuchu
shuchu force-pushed the fix/fix_golang_entitykey_serialization branch from 17ecbfd to 1bc8085 Compare September 20, 2025 02:29
@shuchu shuchu added the go Pull requests that update Go code label Sep 20, 2025
@shuchu
shuchu requested a review from franciscojavierarceo September 20, 2025 02:30
@shuchu

shuchu commented Sep 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

cc: @jyejare Hi, the Github does not allow me to add you as a reviewer. But please help me to review it. This PR includes some of your code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@shuchu
shuchu requested review from Copilot and haoxu0 September 20, 2025 02:31
Copilot AI reviewed Sep 20, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Go Feature Server to fix EntityKey serialization version 3 issues and upgrades Go to version 1.23. The changes focus on implementing proper serialization for EntityKey version 3 by adding a count prefix and reorganizing the serialization logic.

  • Updated Go version from 1.22.0 to 1.23
  • Fixed EntityKey serialization version 3 by adding join key count prefix and restructuring buffer layout
  • Moved serializeValue function from redisonlinestore.go to onlinestore.go for better code organization

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
go.mod Updates Go version to 1.23 and toolchain to 1.23.12
go/internal/feast/onlinestore/onlinestore.go Implements EntityKey v3 serialization with key count prefix and moves serializeValue function
go/internal/feast/onlinestore/redisonlinestore.go Removes serializeValue function (moved to onlinestore.go)
go/internal/feast/onlinestore/onlinestore_test.go Adds unit test for serializeEntityKey function
go/internal/test/feature_repo/feature_store.yaml Sets entity_key_serialization_version to 3
Makefile Updates build dependencies and test targets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread go/internal/feast/onlinestore/onlinestore.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread go/internal/feast/onlinestore/onlinestore.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@shuchu shuchu changed the title Fix/fix golang entitykey serialization fix: Fix golang entitykey serialization for version 3 Sep 20, 2025
@shuchu shuchu changed the title fix: Fix golang entitykey serialization for version 3 fix: Fix Go feature server entitykey serialization for version 3 Sep 20, 2025
shuchu added 2 commits September 19, 2025 22:39
@shuchu
fix: Fix a typo in one comment.
d0e7ff6 
Signed-off-by: Shuchu Han <[email protected]>
@shuchu
fix: Format the code.
567e8b0 
Signed-off-by: Shuchu Han <[email protected]>
jyejare
jyejare approved these changes Sep 20, 2025
View reviewed changes
@shuchu
shuchu merged commit 5ab18a6 into feast-dev:master Sep 22, 2025
franciscojavierarceo pushed a commit that referenced this pull request Sep 30, 2025
@feast-ci-bot
chore(release): release 0.54.0
99a321a 
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jyejare jyejare jyejare approved these changes
@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo
@haoxu0 haoxu0 Awaiting requested review from haoxu0

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shuchu @jyejare
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.