GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add aggregation in OnDemandFeatureView by haoxu0 · Pull Request #5629 · feast-dev/feast

Conversation

@haoxu0

@haoxu0 haoxu0 commented Sep 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@haoxu0
haoxu0 requested a review from a team as a code owner September 24, 2025 17:04
@haoxu0
add aggregation in OnDemandFeatureView
e707552
Signed-off-by: hao-xu5 <[email protected]>
@haoxu0
haoxu0 force-pushed the on-demand-feature-view-agg branch from 0a624ec to e707552 Compare September 24, 2025 17:06
@haoxu0 haoxu0 changed the title Add aggregation in OnDemandFeatureView feat: Add aggregation in OnDemandFeatureView Sep 24, 2025
franciscojavierarceo
franciscojavierarceo approved these changes Sep 24, 2025
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only including it, is the execution already supported?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@franciscojavierarceo franciscojavierarceo mentioned this pull request Sep 24, 2025
Add custom data type for OnDemandFeatureView #5631
Open
@haoxu0

haoxu0 commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator Author

this is only including it, is the execution already supported?

Yeah It's only adding the API but the behind compute engine should be able to use it for batch compute

franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo

franciscojavierarceo commented Sep 24, 2025

Copy link
Copy Markdown
Member

cool, i'd recommend adding a test for it just to show.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haoxu0

haoxu0 commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

cool, i'd recommend adding a test for it just to show.

yep, not completed yet. need to update the proto as well

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 added 2 commits September 25, 2025 22:08
@haoxu0
udpate proto
8d8dcde
Signed-off-by: hao-xu5 <[email protected]>
@haoxu0
fix lint
d0aa3d6
Signed-off-by: hao-xu5 <[email protected]>
@haoxu0 haoxu0 added the ok-to-test label Sep 26, 2025
haoxu0 and others added 2 commits September 25, 2025 22:29
@haoxu0
fix lint
175b8d1
Signed-off-by: hao-xu5 <[email protected]>
@haoxu0
Merge branch 'master' into on-demand-feature-view-agg
f366417
@haoxu0

haoxu0 commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

@franciscojavierarceo mind take an another look

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haoxu0
haoxu0 merged commit 8715ae8 into master Sep 26, 2025
@franciscojavierarceo

franciscojavierarceo commented Sep 27, 2025

Copy link
Copy Markdown
Member

Yeah just did, I didn't see a test showing the usage fwiw

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@haoxu0

haoxu0 commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator Author

Yeah just did, I didn't see a test showing the usage fwiw

Oh god forgot it. Will add in next pr

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo pushed a commit that referenced this pull request Sep 30, 2025
@feast-ci-bot
chore(release): release 0.54.0
99a321a
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
@franciscojavierarceo

franciscojavierarceo commented Nov 17, 2025

Copy link
Copy Markdown
Member

@HaoXuAI you creating aa follow up PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@franciscojavierarceo franciscojavierarceo mentioned this pull request Jan 14, 2026
Add blog post on new transformation framework #5856
Open
Copilot AI mentioned this pull request Jan 14, 2026
docs: Add blog post on unified transformation framework #5858
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@haoxu0 @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.