GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Update the deprecated functions in Go feature server. by shuchu · Pull Request #5632 · feast-dev/feast

Conversation

@shuchu

@shuchu shuchu commented Sep 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Updated few deprecated functions and libraries.

Which issue(s) this PR fixes:

Fix #5623

Misc

(feast) shuchu@shuchu-win:~/feast$ make test-go
python infra/scripts/generate_protos.py
Writing mypy to feast/core/Aggregation_pb2.pyi
Writing mypy to feast/core/Permission_pb2.pyi
Writing mypy to feast/core/DataFormat_pb2.pyi
Writing mypy to feast/core/Transformation_pb2.pyi
Writing mypy to feast/core/StreamFeatureView_pb2.pyi
Writing mypy to feast/core/FeatureView_pb2.pyi
Writing mypy to feast/core/InfraObject_pb2.pyi
Writing mypy to feast/core/Project_pb2.pyi
Writing mypy to feast/core/FeatureTable_pb2.pyi
Writing mypy to feast/core/Policy_pb2.pyi
Writing mypy to feast/core/DatastoreTable_pb2.pyi
Writing mypy to feast/core/OnDemandFeatureView_pb2.pyi
Writing mypy to feast/core/SqliteTable_pb2.pyi
Writing mypy to feast/core/SavedDataset_pb2.pyi
Writing mypy to feast/core/Entity_pb2.pyi
Writing mypy to feast/core/FeatureService_pb2.pyi
Writing mypy to feast/core/Feature_pb2.pyi
Writing mypy to feast/core/ValidationProfile_pb2.pyi
Writing mypy to feast/core/DataSource_pb2.pyi
Writing mypy to feast/core/Registry_pb2.pyi
Writing mypy to feast/core/FeatureViewProjection_pb2.pyi
Writing mypy to feast/core/Store_pb2.pyi
Writing mypy to feast/registry/RegistryServer_pb2.pyi
Writing mypy to feast/serving/ServingService_pb2.pyi
Writing mypy to feast/serving/GrpcServer_pb2.pyi
Writing mypy to feast/serving/Connector_pb2.pyi
Writing mypy to feast/serving/TransformationService_pb2.pyi
Writing mypy to feast/types/Field_pb2.pyi
Writing mypy to feast/types/Value_pb2.pyi
Writing mypy to feast/types/EntityKey_pb2.pyi
Writing mypy to feast/storage/Redis_pb2.pyi
unzip -u /home/shuchu/feast/tools/protoc-30.2-linux-x86_64.zip -d /home/shuchu/feast/tools
Archive:  /home/shuchu/feast/tools/protoc-30.2-linux-x86_64.zip
go install google.golang.org/protobuf/cmd/[email protected]
go install google.golang.org/grpc/cmd/[email protected]
mkdir -p /home/shuchu/feast/go/protos
protoc --proto_path=/home/shuchu/feast/protos --go_out=/home/shuchu/feast/go/protos --go_opt=module=github.com/feast-dev/feast/go/protos --go-grpc_out=/home/shuchu/feast/go/protos --go-grpc_opt=module=github.com/feast-dev/feast/go/protos /home/shuchu/feast/protos/feast/core/*.proto;   protoc --proto_path=/home/shuchu/feast/protos --go_out=/home/shuchu/feast/go/protos --go_opt=module=github.com/feast-dev/feast/go/protos --go-grpc_out=/home/shuchu/feast/go/protos --go-grpc_opt=module=github.com/feast-dev/feast/go/protos /home/shuchu/feast/protos/feast/registry/*.proto;   protoc --proto_path=/home/shuchu/feast/protos --go_out=/home/shuchu/feast/go/protos --go_opt=module=github.com/feast-dev/feast/go/protos --go-grpc_out=/home/shuchu/feast/go/protos --go-grpc_opt=module=github.com/feast-dev/feast/go/protos /home/shuchu/feast/protos/feast/serving/*.proto;   protoc --proto_path=/home/shuchu/feast/protos --go_out=/home/shuchu/feast/go/protos --go_opt=module=github.com/feast-dev/feast/go/protos --go-grpc_out=/home/shuchu/feast/go/protos --go-grpc_opt=module=github.com/feast-dev/feast/go/protos /home/shuchu/feast/protos/feast/types/*.proto;   protoc --proto_path=/home/shuchu/feast/protos --go_out=/home/shuchu/feast/go/protos --go_opt=module=github.com/feast-dev/feast/go/protos --go-grpc_out=/home/shuchu/feast/go/protos --go-grpc_opt=module=github.com/feast-dev/feast/go/protos /home/shuchu/feast/protos/feast/storage/*.proto;  true
go install golang.org/x/tools/cmd/goimports
uv pip install "pybindgen==0.22.1" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"
Audited 3 packages in 2ms
uv pip install -e "."
Resolved 65 packages in 2.02s
      Built feast @ file:///home/shuchu/feast
Prepared 1 package in 1.96s
Uninstalled 1 package in 0.64ms
Installed 1 package in 2ms
 ~ feast==0.53.1.dev15+g5ab18a6a2.d20250923 (from file:///home/shuchu/feast)
/home/shuchu/feast/tools/bin:/home/shuchu/feast/.venv/bin:/home/shuchu/.vscodium-server/bin/b18126fb99b60533fc069575d08d72758cd90fed/bin/remote-cli:/home/shuchu/.local/bin:/home/shuchu/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/usr/lib/wsl/lib:/mnt/c/WINDOWS/system32:/mnt/c/WINDOWS:/mnt/c/WINDOWS/System32/Wbem:/mnt/c/WINDOWS/System32/WindowsPowerShell/v1.0/:/mnt/c/WINDOWS/System32/OpenSSH/:/mnt/c/Program Files/NVIDIA Corporation/NVIDIA App/NvDLISR:/mnt/c/Program Files (x86)/NVIDIA Corporation/PhysX/Common:/mnt/c/Program Files/RedHat/Podman/:/mnt/c/Users/shuch/AppData/Local/Microsoft/WindowsApps:/mnt/c/Users/shuch/AppData/Local/Programs/VSCodium/bin
CGO_ENABLED=1 go test -coverprofile=coverage.out ./... && go tool cover -html=coverage.out -o coverage.html
ok      github.com/feast-dev/feast/go   0.023s  coverage: 3.8% of statements
        github.com/feast-dev/feast/go/embedded          coverage: 0.0% of statements
ok      github.com/feast-dev/feast/go/internal/feast    5.725s  coverage: 53.9% of statements
        github.com/feast-dev/feast/go/internal/feast/model              coverage: 0.0% of statements
ok      github.com/feast-dev/feast/go/internal/feast/onlineserving      0.030s  coverage: 49.1% of statements
ok      github.com/feast-dev/feast/go/internal/feast/onlinestore        16.426s coverage: 44.0% of statements
ok      github.com/feast-dev/feast/go/internal/feast/registry   0.030s  coverage: 28.7% of statements
ok      github.com/feast-dev/feast/go/internal/feast/server     17.069s coverage: 29.6% of statements
ok      github.com/feast-dev/feast/go/internal/feast/server/logging     0.141s  coverage: 62.3% of statements
        github.com/feast-dev/feast/go/internal/feast/transformation             coverage: 0.0% of statements
        github.com/feast-dev/feast/go/internal/test             coverage: 0.0% of statements
        github.com/feast-dev/feast/go/protos/feast/core         coverage: 0.0% of statements
        github.com/feast-dev/feast/go/protos/feast/registry             coverage: 0.0% of statements
        github.com/feast-dev/feast/go/protos/feast/serving              coverage: 0.0% of statements
        github.com/feast-dev/feast/go/protos/feast/storage              coverage: 0.0% of statements
        github.com/feast-dev/feast/go/protos/feast/types                coverage: 0.0% of statements
ok      github.com/feast-dev/feast/go/types     0.010s  coverage: 86.1% of statements

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shuchu
fix: Update the deprecated functions in Go feature server.
2212a99 
Signed-off-by: Shuchu Han <[email protected]>
@shuchu
shuchu requested a review from a team as a code owner September 25, 2025 02:27
@shuchu
shuchu requested review from franciscojavierarceo, haoxu0 and ntkathole September 25, 2025 02:27
@shuchu shuchu mentioned this pull request Sep 25, 2025
fix: Update the deprecated functions in Go feature server. #5627
Closed
@ntkathole ntkathole added the ok-to-test label Sep 25, 2025
ntkathole
ntkathole approved these changes Sep 26, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shuchu
shuchu merged commit a24e06e into feast-dev:master Sep 26, 2025
franciscojavierarceo pushed a commit that referenced this pull request Sep 30, 2025
@feast-ci-bot
chore(release): release 0.54.0
99a321a 
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes
@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo
@haoxu0 haoxu0 Awaiting requested review from haoxu0

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the deprecated imported library of Go feature server.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@shuchu @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.