GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Added codeflare-sdk to requirements by ntkathole · Pull Request #5640 · feast-dev/feast

Conversation

@ntkathole

@ntkathole ntkathole commented Sep 27, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR adds codeflare-sdk to requirements for managing ray. Codeflare-sdk requires python 3.11+ and kubernetes > 27.2.0.

Which issue(s) this PR fixes:

#5633

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ntkathole ntkathole self-assigned this Sep 27, 2025
@ntkathole
ntkathole requested a review from a team as a code owner September 27, 2025 14:56
@ntkathole ntkathole added the ok-to-test label Sep 27, 2025
@franciscojavierarceo

franciscojavierarceo commented Sep 27, 2025

Copy link
Copy Markdown
Member

I thought the codeflare SDK was being dropped
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole

ntkathole commented Sep 27, 2025

Copy link
Copy Markdown
Member Author

I thought the codeflare SDK was being dropped

It is due to be renamed, but it's not going away.
franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
franciscojavierarceo
franciscojavierarceo approved these changes Sep 27, 2025
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ntkathole
feat: Added codeflare-sdk to requirements
563833f 
Signed-off-by: ntkathole <[email protected]>
@franciscojavierarceo

franciscojavierarceo commented Sep 27, 2025

Copy link
Copy Markdown
Member

unit tests failing
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole
ntkathole force-pushed the codeflare-sdk branch from c7cad42 to 563833f Compare September 27, 2025 15:31
@haoxu0

haoxu0 commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator

Hey is this necessary dependency?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Sep 28, 2025

Copy link
Copy Markdown
Member

@ntkathole can we outline the benefits of having the codeflare SDK here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@haoxu0

haoxu0 commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

Or maybe create another dep like "Ray-clodeflakre"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole

ntkathole commented Sep 28, 2025

Copy link
Copy Markdown
Member Author

Hey is this necessary dependency?

Codeflare-sdk is required for handling authentication, certs and making connection to Kuberay. I am going to add support for this in upcoming PRs by adding codeflare wrapper above current implementation. This will be completely optional as a end user, User can use simply use ray address to connect to remote cluster as well, if ray cluster do not need authentication or tls certs.

can we outline the benefits of having the codeflare SDK here?

Codeflare-sdk allows us:

  • To find existing KubeRay cluster and connect without need to perform manual steps such as setting up tls certs configuration.
from codeflare_sdk import TokenAuthentication
from codeflare_sdk import generate_cert, get_cluster
  • User don't need to know cluster details, just name and namespace of Ray cluster.
  • Eliminates need to manually deploy and configure Ray clusters in Kubernetes.

I will add this in our documentation once implementation is done.

Or maybe create another dep like "Ray-clodeflakre"

We can do this, but it could be redundant. I am thinking anyhow codeflare-sdk will pull ray as it's dependency and usually ray needs same version for both server and client. If we did it like this, we don't need to maintain the ray version and let codeflare-sdk handle the compatibility.
franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Sep 28, 2025

Copy link
Copy Markdown
Member

That makes sense to me.

Please make sure to document the benefits on the usage to the users.

@HaoXuAI codeflare and the auth @ntkathole mentioned is how we recommend users securely use Ray clusters at Red Hat. See here: https://developers.redhat.com/articles/2025/07/24/submit-remote-rayjobs-ray-cluster-codeflare-sdk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@haoxu0

haoxu0 commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

That makes sense to me.

Please make sure to document the benefits on the usage to the users.

@HaoXuAI codeflare and the auth @ntkathole mentioned is how we recommend users securely use Ray clusters at Red Hat. See here: https://developers.redhat.com/articles/2025/07/24/submit-remote-rayjobs-ray-cluster-codeflare-sdk

I don't have double on the benefits. Just concerned that the codeflare is not available in our team's artifacts. Though we don't use Ray at the moment but possibly in the future
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@franciscojavierarceo

franciscojavierarceo commented Sep 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@HaoXuAI it's also open source so can be installed. It was a projected started by IBM I believe.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
franciscojavierarceo added 2 commits September 29, 2025 11:05
@franciscojavierarceo
Merge branch 'master' into codeflare-sdk
1645e2c
@franciscojavierarceo
Merge branch 'master' into codeflare-sdk
c75692a
@franciscojavierarceo
franciscojavierarceo merged commit 51a0ee6 into feast-dev:master Sep 30, 2025
franciscojavierarceo pushed a commit that referenced this pull request Sep 30, 2025
@feast-ci-bot
chore(release): release 0.54.0
99a321a 
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ntkathole @franciscojavierarceo @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.