GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Correct column list polars materialization engine by danbaron63 · Pull Request #5595 · feast-dev/feast

Conversation

danbaron63 commented Sep 3, 2025

Copy link

Copy Markdown

Contributor

What this PR does / why we need it:

Currently materialization fails when using the PolarsBackend as the columns method has no implementation. Worse still, rather than raising a NotImplementedError it fails silently by returning nothing which gets interpreted as None.

This provides a valid implementation that allows the feast materialize ... command to run successfully.

Which issue(s) this PR fixes:

N/a

Misc

N/a

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

danbaron63 requested a review from a team as a code owner

September 3, 2025 16:20

haoxu0 approved these changes

Sep 3, 2025

View reviewed changes

haoxu0 left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

haoxu0 commented Sep 3, 2025

Copy link

Copy Markdown

Collaborator

Thanks for contributing!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 added the ok-to-test label

Sep 3, 2025

haoxu0 commented Sep 3, 2025

Copy link

Copy Markdown

Collaborator

Need to fix the DCO

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole changed the title ~~Fix: correct column list polars materialization engine~~ Fix: Correct column list polars materialization engine

Sep 4, 2025

danbaron63 force-pushed the fix-correct-column-list-polars-materialization branch from 0b3da5d to 1c83d6e Compare

September 4, 2025 08:39

danbaron63 commented Sep 4, 2025

Copy link

Copy Markdown

Contributor Author

Need to fix the DCO

Apologies! Recommitted the last commit, should pass now 🤞

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbaron63 changed the title ~~Fix: Correct column list polars materialization engine~~ Correct column list polars materialization engine

Sep 4, 2025


          fix: returning the correct column list when requesting columnsin the …

f7e5f88

…PolarsBackend

Signed-off-by: Dan Baron <[email protected]>

danbaron63 force-pushed the fix-correct-column-list-polars-materialization branch from 1c83d6e to f7e5f88 Compare

September 4, 2025 08:44

danbaron63 changed the title ~~Correct column list polars materialization engine~~ fix: Correct column list polars materialization engine

Sep 4, 2025

danbaron63 commented Sep 4, 2025

Copy link

Copy Markdown

Contributor Author

@HaoXuAI any idea why the integration tests are failing for this change? I feel this should be a pretty trivial change 🤔 Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 commented Sep 5, 2025

Copy link

Copy Markdown

Collaborator

@HaoXuAI any idea why the integration tests are failing for this change? I feel this should be a pretty trivial change 🤔 Thanks!

seems to be a flaky test, rerunning now.

danbaron63 reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 merged commit 39aeb0c into feast-dev:master

Sep 5, 2025

haoxu0 commented Sep 5, 2025

Copy link

Copy Markdown

Collaborator

Thanks for your contributing!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 pushed a commit that referenced this pull request

Sep 9, 2025


          fix: Correct column list polars materialization engine (#5595)

9d3b366

fix: returning the correct column list when requesting columnsin the PolarsBackend

Signed-off-by: Dan Baron <[email protected]>
Signed-off-by: hao-xu5 <[email protected]>

franciscojavierarceo pushed a commit that referenced this pull request

Sep 30, 2025


          chore(release): release 0.54.0

99a321a

# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))

Reviewers

haoxu0

haoxu0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.