GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Improve trino to feast type mapping with (real,varchar,timestamp,decimal) by cutoutsy · Pull Request #5691 · feast-dev/feast

Conversation

@cutoutsy

@cutoutsy cutoutsy commented Oct 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Like trino_to_pa_value_type() function, improve trino_to_feast_value_type() function

  • Split decimal type into decimal32/decimal64 based on precision
  • Add support for real type mapping to ValueType.FLOAT
  • Add support for varchar(length) type
  • Add support for timestamp(p) type

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cutoutsy
cutoutsy requested a review from a team as a code owner October 24, 2025 10:28
@cutoutsy cutoutsy changed the title fix: improve trino to feast type mapping with (real,varchar,timestamp… fix: Improve trino to feast type mapping with (real,varchar,timestamp,decimal) Oct 24, 2025
@cutoutsy
cutoutsy force-pushed the fix/trino_to_feast_value_type branch from d6b2e65 to b62edeb Compare October 24, 2025 11:18
fengxiaochuan added 2 commits October 26, 2025 09:12
fengxiaochuan @ntkathole
fix: improve trino to feast type mapping with (real,varchar,timestamp…
7a1e8b8 
…,decimal)

Signed-off-by: fengxiaochuan <[email protected]>
fengxiaochuan @ntkathole
Remove whitespace from blank line
531a74c 
Signed-off-by: fengxiaochuan <[email protected]>
@ntkathole
ntkathole force-pushed the fix/trino_to_feast_value_type branch from b23f1dc to 531a74c Compare October 26, 2025 03:42
@ntkathole ntkathole added the ok-to-test label Oct 26, 2025
shuchu
shuchu reviewed Oct 27, 2025
View reviewed changes
Comment thread sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino_type_map.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
shuchu
shuchu approved these changes Oct 29, 2025
View reviewed changes

@shuchu shuchu left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@franciscojavierarceo
Merge branch 'master' into fix/trino_to_feast_value_type
a1bcd34
franciscojavierarceo
franciscojavierarceo approved these changes Oct 29, 2025
View reviewed changes
@franciscojavierarceo
Merge branch 'master' into fix/trino_to_feast_value_type
e4f1cd7
@franciscojavierarceo
franciscojavierarceo merged commit f855ad2 into feast-dev:master Oct 29, 2025
@cutoutsy
cutoutsy deleted the fix/trino_to_feast_value_type branch October 30, 2025 08:21
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuchu shuchu shuchu approved these changes
@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@cutoutsy @shuchu @franciscojavierarceo @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.