GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Materialize API - ODFV views not looked-up (thinks views non existant) - crashes materialize by astronautas · Pull Request #5716 · feast-dev/feast

Conversation

@astronautas

@astronautas astronautas commented Nov 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

On-demand feature views not checked when materialize is called via a web-endpoint /materialize. Which means, ODFV cannot be materialized via an endpoint - FeatureViewNotFoundException gets raised...

Solution: check get_on_demand_feature_view too!

On a bigger scale, this is caused by apparently 3 different implementations of checking whether a feature view exists - logging, server and feature_store (Python SDK). I wouldn't venture into refactoring yet, since we're quite busy, but at least this bugfix unblocks ODFV materialization (which we need a lot).

Also re-organized a bit - imho we should prioritize checking features, odfvs and then stream.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mantcep, ShumzZzZz, and franciscojavierarceo reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
astronautas and others added 5 commits October 15, 2025 19:55
@astronautas @ntkathole
add pull_all_from_table_or_query for clickhouse, to align with new ma…
1752a4f 
…terialization logic (calling it)

Signed-off-by: lukas.valatka <[email protected]>
Lukas Valatka
Merge branch 'feast-dev:master' into master
a6fcf5e
Lukas Valatka
Merge branch 'feast-dev:master' into master
c7cf0da
@astronautas
Merge branch 'feast-dev:master' into master
15abe18
@astronautas
Merge branch 'master' of github.com:astronautas/feast
b4a2aa5
@astronautas
astronautas requested a review from a team as a code owner November 11, 2025 15:12
@astronautas
astronautas force-pushed the fix/odfv-not-found-materialize branch from f2151eb to e637eac Compare November 11, 2025 15:15
@astronautas

astronautas commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo
miroslawas reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@astronautas
astronautas force-pushed the fix/odfv-not-found-materialize branch from ff62a9d to f9e0de0 Compare November 11, 2025 15:27
@astronautas astronautas changed the title fix: ODFV views in registry not lookuped on server-materialize, crashes fix: Materialize API - ODFV views not looked-up - crashes materialize Nov 11, 2025
@astronautas astronautas changed the title fix: Materialize API - ODFV views not looked-up - crashes materialize fix: Materialize API - ODFV views not looked-up (all views non existant) - crashes materialize Nov 11, 2025
@astronautas astronautas changed the title fix: Materialize API - ODFV views not looked-up (all views non existant) - crashes materialize fix: Materialize API - ODFV views not looked-up (thinks views non existant) - crashes materialize Nov 11, 2025
@astronautas
fix - ensure on demand feature views can be checked too
460ecdd 
Signed-off-by: lukas.valatka <[email protected]>
@astronautas
astronautas force-pushed the fix/odfv-not-found-materialize branch from 60b1e33 to 460ecdd Compare November 11, 2025 15:35
haoxu0
haoxu0 approved these changes Nov 12, 2025
View reviewed changes

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
astronautas reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@haoxu0 haoxu0 added the ok-to-test label Nov 12, 2025
@haoxu0 haoxu0 mentioned this pull request Nov 12, 2025
Make OnDemandFeatureView work for having both aggregations and transformations #5689
Open
@haoxu0
haoxu0 merged commit 1b050b3 into feast-dev:master Nov 12, 2025
22 checks passed

Uh oh!

There was an error while loading. Please reload this page.
haoxu0 pushed a commit that referenced this pull request Nov 12, 2025
@astronautas Lukas Valatka @haoxu0
fix: Materialize API - ODFV views not looked-up (thinks views non exi…
511073d 
…stant) - crashes materialize (#5716)

* add pull_all_from_table_or_query for clickhouse, to align with new materialization logic (calling it)

Signed-off-by: lukas.valatka <[email protected]>

* fix - ensure on demand feature views can be checked too

Signed-off-by: lukas.valatka <[email protected]>

---------

Signed-off-by: lukas.valatka <[email protected]>
Co-authored-by: Lukas Valatka <[email protected]>
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
@franciscojavierarceo franciscojavierarceo mentioned this pull request Nov 28, 2025
feat: Unify Feature Transformations and Feature Views #5747
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haoxu0 haoxu0 haoxu0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@astronautas @haoxu0
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.