GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add annotations to cronjob CRDs by FredericKayser · Pull Request #5701 · feast-dev/feast

Conversation

@FredericKayser

@FredericKayser FredericKayser commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR adds support for custom annotations on the CronJob resource in the FeatureStore CRD. This enhancement allows users to specify Kubernetes annotations for CronJobs deployed by the Feast operator, which is useful for:

  • Integration with monitoring and observability tools
  • Policy enforcement and compliance tooling
  • Service mesh configuration
  • Custom operator integrations that use annotations for configuration

The annotations field has been added to both the spec and status sections of the CronJob definition in the FeatureStore CRD.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FredericKayser
FredericKayser requested a review from a team as a code owner October 28, 2025 16:35
@FredericKayser
FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from cc7c177 to 4b53c5f Compare October 28, 2025 16:35
@franciscojavierarceo
franciscojavierarceo requested a review from Copilot October 28, 2025 17:27
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for custom annotations on CronJob metadata in the Feast operator's FeatureStore CRD. The change allows users to specify additional Kubernetes annotations that will be applied to CronJob resources created by the operator.

Key Changes:

  • Added annotations field to the FeastCronJob schema definition in the CRD

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FredericKayser
FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from 399d62c to 01a8854 Compare October 28, 2025 19:40
@FredericKayser
FredericKayser marked this pull request as draft October 28, 2025 19:47
@FredericKayser
FredericKayser marked this pull request as ready for review October 28, 2025 19:50
@FredericKayser
FredericKayser requested a review from Copilot October 28, 2025 19:51
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread infra/feast-operator/internal/controller/services/cronjob.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@FredericKayser
FredericKayser requested a review from Copilot October 28, 2025 19:59
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread infra/feast-operator/internal/controller/services/cronjob.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@FredericKayser
FredericKayser requested a review from Copilot October 28, 2025 20:09
Copilot AI reviewed Oct 28, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FredericKayser
FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from e01a3fb to be90322 Compare October 29, 2025 13:45
FredericKayser added 5 commits October 29, 2025 14:47
@FredericKayser
feat: Add annotations to cronjob CRDs
4d18e38 
Signed-off-by: Frederic Kayser <[email protected]>
@FredericKayser
Implement handling of annotations
6032da7 
Signed-off-by: Frederic Kayser <[email protected]>
@FredericKayser
Add auto-generated files
7ca033a 
Signed-off-by: Frederic Kayser <[email protected]>
@FredericKayser
Implement changes from review
f960b54 
Signed-off-by: Frederic Kayser <[email protected]>
@FredericKayser
Implement changes from review
432aab3 
Signed-off-by: Frederic Kayser <[email protected]>
@FredericKayser
FredericKayser force-pushed the feat/add-annotations-to-cronjob-crds branch from be90322 to 432aab3 Compare October 29, 2025 13:47
@franciscojavierarceo
Merge branch 'master' into feat/add-annotations-to-cronjob-crds
c2b4e92
@FredericKayser

FredericKayser commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo do you have any idea why the CI fails now? The failure doesn't really seem to be related to my changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole ntkathole added the ok-to-test label Oct 29, 2025
@franciscojavierarceo
franciscojavierarceo merged commit be6e6c2 into feast-dev:master Oct 29, 2025
2 checks passed

Uh oh!

There was an error while loading. Please reload this page.
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@FredericKayser @franciscojavierarceo @ntkathole
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.