GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Support historical feature retrieval with start_date/end_date in RemoteOfflineStore by aniketpalu · Pull Request #5703 · feast-dev/feast

Conversation

@aniketpalu

@aniketpalu aniketpalu commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Problem

  • get_historical_features() with start_date/end_date parameters (no entity_df) works in local mode but fails in remote mode with:
    • EntityTimestampInferenceException: Please provide an entity_df with a column named event_timestamp

Root Cause

  • Remote client sends mock table {"key": "mock_key"} when entity_df is None
  • Server treats mock table as valid entity_df, which lacks event_timestamp column
  • Server doesn't forward start_date/end_date to underlying offline store

Changes

  • Client (remote.py):
    • Handle None entity_df in _create_retrieval_metadata() and _get_entity_schema()
  • Server (offline_server.py):
    • Detect and discard mock tables (single 'key' column)
    • Create minimal entity_df with event_timestamp from start_date/end_date
    • Forward start_date/end_date kwargs to underlying offline store
    • Use pd.to_datetime() and utils.make_tzaware() for proper timestamp types

Which issue(s) this PR fixes:

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aniketpalu added 3 commits October 23, 2025 12:52
@aniketpalu @ntkathole
Added start_date & end_date range for historical data retrieval from …
b8a8ab6 
…RemoteOfflineStore

Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu @ntkathole
Minor linting & reformatting changes
d6bb773 
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
Fixed minor issue of empty df with only key as column being trated as…
0e17fdf 
… entity_df in offline server

Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
aniketpalu requested a review from a team as a code owner October 29, 2025 05:45
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Oct 29, 2025
ntkathole
ntkathole approved these changes Oct 30, 2025
View reviewed changes

@ntkathole ntkathole left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @aniketpalu can you please rebase to resolve conflicts ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aniketpalu
Merge branch 'master' into RHOAIENG-32904
434ab75
jyejare
jyejare requested changes Nov 2, 2025
View reviewed changes

@jyejare jyejare left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle empty entity_df in offline server.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aniketpalu reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread sdk/python/feast/offline_server.py Outdated
datetime.fromisoformat(command["start_date"])
)
end_date = utils.make_tzaware(datetime.fromisoformat(command["end_date"]))
entity_df = pd.DataFrame(

@jyejare jyejare Nov 2, 2025

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need to create dummy entity_df at all. We should handle empty(entity_df=None) entity_df for and in offline_store.get_historical_features which we are returning in this function.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@aniketpalu aniketpalu Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, its not needed to create mock dataframe with timestamps, just had to make sure that empty_df is being passed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aniketpalu added 2 commits November 3, 2025 12:47
@aniketpalu
Removed unnecessary logic to create mock df
0d52d17 
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
Minor linting & formatting changes
4bf7de7 
Signed-off-by: Aniket Paluskar <[email protected]>
@aniketpalu
aniketpalu requested a review from jyejare November 3, 2025 11:11
jyejare
jyejare approved these changes Nov 3, 2025
View reviewed changes
@ntkathole
ntkathole merged commit ad32756 into feast-dev:master Nov 3, 2025
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyejare jyejare jyejare approved these changes
@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aniketpalu @jyejare @ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.