GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add batch commit mode for MySQL OnlineStore by chimeyrock999 · Pull Request #5699 · feast-dev/feast

Conversation

@chimeyrock999

@chimeyrock999 chimeyrock999 commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds optional batch insert and commit mode to the MySQLOnlineStore to improve materialization performance for TiDB and MySQL backends.
By default, Feast writes each row individually and commits per record, which causes large overhead on MySQL compatible Raft-based databases like TiDB.
This PR introduces a configurable batch mode to group inserts and commit per batch, improving write throughput.

Changes

  • Added config flags: 
    batch_mode: true
batch_size: 1000
  • Implemented batched insert using executemany() / multi-row SQL.
  • Each batch is committed atomically.
  • Backward compatible (default = per-row mode).

Misc

  • Verified on TiDB v7.5.0 and MySQL 8.0.44.
  • Thanks @ntkathole confirming this direction.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chimeyrock999
chimeyrock999 requested a review from a team as a code owner October 28, 2025 04:59
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Oct 28, 2025
@chimeyrock999 @ntkathole
feat: Support batch_write for MySQL OnlineStore
b5e58bf 
Signed-off-by: Chimey Rock <[email protected]>

docs: update document for MySQL Online Store to support batch write

Signed-off-by: Chimey Rock <[email protected]>
@ntkathole
ntkathole force-pushed the master branch from be629d6 to b5e58bf Compare October 29, 2025 16:57
@chimeyrock999
Merge branch 'master' into master
b4f6c2f
@ntkathole

ntkathole commented Oct 30, 2025

Copy link
Copy Markdown
Member

@chimeyrock999 Thank you! Can we also please mention this support in our docs ? may be at https://github.com/feast-dev/feast/blob/master/docs/reference/online-stores/mysql.md
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chimeyrock999
docs: Add batch_write for MySQL Online Store
20a4d19 
Signed-off-by: Chimey Rock <[email protected]>
@chimeyrock999

chimeyrock999 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

@ntkathole Thank you for the feedback! I’ve added documentation to cover this support of MySQL Online Store.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ntkathole
ntkathole merged commit 3cfe4eb into feast-dev:master Oct 31, 2025
2 checks passed

Uh oh!

There was an error while loading. Please reload this page.
ntkathole
ntkathole approved these changes Oct 31, 2025
View reviewed changes
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0
cc39768 
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
@karthikchundi-commits karthikchundi-commits mentioned this pull request Sep 1, 2026
fix: Repair MySQL online store batch_write path #6802
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntkathole ntkathole ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chimeyrock999 @ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.