GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Thread safe Clickhouse offline store by astronautas · Pull Request #5710 · feast-dev/feast

Conversation

@astronautas

@astronautas astronautas commented Nov 4, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

PR adjusts the Clickhouse offline store to be thread safe. Issue with the current implementation results in the issue as follows:

raise ProgrammingError('Attempt to execute concurrent queries within the same session.'

if you bombard it - feast serve - with concurrent requests, the under the hood threadpool is more than 1 thread by default (arbitrary number decided by uvicorn).

as per Clickhouse docs here:

Because each query or insert executed maintains state in its own QueryContext or InsertContext object, respectively, these helper objects are not thread-safe, and they should not be shared between multiple processing streams.

Solution - using threading.local() we can initialize a per-thread container for variables, to make sure we re-use the client on subsequent calls. Can we just drop the caching? Not really, unless the store is heavily refactored.

Which issue(s) this PR fixes:

No issue raised yet.

Misc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mantcep and franciscojavierarceo reacted with hooray emoji
All reactions
  • 🎉 2 reactions
astronautas and others added 4 commits October 15, 2025 19:55
@astronautas @ntkathole
add pull_all_from_table_or_query for clickhouse, to align with new ma…
1752a4f
…terialization logic (calling it)

Signed-off-by: lukas.valatka <[email protected]>
Lukas Valatka
Merge branch 'feast-dev:master' into master
a6fcf5e
Lukas Valatka
Merge branch 'feast-dev:master' into master
c7cf0da
@astronautas
make sure get client is thread-local, since client is thread-unsafe
7c76869
Signed-off-by: lukas.valatka <[email protected]>
@astronautas
astronautas requested a review from a team as a code owner November 4, 2025 15:25
@astronautas
cleanup
50ad3d1
Signed-off-by: lukas.valatka <[email protected]>
@franciscojavierarceo franciscojavierarceo added the ok-to-test label Nov 4, 2025
franciscojavierarceo
franciscojavierarceo approved these changes Nov 4, 2025
View reviewed changes

@franciscojavierarceo franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@franciscojavierarceo
franciscojavierarceo merged commit 5f446ed into feast-dev:master Nov 4, 2025
22 checks passed

Uh oh!

There was an error while loading. Please reload this page.

haoxu0 pushed a commit that referenced this pull request Nov 12, 2025
Lukas Valatka @astronautas @haoxu0
fix: Thread safe Clickhouse offline store (#5710)
5a5ccde
* add pull_all_from_table_or_query for clickhouse, to align with new materialization logic (calling it)

Signed-off-by: lukas.valatka <[email protected]>

* make sure get client is thread-local, since client is thread-unsafe

Signed-off-by: lukas.valatka <[email protected]>

* cleanup

Signed-off-by: lukas.valatka <[email protected]>

---------

Signed-off-by: lukas.valatka <[email protected]>
Co-authored-by: lukas.valatka <[email protected]>
franciscojavierarceo pushed a commit that referenced this pull request Nov 13, 2025
@feast-ci-bot
chore(release): release 0.57.0
cc39768
# [0.57.0](v0.56.0...v0.57.0) (2025-11-13)

### Bug Fixes

* Improve trino to feast type mapping with (real,varchar,timestamp,decimal) ([#5691](#5691)) ([f855ad2](f855ad2))
* Materialize API - ODFV views not looked-up (thinks views non existant)  - crashes materialize ([#5716](#5716)) ([1b050b3](1b050b3))
* Support historical feature retrieval with start_date/end_date in RemoteOfflineStore ([#5703](#5703)) ([ad32756](ad32756))
* Thread safe Clickhouse offline store ([#5710](#5710)) ([5f446ed](5f446ed))

### Features

* Add annotations to cronjob CRDs ([#5701](#5701)) ([be6e6c2](be6e6c2))
* Add batch commit mode for MySQL OnlineStore ([#5699](#5699)) ([3cfe4eb](3cfe4eb))
* Add possibility to materialize only latest values, to increase performance ([#5713](#5713)) ([8d77b72](8d77b72))
* Support table format: Iceberg, Delta, and Hudi ([#5650](#5650)) ([2915ad1](2915ad1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@astronautas @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.