GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Add TLS support for Go Feature Server by shuchu · Pull Request #6229 · feast-dev/feast

Conversation

@shuchu

@shuchu shuchu commented Apr 5, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Add TLS support for users who have enterprise security requirement

Which issue(s) this PR fixes:

Fix #6095

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Misc


Open with Devin

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@shuchu
shuchu requested a review from a team as a code owner April 5, 2026 23:59
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shuchu
shuchu marked this pull request as draft April 6, 2026 00:36
@shuchu
shuchu force-pushed the feat/issue-6095 branch from d1b5c80 to 7be254d Compare April 10, 2026 03:44
@shuchu shuchu changed the title Add TLS support for Go Feature Server feat: Add TLS support for Go Feature Server Apr 10, 2026
@shuchu
shuchu marked this pull request as ready for review April 10, 2026 03:46
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shuchu
shuchu requested review from franciscojavierarceo, haoxu0 and ntkathole April 11, 2026 00:55
@ntkathole ntkathole added the ok-to-test label Apr 11, 2026
ntkathole
ntkathole reviewed Apr 11, 2026
View reviewed changes
Comment thread go/internal/feast/server/http_server.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ntkathole

ntkathole commented Apr 11, 2026

Copy link
Copy Markdown
Member

@shuchu optional nitpick - I see duplication of code in http vs https in start and serve methods

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shuchu

shuchu commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator Author

@shuchu optional nitpick - I see duplication of code in http vs https in start and serve methods

yes, you are right. let me put those two functions into one.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shuchu
shuchu force-pushed the feat/issue-6095 branch from 5e78183 to 10b7b37 Compare April 12, 2026 03:06
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shuchu
shuchu force-pushed the feat/issue-6095 branch from 10b7b37 to ce2de93 Compare April 13, 2026 01:08
@shuchu
shuchu requested a review from ntkathole April 14, 2026 01:15
shuchu added 10 commits April 13, 2026 22:44
@shuchu SHUCHU HAN
feat: Add HTTPs server support.
7dce12f
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
feat: Add serverTSL() method.
064f612
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: Lint the Go code.
5d64fcb
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
feat: Add TLS configuration.
ed19573
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: Add unit tests for HTTPS server.
2ca0bba
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: Format code. Fixed bad comments.
531042a
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: Fix unit test error.
d87d895
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: use single StartHttpServer to cover HTTP and HTTPs cases.
c6f5d69
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: Change back the pyproject.toml file.
f3d93c5
Signed-off-by: Shuchu Han <[email protected]>
@shuchu SHUCHU HAN
fix: Fix name convertion of https_enable.
03d7156
Signed-off-by: Shuchu Han <[email protected]>
@shuchu
shuchu force-pushed the feat/issue-6095 branch from ce2de93 to 03d7156 Compare April 14, 2026 02:46
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Apr 14, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 13 additional findings in Devin Review.

Open in Devin Review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread go/main_test.go

@devin-ai-integration devin-ai-integration Bot Apr 14, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MockServerStarter missing StartHttpsServer method required by ServerStarter interface

The ServerStarter interface at go/main.go:51 now includes StartHttpsServer, but MockServerStarter in go/main_test.go:29 does not implement this method. The comment on line 28 explicitly states it is a mock of ServerStarter interface for testing, yet it no longer satisfies that interface. Any test that attempts to use MockServerStarter as a ServerStarter will fail to compile.

(Refers to lines 29-41)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
franciscojavierarceo
franciscojavierarceo approved these changes Apr 14, 2026
View reviewed changes
@franciscojavierarceo
franciscojavierarceo merged commit 28a58d0 into feast-dev:master Apr 14, 2026
26 of 27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo pushed a commit that referenced this pull request May 4, 2026
@feast-ci-bot
chore(release): release 0.63.0
50ad181
# [0.63.0](v0.62.0...v0.63.0) (2026-05-04)

### Bug Fixes

* Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4))
* Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208)
* Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556))
* Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984))
* Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03))
* **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200)
* correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7))
* disable Redis RDB persistence in test deployments ([44cd682](44cd682))
* Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98))
* Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9))
* Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b))
* Fix issue with apply feature view ([835cda8](835cda8))
* Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d))
* Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a))
* Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356))
* **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a))
* Include git in feast server image ([fb03c46](fb03c46))
* Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c))
* Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77))
* Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd))
* Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43))
* Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e))
* **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf))
* **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d))
* Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e))
* support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889))
* Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55))

### Features

* Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3))
* Add feature view versioning support to FAISS online store ([b36acb7](b36acb7))
* Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163)
* Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105))
* Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157))
* Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0))
* Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738))
* Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced))
* Addresses performance issues in the Redis online store ([2e50da0](2e50da0))
* Allow to set gpu for ray ([5580ab4](5580ab4))
* Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180))
* Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd))
* Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf))
* Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056))
* MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7))
* Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8))
* Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8))
* **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes
@haoxu0 haoxu0 Awaiting requested review from haoxu0
@ntkathole ntkathole Awaiting requested review from ntkathole

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TLS configuration support to Go feature server

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shuchu @ntkathole @franciscojavierarceo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.