GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat: Make udf optional if agg defined (#5689) by nquinn408 · Pull Request #6328 · feast-dev/feast

Conversation

nquinn408 commented Apr 24, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nquinn408 self-assigned this

Apr 24, 2026

nquinn408 requested a review from a team as a code owner

April 24, 2026 20:10

This comment was marked as resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          feat: Make udf optional if agg defined (feast-dev#5689)

8c8d87d

Signed-off-by: Nick Quinn <[email protected]>

nquinn408 force-pushed the optional-udf-if-agg branch from 16ebe3a to 0524b4d Compare

April 24, 2026 21:11


          fix: sort Aggregation import in test_on_demand_feature_view.py

f64c1cb

Fixes ruff I001 import ordering violation introduced with the
aggregations-without-udf test.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Signed-off-by: Nick Quinn <[email protected]>

nquinn408 force-pushed the optional-udf-if-agg branch from 0524b4d to f64c1cb Compare

April 24, 2026 21:11

nickquinn408 and others added 4 commits

April 24, 2026 14:13


          fix: skip backward-compat UDF fallback for aggregation-only ODFVs

be9a625

_parse_transformation_from_proto fell through to _handle_backward_compatible_udf
when feature_transformation was absent, crashing on dill.loads(b"") for ODFVs
that have no transformation but do have aggregations.

Return None early when transformation_type is None and proto.spec.aggregations
is non-empty.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Signed-off-by: Nick Quinn <[email protected]>


          fix: skip transformation inference for aggregation-only ODFVs

9fcf772

infer_features() unconditionally asserted feature_transformation is not
None, crashing during apply() for aggregation-only ODFVs. Add an early
return when aggregations are present and feature_transformation is None;
features are explicitly declared via schema so inference via transformation
execution is not needed.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Signed-off-by: Nick Quinn <[email protected]>


          test: add input_schema + aggregation + no-udf ODFV round-trip test

fe285e0

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Signed-off-by: Nick Quinn <[email protected]>


          fix: resolve mypy errors in field.py, entity.py, and remote.py

c7838e6

- Redirect feast.types.Value_pb2 stub imports to
  feast.protos.feast.types.Value_pb2 where typed .pyi stubs live
- Add # type: ignore[arg-type] where .value (int) is passed to a
  proto field typed as NewType("ValueType", int)
- Add # type: ignore[arg-type] for getattr call with Optional[str]
  from WhichOneof in remote.py

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Signed-off-by: Nick Quinn <[email protected]>

nquinn408 force-pushed the optional-udf-if-agg branch from bb086b5 to c7838e6 Compare

April 24, 2026 23:55

haoxu0 approved these changes

Apr 25, 2026

View reviewed changes

haoxu0 left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ntkathole added the ok-to-test label

Apr 25, 2026

ntkathole reviewed

Apr 25, 2026

View reviewed changes

Comment thread

sdk/python/feast/on_demand_feature_view.py

		def _validate_transformation_config(self) -> None:
		"""Validate transformation configuration."""
		# Aggregations provide their own transformation; no udf/feature_transformation required.
		if self.aggregations:

ntkathole Apr 25, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	if self.aggregations:
	if self.aggregations and not self.feature_transformation:

to avoid skipping mode validation when both aggregations and a transformation are provided

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ntkathole Apr 25, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, optionally may be good to have check

if self.aggregations and self.feature_transformation:
        raise ValueError(
            "Combining aggregations with a udf/feature_transformation is not yet supported. 
        )

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ntkathole commented Apr 25, 2026

Copy link

Copy Markdown

Member

also, docstring change for aggregation or docs addition for the change - https://github.com/feast-dev/feast/blob/master/sdk/python/feast/on_demand_feature_view.py#L211

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nquinn408 merged commit f630056 into feast-dev:master

Apr 25, 2026

43 of 47 checks passed

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo pushed a commit that referenced this pull request

May 4, 2026


          chore(release): release 0.63.0

50ad181

# [0.63.0](v0.62.0...v0.63.0) (2026-05-04)

### Bug Fixes

* Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4))
* Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208)
* Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556))
* Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984))
* Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03))
* **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200)
* correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7))
* disable Redis RDB persistence in test deployments ([44cd682](44cd682))
* Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98))
* Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9))
* Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b))
* Fix issue with apply feature view ([835cda8](835cda8))
* Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d))
* Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a))
* Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356))
* **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a))
* Include git in feast server image ([fb03c46](fb03c46))
* Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c))
* Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77))
* Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd))
* Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43))
* Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e))
* **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf))
* **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d))
* Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e))
* support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889))
* Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55))

### Features

* Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3))
* Add feature view versioning support to FAISS online store ([b36acb7](b36acb7))
* Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163)
* Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105))
* Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157))
* Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0))
* Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738))
* Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced))
* Addresses performance issues in the Redis online store ([2e50da0](2e50da0))
* Allow to set gpu for ray ([5580ab4](5580ab4))
* Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180))
* Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd))
* Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf))
* Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056))
* MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7))
* Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8))
* Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8))
* **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))

Reviewers

ntkathole

ntkathole left review comments

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

haoxu0

haoxu0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

nquinn408

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

nquinn408 commented Apr 24, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

haoxu0 left a comment

Choose a reason for hiding this comment

Uh oh!

ntkathole Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

ntkathole Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

ntkathole commented Apr 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nquinn408 commented Apr 24, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.