GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Add project_id filter to SnowflakeRegistry UPDATE path by Abhishek8108 · Pull Request #6243 · feast-dev/feast

Conversation

Abhishek8108 commented Apr 8, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Summary

Fixes #6208.

SnowflakeRegistry._apply_object had a missing project_id clause in the UPDATE branch's WHERE condition. In a shared Snowflake registry, this allowed a feast apply in one project to silently overwrite a same-named object belonging to a different project.

Root cause: The helper has two SQL branches:

SELECT (existence check) — correctly scoped: WHERE project_id = '{project}' AND {id_field} = '{name}'
UPDATE (overwrite) — was missing project_id: WHERE {id_field} = '{name}'

The fix brings the UPDATE path in line with the SELECT and DELETE paths, which already scoped by project_id correctly.

Impact: Affects all resource types routed through _apply_object — entities, data sources, feature views, feature services, saved datasets, validation references, permissions, and infrastructure objects.

Changes

sdk/python/feast/infra/registry/snowflake.py — add project_id = '{project}' AND to the UPDATE WHERE clause (one line)
sdk/python/tests/unit/infra/registry/test_snowflake_registry.py — new regression test; mocks the Snowflake connection, drives _apply_object into the UPDATE path, and asserts project_id appears in the WHERE clause

Test plan

New regression test passes: pytest sdk/python/tests/unit/infra/registry/test_snowflake_registry.py -v
All existing registry unit tests pass: pytest sdk/python/tests/unit/infra/registry/ -v
Manually verified UPDATE query now reads: WHERE project_id = '{project}' AND {id_field} = '{name}'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Abhishek8108 requested a review from a team as a code owner

April 8, 2026 19:27

devin-ai-integration Bot reviewed

Apr 8, 2026

View reviewed changes

devin-ai-integration Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Abhishek8108 force-pushed the fix/snowflake-registry-update-project-id-filter branch from d1458cf to 7a9cf1f Compare

April 8, 2026 19:30

Abhishek8108 mentioned this pull request

Apr 8, 2026

fix: Correct project_id scoping in get_user_metadata and delete_project #6248

Merged

ntkathole force-pushed the fix/snowflake-registry-update-project-id-filter branch from 7a9cf1f to 13f6fc0 Compare

April 10, 2026 06:33

ntkathole changed the title ~~fix: add project_id filter to SnowflakeRegistry UPDATE path~~ fix: Add project_id filter to SnowflakeRegistry UPDATE path

Apr 10, 2026

ntkathole commented Apr 10, 2026

Copy link

Copy Markdown

Member

@Abhishek8108 please fix linting and if possible, consider adding test case for a cross-project isolation scenario.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole force-pushed the fix/snowflake-registry-update-project-id-filter branch from 51d24e1 to 97265a5 Compare

April 11, 2026 15:05

ntkathole added the ok-to-test label

Apr 11, 2026

ntkathole reviewed

Apr 11, 2026

View reviewed changes

Comment thread

sdk/python/tests/unit/infra/registry/test_snowflake_registry.py Outdated

		schema="PUBLIC",
		account="test_account",
		user="test_user",
		password="test_password",

ntkathole Apr 11, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	password="test_password",
	password="test_password", #pragma: allowlist secret

to fix the ci

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Abhishek8108 commented Apr 11, 2026

Copy link

Copy Markdown

Contributor Author

The unit-test-python (3.12, ubuntu-latest) failure is test_e2e_local timing out in a feast teardown subprocess — unrelated to the Snowflake registry changes here. The same test passes on Python 3.12 in the latest master CI runs. Looks like a flaky e2e test from CI resource contention.

Just pushed a fix for the detect-secrets lint failure (password="test_password" in the test fixture was flagged as a potential secret — added # pragma: allowlist secret).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole approved these changes

Apr 11, 2026

View reviewed changes

Abhishek8108 added 3 commits

April 11, 2026 22:43


          fix: add project_id filter to SnowflakeRegistry UPDATE path

bb4eca0

_apply_object had a missing project_id clause in the UPDATE branch's
WHERE condition. In a shared Snowflake registry, this allowed a
feast apply in one project to silently overwrite a same-named object
belonging to a different project.

The SELECT path already scoped correctly by project_id. The DELETE
path (_delete_object) also scoped correctly. This commit brings the
UPDATE path in line with both.

Fixes feast-dev#6208

Signed-off-by: Abhishek8108 <[email protected]>


          test: fix lint and add cross-project isolation test for SnowflakeRegi…

3b67c4e

…stry UPDATE

- Reformat with-statement blocks to parenthesized form (ruff format)
- Add test_apply_object_does_not_overwrite_sibling_project: simulates two
  projects sharing a registry, applies an object to project_b, and asserts
  the UPDATE WHERE clause is scoped to project_b and does not reference
  project_a — direct regression coverage for feast-dev#6208

Signed-off-by: Abhishek8108 <[email protected]>


          test: suppress detect-secrets false positive on test_password fixture

2d7913a

Signed-off-by: Abhishek8108 <[email protected]>

ntkathole force-pushed the fix/snowflake-registry-update-project-id-filter branch from 917148a to 2d7913a Compare

April 11, 2026 17:13

ntkathole merged commit 6658b71 into feast-dev:master

Apr 11, 2026

22 of 26 checks passed

Uh oh!

There was an error while loading. Please reload this page.

franciscojavierarceo pushed a commit that referenced this pull request

May 4, 2026


          chore(release): release 0.63.0

50ad181

# [0.63.0](v0.62.0...v0.63.0) (2026-05-04)

### Bug Fixes

* Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4))
* Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208)
* Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556))
* Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984))
* Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03))
* **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200)
* correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7))
* disable Redis RDB persistence in test deployments ([44cd682](44cd682))
* Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98))
* Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9))
* Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b))
* Fix issue with apply feature view ([835cda8](835cda8))
* Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d))
* Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a))
* Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356))
* **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a))
* Include git in feast server image ([fb03c46](fb03c46))
* Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c))
* Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77))
* Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd))
* Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43))
* Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e))
* **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf))
* **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d))
* Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e))
* support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889))
* Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55))

### Features

* Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3))
* Add feature view versioning support to FAISS online store ([b36acb7](b36acb7))
* Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163)
* Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105))
* Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157))
* Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0))
* Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738))
* Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced))
* Addresses performance issues in the Redis online store ([2e50da0](2e50da0))
* Allow to set gpu for ray ([5580ab4](5580ab4))
* Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180))
* Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd))
* Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf))
* Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056))
* MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7))
* Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8))
* Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8))
* **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))

Reviewers

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

ntkathole

ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SnowflakeRegistry._apply_object UPDATE path missing project_id filter - cross-project overwrites

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Abhishek8108 commented Apr 8, 2026 • edited by devin-ai-integration Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test plan

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

ntkathole commented Apr 10, 2026

Uh oh!

ntkathole Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Abhishek8108 commented Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Abhishek8108 commented Apr 8, 2026 •

edited by devin-ai-integration Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.