GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling by jials · Pull Request #6315 · feast-dev/feast

Conversation

jials commented Apr 22, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

What this PR does / why we need it:

Fix init ordering and infinite recursion in SnowflakeRegistry caused by premature attribute access during __init__
Fix column casing bugs where Snowflake's uppercase column names broke metadata sync
Fix set type hints — use set() instead of [] for set-typed variables in _sync_feast_metadata_to_projects_table
Remove leftover private key kwargs (private_key, private_key_path, private_key_passphrase) before passing to snowflake.connector.connect, preventing unexpected keyword argument errors
Resolve mypy type errors in SnowflakeRegistry cache methods
Correct project_id scoping in get_user_metadata and delete_project
Add snowflake_registry fixture to integration registry tests
Add comprehensive unit tests for SnowflakeRegistry with xdist_group isolation
Add snowflake_registry to CI filter and exclude from non-Snowflake test targets

Which issue(s) this PR fixes:

Fixes #5204

Checks

I've made sure the tests are passing.
My commits are signed off (git commit -s)
My PR title follows conventional commits format

Testing Strategy

Unit tests
Integration tests
Manual tests
Testing is not required for this change

Misc

Key files changed:

sdk/python/feast/infra/registry/snowflake.py — core bug fixes
sdk/python/feast/infra/utils/snowflake/snowflake_utils.py — private key kwarg cleanup
sdk/python/tests/unit/infra/registry/test_snowflake_registry.py — new unit test suite
sdk/python/tests/integration/registration/test_universal_registry.py — integration fixture
Makefile / .github/workflows/ — CI configuration for snowflake registry tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jials requested a review from a team as a code owner

April 22, 2026 02:03

This comment was marked as resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jials marked this pull request as draft

April 22, 2026 02:12

jials marked this pull request as ready for review

April 22, 2026 07:15

ntkathole added the ok-to-test label

Apr 22, 2026

jials force-pushed the fix/snowflake-registry-bugs branch 2 times, most recently from 1ac60f9 to e0b1803 Compare

April 26, 2026 13:58

jials commented Apr 27, 2026

Copy link

Copy Markdown

Contributor Author

The UT failures are caused by flaky tests. Can we retry the failed jobs please? Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jials force-pushed the fix/snowflake-registry-bugs branch from 0be5cd6 to 0aec995 Compare

April 28, 2026 06:08

jials commented Apr 28, 2026

Copy link

Copy Markdown

Contributor Author

Hi maintainers, I'm hoping we can get this merged in time for the upcoming release. Let me know if you need any additional context from my end to help with the review. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ntkathole approved these changes

May 1, 2026

View reviewed changes

ntkathole left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jials reacted with hooray emoji

All reactions

🎉 1 reaction

jials added 8 commits

May 1, 2026 10:35


          fix: Use set() instead of [] for set-typed variables in SnowflakeRegi…

ca2c12c

…stry._sync_feast_metadata_to_projects_table

Signed-off-by: Jia Le <[email protected]>


          fix: Resolve init ordering, infinite recursion, and column casing bug…

5c50fdb

…s in SnowflakeRegistry

Signed-off-by: Jia Le <[email protected]>


          test: Add snowflake_registry fixture to integration registry tests

0e85d62

Signed-off-by: Jia Le <[email protected]>


          ci: Add snowflake_registry to CI filter and exclude from non-Snowflak…

7b5c8ff

…e test targets

Signed-off-by: Jia Le <[email protected]>


          fix: Remove leftover private key kwargs before passing to snowflake.c…

945d7a9

…onnector.connect

Signed-off-by: Jia Le <[email protected]>


          fix: correct set type hints in _sync_feast_metadata_to_projects_table

025c5b1

Signed-off-by: Jia Le <[email protected]>


          fix: resolve mypy type errors in SnowflakeRegistry cache

a8739a8

Signed-off-by: Jia Le <[email protected]>


          test: add xdist_group mark to snowflake_registry

00f5869

Signed-off-by: Jia Le <[email protected]>

ntkathole force-pushed the fix/snowflake-registry-bugs branch from 0aec995 to 00f5869 Compare

May 1, 2026 05:05

ntkathole merged commit 7e66a2e into feast-dev:master

May 1, 2026

20 of 29 checks passed

Uh oh!

There was an error while loading. Please reload this page.

jials deleted the fix/snowflake-registry-bugs branch

May 3, 2026 07:11

franciscojavierarceo pushed a commit that referenced this pull request

May 4, 2026


          chore(release): release 0.63.0

50ad181

# [0.63.0](v0.62.0...v0.63.0) (2026-05-04)

### Bug Fixes

* Add project filter to apply_data_source and delete_data_source (closes [#6206](#6206)) ([#6322](#6322)) ([96562c4](96562c4))
* Add project_id filter to SnowflakeRegistry UPDATE path ([#6243](#6243)) ([6658b71](6658b71)), closes [#6208](#6208) [#6208](#6208)
* Add subprocess timeouts to prevent test_e2e_local hanging on Dask atexit handler ([3de6556](3de6556))
* Ambiguous truth value of array during materialization ([#6259](#6259)) ([d0c8984](d0c8984))
* Auto-detect GCS/S3 registry store when registry is passed as string ([#6260](#6260)) ([7ebcf03](7ebcf03))
* **bigquery:** Prefer query over table in get_table_query_string ([#6360](#6360)) ([77ed779](77ed779)), closes [#6200](#6200)
* correct project_id scoping in get_user_metadata and delete_project ([0c469a7](0c469a7))
* disable Redis RDB persistence in test deployments ([44cd682](44cd682))
* Disable snowflake tests temporarily in CI ([#6356](#6356)) ([31d5a98](31d5a98))
* Filter empty SQL commands at execute_snowflake_statement call sites ([#6249](#6249)) ([92ffbb9](92ffbb9))
* Fix five bugs in milvus online store ([#6275](#6275)) ([212504b](212504b))
* Fix issue with apply feature view ([835cda8](835cda8))
* Fix streaming materialization for exotic sources with lazy UDF pipelines ([c07972d](c07972d))
* Handle missing features gracefully instead of panicking ([7d00b3a](7d00b3a))
* Harden informer cache with label selectors and memory optimizations ([#6242](#6242)) ([3f11356](3f11356))
* **helm:** Avoid nil pointer for metrics.enabled inside podAnnotations ([#6251](#6251)) ([c833f1a](c833f1a))
* Include git in feast server image ([fb03c46](fb03c46))
* Include StreamFeatureView in freshness metric ([#6269](#6269)) ([463f16c](463f16c))
* Pre-create S3A event log dir before SparkContext init ([#6317](#6317)) ([9feca77](9feca77))
* Remote Online Store Type Inference Error with All-NULL Columns ([#6063](#6063)) ([de67bdd](de67bdd))
* Remove selector with kustomize overlay using a JSON 6902 patch ([9107a43](9107a43))
* Resolve multiple bugs in SnowflakeRegistry and Snowflake connection handling ([#6315](#6315)) ([7e66a2e](7e66a2e))
* **spark:** BatchFeatureView with TransformationMode.PYTHON now reads all source columns ([a310eaf](a310eaf))
* **spark:** Use SELECT * when feature_name_columns is empty in pull_all_from_table_or_query ([e1b1d2d](e1b1d2d))
* Support pandas mode in feature builder and fix dask column extraction ([863315e](863315e))
* support SQL string as entity_df in RemoteOfflineStore.get_historical_features ([c559889](c559889))
* Wrap LocalOutputNode return value in ArrowTableValue for consist… ([#6286](#6286)) ([a16cd55](a16cd55))

### Features

* Add agent skills and Cursor/Claude rules for Feast development ([312eea3](312eea3))
* Add feature view versioning support to FAISS online store ([b36acb7](b36acb7))
* Add feature view versioning support to Redis and DynamoDB online stores ([#6257](#6257)) ([edf25af](edf25af)), closes [#6164](#6164) [#6163](#6163)
* Add optional 'org' in feature view ([#6288](#6288)) ([#6301](#6301)) ([608b105](608b105))
* Add RaySource, to_ray_dataset first-class method, docs, and tests ([1c98157](1c98157))
* Add TLS support for Go Feature Server ([#6229](#6229)) ([28a58d0](28a58d0))
* Add Vector Search support to MongoDBOnlineStore ([#6344](#6344)) ([c102738](c102738))
* Add versioning support to Milvus online store ([#6330](#6330)) ([3268ced](3268ced))
* Addresses performance issues in the Redis online store ([2e50da0](2e50da0))
* Allow to set gpu for ray ([5580ab4](5580ab4))
* Bump redis-py version cap from <5 to <8 ([#6339](#6339)) ([9538180](9538180))
* Expose feature_server, materialization, and openlineage configuration via FeatureStore CRD ([ec6ecfd](ec6ecfd))
* Make online_write_batch_size configurable in MaterializationConfig ([#6268](#6268)) ([d41becf](d41becf))
* Make udf optional if agg defined ([#5689](#5689)) ([#6328](#6328)) ([f630056](f630056))
* MongoDB offline store ([#6138](#6138)) ([8eebad7](8eebad7))
* Optional input_schema for ODFV ([#6308](#6308)) ([#6312](#6312)) ([f08b4e8](f08b4e8))
* Provision minimal TokenReview RBAC for OIDC auth and add SSL error logging in token parser ([#6240](#6240)) ([dca57e8](dca57e8))
* **spark:** Add compute-on-read support for BatchFeatureView in get_… ([#6357](#6357)) ([630d9f8](630d9f8))

Reviewers

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

ntkathole

ntkathole approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Snowflake Registry does not work

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

jials commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Checks

Testing Strategy

Misc

Uh oh!

This comment was marked as resolved.

Uh oh!

jials commented Apr 27, 2026

Uh oh!

jials commented Apr 28, 2026

Uh oh!

ntkathole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jials commented Apr 22, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.