GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — clarify the 4300-digit limit on int-str conversion by nedbat · Pull Request #100175 · python/cpython

Conversation

nedbat commented Dec 11, 2022

Copy link

Copy Markdown

Member

The message now seems to imply that numbers larger than 4300 cannot be stringified. Adding one word clarifies the meaning of the number.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          clarify the 4300-digit limit on int-str conversion

577c6af

bedevere-bot added the awaiting review label

Dec 11, 2022

netlify Bot commented Dec 11, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name	Link
🔨 Latest commit	`577c6af`
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/6396438aa4824d00089c6e22
😎 Deploy Preview	https://deploy-preview-100175--python-cpython-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nedbat added skip issue skip news labels

Dec 11, 2022

hugovk approved these changes

Dec 11, 2022

View reviewed changes

hugovk left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes it clearer.

(I also ran into this error during part 2 of today's Advent of Code, featuring ridiculously large numbers.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cj81499, OrangeChannel, and jugmac00 reacted with thumbs up emoji

All reactions

👍 3 reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Dec 11, 2022

gpshead approved these changes

Dec 12, 2022

View reviewed changes

gpshead commented Dec 12, 2022

Copy link

Copy Markdown

Member

I'm thankful for advent of code giving people a reason to even realize our new limit exists. 😁

cj81499, OrangeChannel, jugmac00, kushaldas, and hugovk reacted with thumbs up emoji

rewhile reacted with thumbs down emoji

All reactions

👍 5 reactions
👎 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead added the needs backport to 3.11 only security fixes label

Dec 12, 2022

hugovk merged commit 935ef59 into python:main

Dec 12, 2022

miss-islington commented Dec 12, 2022

Copy link

Copy Markdown

Contributor

Thanks @nedbat for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Dec 12, 2022

bedevere-bot commented Dec 12, 2022

Copy link

Copy Markdown

GH-100193 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Dec 12, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 12, 2022


          clarify the 4300-digit limit on int-str conversion (pythonGH-100175)

39e461b

(cherry picked from commit 935ef59)

Co-authored-by: Ned Batchelder <[email protected]>

miss-islington added a commit that referenced this pull request

Dec 12, 2022


          clarify the 4300-digit limit on int-str conversion (GH-100175)

17bc55e

(cherry picked from commit 935ef59)

Co-authored-by: Ned Batchelder <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Dec 14, 2022


          Merge branch 'main' into typedocs

53d33a1

* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...

nedbat deleted the nedbat/4300-digits branch

March 19, 2024 20:00

Reviewers

gpshead

gpshead approved these changes

hugovk

hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

nedbat commented Dec 11, 2022

Uh oh!

netlify Bot commented Dec 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for python-cpython-preview ready!

Uh oh!

hugovk left a comment

Choose a reason for hiding this comment

Uh oh!

gpshead commented Dec 12, 2022

Uh oh!

miss-islington commented Dec 12, 2022

Uh oh!

bedevere-bot commented Dec 12, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify Bot commented Dec 11, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.