GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs by busywhitespace · Pull Request #100249 · python/cpython

Conversation

@busywhitespace

@busywhitespace busywhitespace commented Dec 14, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

See the issue #100248 for more details.

  • Issue: Possibly missing parameters in the documentation of asyncio functions #100248

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
busywhitespace
Add a missing parameter into the documentation of asyncio.
1c9eb0e 
Adding ssl_shutdown_timeout parameter into the documentation of
asyncio.open_connection/start_server/open_unix_connection/start_unix_server.
@busywhitespace
busywhitespace requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners December 14, 2022 16:38
@bedevere-bot bedevere-bot mentioned this pull request Dec 14, 2022
Possibly missing parameters in the documentation of asyncio functions #100248
Closed
@netlify

netlify Bot commented Dec 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 1c9eb0e
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/6399fc1426cea500086641dc
😎 Deploy Preview https://deploy-preview-100249--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 14, 2022
kumaraditya303
kumaraditya303 approved these changes Dec 14, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 14, 2022
@kumaraditya303 kumaraditya303 added the needs backport to 3.11 only security fixes label Dec 14, 2022
@kumaraditya303 kumaraditya303 linked an issue Dec 14, 2022 that may be closed by this pull request
Possibly missing parameters in the documentation of asyncio functions #100248
Closed
@kumaraditya303 kumaraditya303 changed the title gh-100248: Add a missing parameter into the documentation of asyncio. gh-100248: Add missing ssl_shutdown_timeout parameter in asyncio dcos Dec 14, 2022
@kumaraditya303 kumaraditya303 changed the title gh-100248: Add missing ssl_shutdown_timeout parameter in asyncio dcos gh-100248: Add missing ssl_shutdown_timeout parameter in asyncio docs Dec 14, 2022
@kumaraditya303
kumaraditya303 merged commit 9663853 into python:main Dec 14, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 14, 2022
@miss-islington

miss-islington commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

Thanks @busywhitespace for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Dec 14, 2022

Copy link
Copy Markdown

GH-100250 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2022
busywhitespace @miss-islington
pythongh-100248: Add missing ssl_shutdown_timeout parameter in `asy…
612f8bf 
…ncio` docs (pythonGH-100249)

(cherry picked from commit 9663853)

Co-authored-by: busywhitespace <[email protected]>
miss-islington added a commit that referenced this pull request Dec 14, 2022
@miss-islington busywhitespace
gh-100248: Add missing ssl_shutdown_timeout parameter in asyncio …
cb1001c 
…docs (GH-100249)

(cherry picked from commit 9663853)

Co-authored-by: busywhitespace <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1 
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possibly missing parameters in the documentation of asyncio functions

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@busywhitespace @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.