GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100174: [Enum] Correct PowersOfThree example. by Beweeted · Pull Request #100178 · python/cpython

Conversation

@Beweeted

@Beweeted Beweeted commented Dec 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Changed from multiples of 3 to powers of 3 to match the class name.

  • Issue: Enum Docs does MultiplesOfThree instead of PowersOfThree #100174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Beweeted
[3.11] gh-100174: Fix math in PowersOfThree example class.
660d462 
Changed from multiples of 3 to powers of 3 to match the class name.
@Beweeted
Beweeted requested a review from ethanfurman as a code owner December 11, 2022 21:34
@ghost

ghost commented Dec 11, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Dec 11, 2022
Enum Docs does MultiplesOfThree instead of PowersOfThree #100174
Closed
@netlify

netlify Bot commented Dec 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 660d462
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/63964cf6ac4fe9000810997b
😎 Deploy Preview https://deploy-preview-100178--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 11, 2022
@AlexWaygood

AlexWaygood commented Dec 11, 2022

Copy link
Copy Markdown
Member

Thanks! Unfortunately, nearly all Python PRs are made against the main branch, and then backported to maintenance branches after they've been merged. The best thing to do is to recreate the PR based against main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood closed this Dec 11, 2022
@Beweeted

Beweeted commented Dec 11, 2022

Copy link
Copy Markdown
Contributor Author

This is against main. I'm sure I missed something, but I couldn't find the button to make a new branch from the docs. I hit edit on the file, and it auto-forked it and gave me the option to merge it back in.

If you can point me in the right direction @AlexWaygood I'm happy to do the extra steps. Unless those steps are to sync & build the whole repo on my local, which is what the cpython docs were telling me to do.

Really, the most confusing thing is talking about backporting. Which I don't understand how that's applicable to this at all.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood reopened this Dec 11, 2022
@AlexWaygood

AlexWaygood commented Dec 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is against main. I'm sure I missed something, but I couldn't find the button to make a new branch from the docs. I hit edit on the file, and it auto-forked it and gave me the option to merge it back in.

If you can point me in the right direction @AlexWaygood I'm happy to do the extra steps. Unless those steps are to sync & build the whole repo on my local, which is what the cpython docs were telling me to do.

Really, the most confusing thing is talking about backporting. Which I don't understand how that's applicable to this at all.

Apologies! Your PR title confused me. We usually use the [3.11] tag for PRs that are against the 3.11 branch.

The "backport" PR will be done automatically by a robot after this PR is merged. You won't need to worry about it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood changed the title [3.11] gh-100174: Fix math in PowersOfThree example class. [gh-100174: Fix math in PowersOfThree example class. Dec 11, 2022
@AlexWaygood AlexWaygood changed the title [gh-100174: Fix math in PowersOfThree example class. gh-100174: Fix math in PowersOfThree example class. Dec 11, 2022
@AlexWaygood

AlexWaygood commented Dec 11, 2022

Copy link
Copy Markdown
Member

We will need you to sign the CLA, however :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Dec 11, 2022
@Beweeted

Beweeted commented Dec 11, 2022

Copy link
Copy Markdown
Contributor Author

Oh, oh oh. That makes sense. I had been seeing the other PRs and most seemed to have the version in the name. It wasn't mentioned in the comment, but I thought I was being a keener. I'll keep this in mind next time!
AlexWaygood and ethanfurman reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman ethanfurman changed the title gh-100174: Fix math in PowersOfThree example class. gh-100174: [Enum] Correct PowersOfThree example. Dec 11, 2022
@ethanfurman ethanfurman self-assigned this Dec 11, 2022
ethanfurman
ethanfurman approved these changes Dec 11, 2022
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As soon as you sign the CLA we can merge this in.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 11, 2022
@ethanfurman
ethanfurman merged commit 868bab0 into python:main Dec 11, 2022
@miss-islington

miss-islington commented Dec 11, 2022

Copy link
Copy Markdown
Contributor

Thanks @Beweeted for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 11, 2022
@bedevere-bot

bedevere-bot commented Dec 11, 2022

Copy link
Copy Markdown

GH-100181 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 11, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2022
@Beweeted @miss-islington
pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
4ce43b5 
Changed from multiples of 3 to powers of 3 to match the class name.
(cherry picked from commit 868bab0)

Co-authored-by: Beweeted <[email protected]>
miss-islington added a commit that referenced this pull request Dec 11, 2022
@miss-islington @Beweeted
gh-100174: [Enum] Correct PowersOfThree example. (GH-100178)
593c5a0 
Changed from multiples of 3 to powers of 3 to match the class name.
(cherry picked from commit 868bab0)

Co-authored-by: Beweeted <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Dec 14, 2022
@carljm
Merge branch 'main' into typedocs
53d33a1 
* main: (103 commits)
  pythongh-100248: Add missing `ssl_shutdown_timeout` parameter in `asyncio` docs (python#100249)
  Assorted minor fixes for specialization stats. (pythonGH-100219)
  pythongh-100176: venv: Remove redundant compat code for Python <= 3.2 (python#100177)
  pythonGH-100222: Redefine _Py_CODEUNIT as a union to clarify structure of code unit. (pythonGH-100223)
  pythongh-99955: undef ERROR and SUCCESS before redefining (fixes sanitizer warning) (python#100215)
  pythonGH-100206: use versionadded for the addition of sysconfig.get_default_scheme (python#100207)
  pythongh-81057: Move _Py_RefTotal to the "Ignored Globals" List (pythongh-100203)
  pythongh-81057: Move Signal-Related Globals to _PyRuntimeState (pythongh-100085)
  pythongh-81057: Move faulthandler Globals to _PyRuntimeState (pythongh-100152)
  pythongh-81057: Move tracemalloc Globals to _PyRuntimeState (pythongh-100151)
  pythonGH-100143: Improve collecting pystats for parts of runs (pythonGH-100144)
  pythongh-99955: standardize return values of functions in compiler's code-gen (python#100010)
  pythongh-79218: Define `MS_WIN64` macro for Mingw-w64 64bit on Windows (pythonGH-100137)
  Fix: typo (Indention) (pythonGH-99904)
  pythongh-96715 Remove redundant NULL check in `profile_trampoline` function (python#96716)
  pythongh-100176: remove incorrect version compatibility check from argument clinic (python#100190)
  clarify the 4300-digit limit on int-str conversion (python#100175)
  pythongh-70393: Clarify mention of "middle" scope (python#98839)
  pythongh-99688: Fix outdated tests in test_unary (python#99712)
  pythongh-100174: [Enum] Correct PowersOfThree example. (pythonGH-100178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Beweeted @AlexWaygood @miss-islington @bedevere-bot @ethanfurman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.