GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100556: Better `or` doc wording by ramvikrams · Pull Request #100589 · python/cpython

Conversation

@ramvikrams

@ramvikrams ramvikrams commented Dec 28, 2022

Copy link
Copy Markdown
Contributor

gh-100556: changed the or documentation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ramvikrams
Update stdtypes.rst
4784262
@bedevere-bot bedevere-bot mentioned this pull request Dec 28, 2022
Better or doc wording #100556
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 28, 2022
AlexandroLuis
AlexandroLuis suggested changes Dec 29, 2022
View reviewed changes

@AlexandroLuis AlexandroLuis left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder how and works if there's no comparison
just
if x is false: x else: y
and not
if x is True and y is True: True else: False

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Dec 29, 2022
@ramvikrams

ramvikrams commented Dec 29, 2022

Copy link
Copy Markdown
Contributor Author

i wonder how and works if there's no comparison
just
if x is false: x else: y
and not
if x is True and y is True: True else: False

Thanks will do the change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ramvikrams
Update stdtypes.rst
985f3fd
slateny
slateny reviewed Dec 30, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Outdated
| | *y* | |
+-------------+---------------------------------+-------+
| ``x and y`` | if *x* is True and *y* is True, | \(2) |
| | then True, else False | |

@slateny slateny Dec 30, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you misunderstood the other comment, as this now doesn't cover something like

>>> [] and [1]
[]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ramvikrams ramvikrams Dec 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please tell then how should it be framed, bcoz I am not able to think of it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AlexandroLuis AlexandroLuis Dec 30, 2022

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if x and y, then True, else False

it covers if it's Null, empty, False...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ramvikrams ramvikrams Dec 30, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks i'll do it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@slateny slateny Dec 31, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original mention of 'true'/'false' refers to all truthy and falsey values, which include 0, None, empty lists, etc., and saying True excludes those as True refers to just the boolean value. I also don't think that it's all that helpful for a table to have an entry to say x and y then its explanation also say x and y, so I would actually recommend just sticking with the original for this and section.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ramvikrams added 2 commits December 30, 2022 19:40
@ramvikrams
Update stdtypes.rst
ea77950
@ramvikrams
Update stdtypes.rst
254b699
hugovk
hugovk reviewed Dec 31, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ramvikrams @hugovk
Update Doc/library/stdtypes.rst
83e83ed 
Co-authored-by: Hugo van Kemenade <[email protected]>
@CAM-Gerlach CAM-Gerlach added needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 21, 2023
CAM-Gerlach
CAM-Gerlach approved these changes Feb 21, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM IMO; it avoids a double negative (if false, else) and the order follows more closely with that of the expression itself

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
erlend-aasland
erlend-aasland approved these changes Feb 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 21, 2023
@erlend-aasland

erlend-aasland commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR @ramvikrams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit b40dd71 into python:main Feb 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 21, 2023
@miss-islington

miss-islington commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @ramvikrams for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
@ramvikrams @hugovk @miss-islington
pythongh-100556: Improve clarity of or docs (pythonGH-100589)
57ba8e6 
(cherry picked from commit b40dd71)

Co-authored-by: ram vikram singh <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 21, 2023

Copy link
Copy Markdown

GH-102108 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
@ramvikrams @hugovk @miss-islington
pythongh-100556: Improve clarity of or docs (pythonGH-100589)
4c9a446 
(cherry picked from commit b40dd71)

Co-authored-by: ram vikram singh <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot

bedevere-bot commented Feb 21, 2023

Copy link
Copy Markdown

GH-102109 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 21, 2023
miss-islington added a commit that referenced this pull request Feb 21, 2023
@miss-islington @ramvikrams @hugovk
gh-100556: Improve clarity of or docs (GH-100589)
444ec74 
(cherry picked from commit b40dd71)

Co-authored-by: ram vikram singh <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington added a commit that referenced this pull request Feb 21, 2023
@miss-islington @ramvikrams @hugovk
gh-100556: Improve clarity of or docs (GH-100589)
a94f3ad 
(cherry picked from commit b40dd71)

Co-authored-by: ram vikram singh <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@CAM-Gerlach CAM-Gerlach changed the title gh-100556: Better or doc working gh-100556: Better or doc wording Feb 22, 2023
@CAM-Gerlach

CAM-Gerlach commented Feb 22, 2023

Copy link
Copy Markdown
Member

Oops, forgot to fix the title...hope you fixed it in the commit message :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Oops, forgot to fix the title...hope you fixed it in the commit message :)

I did... hope you like it 😄 b40dd71
I'll do better next time!
CAM-Gerlach reacted with thumbs up emoji CAM-Gerlach reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm added a commit to carljm/cpython that referenced this pull request Feb 23, 2023
@carljm
Merge branch 'main' into lockfreecp
b257a16 
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
@CAM-Gerlach

CAM-Gerlach commented Feb 23, 2023

Copy link
Copy Markdown
Member

Oh, that's fine then of course :) At least for me updating the title-generated commit message updates the PR title as well, but it seems that's actually GitHub Refined rather than a builtin feature (I never know these days, heh)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@ramvikrams @hugovk @python-sidebar
pythongh-100556: Improve clarity of or docs (python#100589)
9fb4ef8 
Co-authored-by: Hugo van Kemenade <[email protected]>
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@ramvikrams @hugovk @python-sidebar
pythongh-100556: Improve clarity of or docs (python#100589)
75260af 
Co-authored-by: Hugo van Kemenade <[email protected]>
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@ramvikrams @hugovk @JelleZijlstra
pythongh-100556: Improve clarity of or docs (python#100589)
3d5a88e 
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@slateny slateny slateny left review comments
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes
+1 more reviewer
@AlexandroLuis AlexandroLuis AlexandroLuis requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ramvikrams @erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach @hugovk @slateny @AlexandroLuis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.