GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95672 fix typo SkitTest to SkipTest by hyeongyun0916 · Pull Request #102119 · python/cpython

Conversation

@hyeongyun0916

@hyeongyun0916 hyeongyun0916 commented Feb 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fix typo SkitTest to SkipTest

  • ISSUE: pipe test failures on some Linux configurations  #95672 - 2nd
  • Issue: pipe test failures on some Linux configurations  #95672

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hyeongyun0916
fix typo SkitTest to SkipTest
3e45ffc
@hyeongyun0916
hyeongyun0916 requested a review from gpshead as a code owner February 21, 2023 16:37
@bedevere-bot bedevere-bot added the awaiting review label Feb 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 21, 2023
pipe test failures on some Linux configurations #95672
Closed
@ghost

ghost commented Feb 21, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 self-assigned this Feb 21, 2023
@corona10 corona10 added needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 21, 2023
corona10
corona10 reviewed Feb 21, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2023-02-21-23-23-26.bpo-95672.-ogWWJ.rst Outdated
@@ -0,0 +1,2 @@
Fix the typos ("SkitTest") in test_fcntl_f_pipesize and test_pipesizes.

@corona10 corona10 Feb 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyeongyun0916 We can skip the NEWS.d since the unit test does not affect to end-user usage :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hyeongyun0916 hyeongyun0916 Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll delete it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 corona10 added the skip news label Feb 21, 2023
@hyeongyun0916
delete NEWS.d
9a6bdd9
corona10
corona10 approved these changes Feb 21, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 21, 2023
@corona10
corona10 merged commit d5c7954 into python:main Feb 21, 2023
@miss-islington

miss-islington commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @hyeongyun0916 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 21, 2023
@bedevere-bot

bedevere-bot commented Feb 21, 2023

Copy link
Copy Markdown

GH-102121 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 21, 2023
@bedevere-bot

bedevere-bot commented Feb 21, 2023

Copy link
Copy Markdown

GH-102122 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
@hyeongyun0916 @miss-islington
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
bbe277e 
(cherry picked from commit d5c7954)

Co-authored-by: Hyunkyun Moon <[email protected]>
Co-authored-by: HyunKyun Moon <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
@hyeongyun0916 @miss-islington
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
d3f8606 
(cherry picked from commit d5c7954)

Co-authored-by: Hyunkyun Moon <[email protected]>
Co-authored-by: HyunKyun Moon <[email protected]>
corona10 pushed a commit that referenced this pull request Feb 22, 2023
@miss-islington @hyeongyun0916
[3.11] gh-95672 fix typo SkitTest to SkipTest (gh-102119) (#102121)
5d47150 
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
(cherry picked from commit d5c7954)

Co-authored-by: HyunKyun Moon <[email protected]>
corona10 pushed a commit that referenced this pull request Feb 22, 2023
@miss-islington @hyeongyun0916
[3.10] gh-95672 fix typo SkitTest to SkipTest (gh-102119) (gh-102122)
bac3fe7 
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
(cherry picked from commit d5c7954)

Co-authored-by: HyunKyun Moon <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Feb 23, 2023
@carljm
Merge branch 'main' into lockfreecp
b257a16 
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@hyeongyun0916 @python-sidebar
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
8ac8bdd 
Co-authored-by: HyunKyun Moon <[email protected]>
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@hyeongyun0916 @python-sidebar
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
da08f1d 
Co-authored-by: HyunKyun Moon <[email protected]>
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@hyeongyun0916 @JelleZijlstra
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
065e45d 
Co-authored-by: HyunKyun Moon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hyeongyun0916 @miss-islington @bedevere-bot @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.