GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101903: Remove unnecessary undefs for non-existent/old macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall by OTheDev · Pull Request #101923 · python/cpython

Conversation

@OTheDev

@OTheDev OTheDev commented Feb 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

While taking a look at #101903, I noticed a couple of undefs lingering before the function definitions of Py_EnterRecursiveCall/Py_LeaveRecursiveCall.

The macro definitions for Py_EnterRecursiveCall/Py_LeaveRecursiveCall were removed in #91988. These undefs should therefore be redundant.

  • Issue: Use _Py_EnterRecursiveCall private API in _bisectmodule.c #101903

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
oda-gitso
Remove unnecessary undefs for non-existent/old macros Py_EnterRecursi…
e011d95 
…veCall and Py_LeaveRecursiveCall
@OTheDev
OTheDev requested a review from markshannon as a code owner February 14, 2023 23:38
@bedevere-bot bedevere-bot added the awaiting review label Feb 14, 2023
@arhadthedev arhadthedev added skip issue skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Feb 15, 2023
@iritkatriel iritkatriel removed the skip issue label Feb 21, 2023
@iritkatriel iritkatriel changed the title Remove unnecessary undefs for non-existent/old macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall gh-101903: Remove unnecessary undefs for non-existent/old macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall Feb 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 21, 2023
Use _Py_EnterRecursiveCall private API in _bisectmodule.c #101903
Closed
iritkatriel
iritkatriel approved these changes Feb 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 21, 2023
@iritkatriel
iritkatriel merged commit 7346a38 into python:main Feb 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 21, 2023
@erlend-aasland

erlend-aasland commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

Thanks for the PR. I don't think backporting to 3.11 is worth it.
OTheDev and iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OTheDev

OTheDev commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@OTheDev
OTheDev deleted the remove-unnec-undefs branch February 21, 2023 12:26
carljm added a commit to carljm/cpython that referenced this pull request Feb 23, 2023
@carljm
Merge branch 'main' into lockfreecp
b257a16 
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@OTheDev @python-sidebar
pythongh-101903: Remove obsolete undefs for previously removed macros…
b0f2b1b 
… Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@OTheDev @python-sidebar
pythongh-101903: Remove obsolete undefs for previously removed macros…
6f23007 
… Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@OTheDev @JelleZijlstra
pythongh-101903: Remove obsolete undefs for previously removed macros…
f3640ce 
… Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@OTheDev @erlend-aasland @iritkatriel @arhadthedev @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.