GeezerVison is showing github.com — feat: add organization skill read routes by ibetitsmike · Pull Request #30588 · coder/coder
Conversation
ibetitsmike
commented
Oct 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Part of CODAGT-1341.
Adds the read side of the organization skills API: GET /api/experimental/organizations/{organization}/skills and GET .../skills/{skillName}. Like the personal skill routes, they are not gated by an experiment or a license. The list calls ListOrganizationSkillMetadataByOrganizationID with the caller's own permissions, so org admins, the site owner and org auditors see every skill, while members see only skills shared with them through the group or user ACL. Disabled skills are listed with enabled: false, and clients filter them. Callers outside the organization get 404 from the organization parameter middleware.
GET .../{skillName} uses the new httpmw.ExtractOrganizationSkillParam(db, auth, actions...), modeled on ExtractMCPServerConfigParam. It reads the skill by organization and name without permission checks, then returns 404 unless the caller can perform at least one of the listed actions on Skill.RBACObject(), so a missing skill and a denied one look the same. GET admits only read, so a key scoped to organization_skill:update or organization_skill:delete without read gets 404. The SDK adds OrganizationSkills and OrganizationSkillByName, and db2sdk adds OrganizationSkillMetadataList. Create, update, delete and audit come in the next layer.
Testing
- New
coderd/organizationskills_test.go TestOrganizationSkillAccess, with skills seeded through dbgen.OrganizationSkill:
- a member reads a skill shared with Everyone;
- a user-ACL grant is visible only to that user;
- an org auditor can list and get;
- a member of another organization gets 404;
- an API key scoped to
organization_skill:read can list and get, while WriteScopedAPIKeyCannotRead keys scoped to update or delete get 404 (fails on the old route).
- Red-green: making the middleware allow every caller fails the user-ACL case, and so does running the list query with system permissions.
- Ran the
coderd tests, TestEnterpriseEndpointsDocumented, golangci-lint on the touched packages, and the pre-commit hook.
Review record
- Remote UAT round 6 through Coder Agents: PASS on the final stack tip
afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
- Parent review kept GET accepting read, update, or delete, as
ExtractMCPServerConfigParam does on the MCP routes; Codex round 1 limited it to read (7d70608), so update or delete scoped keys can't read content through GET.
- Test audit: dropped a subtest that cleared the Everyone grant with raw SQL and checked that a member loses access.
UserACLGrantsOnlyThatUser already covers a member without a grant, and the ACL routes layer tests revoking the grant through the API.
This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
This was referenced Oct 10, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-10T03:41:37.357782Z |
7d70608 |
Manual request |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95549e699d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 🚀
Reviewed commit: 7d70608487
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|