GeezerVison is showing github.com — refactor(site/src): parameterize the skills table by owner, copy, and edit access by ibetitsmike · Pull Request #30596 · coder/coder
Conversation
ibetitsmike
commented
Oct 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Part of CODAGT-1341.
Turns the personal skills table into a reusable component that the organization settings page can mount. The personal page renders the same copy, limit, and actions as before.
components/SkillsTable.tsx now exports SkillsTable({ owner, copy, canEdit }). It picks userSkills or the new organizationSkills(organizationId) list factory from the owner and runs the same create, edit, delete, download, and export flows. Toasts, error fallbacks, and the archive name come from copy.
SkillsTableView takes copy: SkillsCopy (noun, title, description, emptyDescription, editorDescription, archiveName), limit, and canEdit. When canEdit is false it hides Add skill, the limit warning, the empty-state description and call to action, and the Edit and Delete row items. Download and Export all stay available.
SkillEditor takes noun and description, so the dialog title and description follow the owner.
- The new
pages/AgentsPage/AgentSettingsSkillsPage.tsx mounts SkillsTable for { type: "user", user: "me" } with the existing personal copy and canEdit. The personal-skills route now loads this page.
Later layers add the Enabled toggle and View dialog, then the organization page, which replaces canEdit with per-action access from per-organization permissions.
Testing
SkillEditor.test.tsx passes the new noun and description props; its assertions are unchanged.
- New
SkillsTableView stories ReadOnly, ReadOnlyEmpty and ReadOnlyRowMenu capture the read-only table, empty state and row menu without Edit and Delete.
- When built:
tsc, biome lint, biome format, and knip at the commit's tree, Vitest for SkillEditor.test.tsx, and vitest --project=storybook for SkillsTableView.stories.tsx. The same checks pass at this branch head.
Review record
frontend-review (FE1 to FE10) and coder-frontend-review (eight roles, three rounds) ran over this layer together with the API, Enabled toggle, and organization page layers. All FE rules passed.
- Fixed in the Enabled toggle layer, not here:
cta={addSkillAction || undefined} (SD3, TN2), the noun JSDoc duplicated between SkillEditor and SkillsCopy (CD5), and the single-use personalSkillsCopy constants (SD1).
- Declined: RP4 (the
try/catch around parseSkillMarkdown in the component body predates this layer).
- Remote UAT round 6 through Coder Agents: PASS on the final stack tip
afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
- Codex round 1: fixed in 1640c6b,
ReadOnlyRowMenu now lives on this layer so Pixel captures the read-only row menu.
This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
This was referenced Oct 10, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-10T03:45:32.549858Z |
ba546cb |
Manual request |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 559e75c28d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 🎉
Reviewed commit: ba546cb146
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|