GeezerVison is showing github.com — refactor(site/src/pages/AISettingsPage): share the ACL principal autocomplete by ibetitsmike · Pull Request #30599 · coder/coder
Conversation
ibetitsmike
commented
Oct 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Part of CODAGT-1341.
The MCP server and chat model sharing dialogs each had their own principal autocomplete, and the two files were identical apart from the acl/available query they called. Both dialogs also carried the same helpers that turn an ACL response into ResourceSharingDialog data. This layer replaces the copies with one ACLPrincipalAutocomplete in pages/AISettingsPage/components/, which takes an availableQueryOptions: (options: UsersRequest) => UseQueryOptions<ACLAvailable> prop. The shared sharingDialogData and selectedPrincipal helpers move to components/aclSharing.ts. MCPServerSharingDialog and ChatModelSharingDialog now use both, and the two per-resource autocomplete files are removed.
This is a behavior-neutral refactor ahead of the organization skill permissions dialog in the next layer, which becomes the third user. The className="w-full" the dialogs passed was dropped because the shared Autocomplete trigger and input already apply w-full.
Testing
- No tests added or changed. The existing stories and tests pass unchanged.
pnpm exec tsc -p ., biome check and oxlint --deny-warnings on the touched files.
- Storybook:
MCPServerSharingDialog.stories.tsx, ChatModelSharingDialog.stories.tsx, UpdateMCPServerPageView.stories.tsx and ModelForm.stories.tsx (69 tests).
- Vitest:
MCPServerForm.test.tsx and ModelForm.test.tsx.
Review record
frontend-review FE1 to FE10: pass.
coder-frontend-review, two rounds over this layer together with the next one. Fixed: renamed the prop to availableQueryOptions and typed it with the library's UseQueryOptions; removed the no-op className prop. Declined: a shared hook for the remaining query, mutation and close wiring in the three dialogs (RO3), because the mutation arguments differ per resource. It is left as is.
- Remote UAT round 6 through Coder Agents: PASS on the final stack tip
afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
This was referenced Oct 10, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-10T06:06:56.941538Z |
f76a919 |
Manual request |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Another round soon, please!
Reviewed commit: 02a0e1a736
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 👍
Reviewed commit: 3860b15801
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Keep them coming!
Reviewed commit: f76a919dca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|