GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(site/src/pages/AgentsPage): show organization skills in the slash menu by ibetitsmike · Pull Request #30602 · coder/coder

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Part of CODAGT-1341.

The chat composer's / menu gets a third group, "Organization skills", between Personal and Workspace.

  • ChatMessageInput takes organizationId (from AgentChatInput) and fetches organizationSkills(organizationId) only once the trigger opens, with the personal skills' 60 second staleTime.
  • Org skills go through resolveSkillTriggers, so a name shared with a personal or workspace skill is qualified in every source (/org/x), as chatd requires. Selecting one inserts its trigger text like a personal skill. Status and empty copy covers three sources.

Behavior change for personal skills: disabled personal and org skills are hidden from the menu and no longer shadow a built-in command, matching chatd, which drops them before computing aliases. The submit intercept in AgentChatPage/submitChatTurn counts enabled org skills too, so an org skill named compact makes /compact send as a message. A personal or org list that fails with no cached data stays unknown: triggers stay qualified, /clear and /compact stay hidden, and submitting one shows the pending toast instead of clearing or compacting.

Testing

  • ChatMessageInput.test.tsx "slash menu skill sources": a bare org trigger chosen with the arrow keys, a personal and org collision qualified as /org/reviewer, disabled skills ignored when qualifying, a built-in hidden by an org skill, and built-ins hidden and triggers kept qualified when the org list fails. AgentChatPage.test.tsx: /clear and /compact run neither while the org list fails. AgentChatInput.test.tsx and submitChatTurn.test.ts cover the chat organization's skills and the /compact case; five new stories cover the groups and states.
  • Red-green: dropping the org list from the intercept, an empty org list, no enabled filter, and ignoring org skills for commands each fail a test.
  • pnpm lint, vitest under src/pages/AgentsPage and touched stories passed at the original tip.

Review record

  • frontend-review passed; coder-frontend-review (up to 4 rounds per role) fixed SD1, SD3, CD, TS3 and DF5 (below).
  • Declined: one shared group renderer in SkillsTriggerMenu (RO3), because scripts/check-compiler.mjs then reported unmemoized closures; filtering once for both consumers (RO3), because the intercept and the menu own different queries; splitting ChatMessageInput (RP6), already over the size guideline before about 20 more lines.
  • Remote UAT round 6 through Coder Agents: PASS on the final stack tip afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
  • Test audit: the bare org trigger test now picks the skill with the arrow keys instead of a click, so it also fails when org skills drop out of the keyboard selection list or move ahead of personal skills.
  • coder-frontend-review DF5 (blocking) made a failed list with no data count as empty for built-ins, and a second fix kept triggers qualified; Codex round 1 reversed the built-in half (41cc34b), so a transient error can't run /clear or /compact instead of a same-named skill.
  • coder-frontend-review of the Codex fixes: fixed CD6, TS2, SD1 (566bfc0, e501a1d, c236bb4); declined TS6, as new spies match each story's spy style.

This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.

Xum opened this PR on behalf of @ibetitsmike.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ibetitsmike
feat(site/src/pages/AgentsPage): show organization skills in the slas…
880da8d
…h menu
@ibetitsmike
ibetitsmike added this pull request to stack #30605 October 10, 2026 01:33
@github-actions github-actions Bot assigned ibetitsmike Oct 10, 2026
This was referenced Oct 10, 2026
refactor: rename user_skills to skills #30584
Closed
feat: add organization and project owners to skills #30585
Closed
feat: add the organization_skill RBAC resource and skill queries #30586
Closed
feat: make skill types scope-neutral and add a personal skill enabled toggle #30587
Closed
feat: add organization skill read routes #30588
Closed
feat: add organization skill write routes and audit #30589
Closed
refactor(site/src/pages/AgentsPage): make skill components scope-neutral #30590
Closed
feat: add organization skill ACL queries and share organization ACL helpers #30591
Closed
feat: add organization skill ACL routes #30592
Closed
feat(coderd/x): merge skills from personal, org, and workspace sources #30593
Closed
feat(coderd/x): load organization skills in chats #30594
Closed
feat(site/src): add organization skill API methods and owner-scoped skill queries #30595
Closed
refactor(site/src): parameterize the skills table by owner, copy, and edit access #30596
Closed
feat(site/src): add an enabled toggle and a view dialog to the skills table #30597
Closed
feat(site): add the organization skills settings page #30598
Closed
refactor(site/src/pages/AISettingsPage): share the ACL principal autocomplete #30599
Closed
feat(site/src): add organization skill permissions #30600
Closed
refactor(site/src/pages/AgentsPage): resolve slash menu aliases with one n-source helper #30601
Closed
feat(site/src): show organization skills on the member skills page #30603
Closed
docs(docs/ai-coder/agents): document organization skills #30604
Closed
@ibetitsmike

ibetitsmike commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@linear-code

linear-code Bot commented Oct 10, 2026

Copy link
Copy Markdown

CODAGT-1341

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T06:08:05.338994Z c236bb4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Oct 10, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 880da8d5e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread site/src/pages/AgentsPage/AgentChatPage.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

ibetitsmike added 3 commits October 10, 2026 02:48
@ibetitsmike
Merge the updated alias-helper layer into slash-menu
c7df570
@ibetitsmike
fix(site/src/pages/AgentsPage): keep built-in commands pending when a…
41cc34b
… skill list fails
@ibetitsmike
Merge the updated alias-helper layer into slash-menu
09eaafa
@ibetitsmike

ibetitsmike commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 09eaafa65d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ibetitsmike added 5 commits October 10, 2026 04:25
@ibetitsmike
Merge the updated alias-helper layer into slash-menu
3c3809d
@ibetitsmike
Merge the updated alias-helper layer into slash-menu
3e385a9
@ibetitsmike
test(site/src/pages/AgentsPage): wait for the visible skill load erro…
566bfc0
…r before submitting
@ibetitsmike
test(site/src/pages/AgentsPage): inline the single-use composer submi…
e501a1d
…t helper
@ibetitsmike
test(site/src/pages/AgentsPage): inline the single-use chat page outl…
c236bb4
…et context
@ibetitsmike

ibetitsmike commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: c236bb429b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike ibetitsmike mentioned this pull request Oct 11, 2026
feat: load organization skills in chats #30613
Merged
@ibetitsmike

ibetitsmike commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by a five-PR restack of the same work:

  1. feat: add the organization skills data model #30609 feat: add the organization skills data model
  2. feat: add organization skill API routes #30610 feat: add organization skill API routes
  3. feat: add organization skill sharing ACL routes #30611 feat: add organization skill sharing ACL routes
  4. feat(site): add organization skill settings with a shared skills UI #30612 feat(site): add organization skill settings with a shared skills UI
  5. feat: load organization skills in chats #30613 feat: load organization skills in chats

Closing this PR. Its branch stays for reference.

Xum commented and closed this PR on behalf of @ibetitsmike.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike ibetitsmike closed this Oct 11, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ibetitsmike ibetitsmike

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ibetitsmike
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.