GeezerVison is showing github.com — feat(site/src/pages/AgentsPage): show organization skills in the slash menu by ibetitsmike · Pull Request #30602 · coder/coder
Conversation
ibetitsmike
commented
Oct 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Part of CODAGT-1341.
The chat composer's / menu gets a third group, "Organization skills", between Personal and Workspace.
ChatMessageInput takes organizationId (from AgentChatInput) and fetches organizationSkills(organizationId) only once the trigger opens, with the personal skills' 60 second staleTime.
- Org skills go through
resolveSkillTriggers, so a name shared with a personal or workspace skill is qualified in every source (/org/x), as chatd requires. Selecting one inserts its trigger text like a personal skill. Status and empty copy covers three sources.
Behavior change for personal skills: disabled personal and org skills are hidden from the menu and no longer shadow a built-in command, matching chatd, which drops them before computing aliases. The submit intercept in AgentChatPage/submitChatTurn counts enabled org skills too, so an org skill named compact makes /compact send as a message. A personal or org list that fails with no cached data stays unknown: triggers stay qualified, /clear and /compact stay hidden, and submitting one shows the pending toast instead of clearing or compacting.
Testing
ChatMessageInput.test.tsx "slash menu skill sources": a bare org trigger chosen with the arrow keys, a personal and org collision qualified as /org/reviewer, disabled skills ignored when qualifying, a built-in hidden by an org skill, and built-ins hidden and triggers kept qualified when the org list fails. AgentChatPage.test.tsx: /clear and /compact run neither while the org list fails. AgentChatInput.test.tsx and submitChatTurn.test.ts cover the chat organization's skills and the /compact case; five new stories cover the groups and states.
- Red-green: dropping the org list from the intercept, an empty org list, no enabled filter, and ignoring org skills for commands each fail a test.
pnpm lint, vitest under src/pages/AgentsPage and touched stories passed at the original tip.
Review record
frontend-review passed; coder-frontend-review (up to 4 rounds per role) fixed SD1, SD3, CD, TS3 and DF5 (below).
- Declined: one shared group renderer in
SkillsTriggerMenu (RO3), because scripts/check-compiler.mjs then reported unmemoized closures; filtering once for both consumers (RO3), because the intercept and the menu own different queries; splitting ChatMessageInput (RP6), already over the size guideline before about 20 more lines.
- Remote UAT round 6 through Coder Agents: PASS on the final stack tip
afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
- Test audit: the bare org trigger test now picks the skill with the arrow keys instead of a click, so it also fails when org skills drop out of the keyboard selection list or move ahead of personal skills.
coder-frontend-review DF5 (blocking) made a failed list with no data count as empty for built-ins, and a second fix kept triggers qualified; Codex round 1 reversed the built-in half (41cc34b), so a transient error can't run /clear or /compact instead of a same-named skill.
- coder-frontend-review of the Codex fixes: fixed CD6, TS2, SD1 (566bfc0, e501a1d, c236bb4); declined TS6, as new spies match each story's spy style.
This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
This was referenced Oct 10, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-10T06:08:05.338994Z |
c236bb4 |
Manual request |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 880da8d5e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 👍
Reviewed commit: 09eaafa65d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. 🎉
Reviewed commit: c236bb429b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|