GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add organization skill ACL queries and share organization ACL helpers by ibetitsmike · Pull Request #30591 · coder/coder

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Part of CODAGT-1341.

Adds the database and SDK pieces for editing an organization skill's access control list, with no routes. UpdateOrganizationSkillACLByID in queries/skills.sql writes group_acl, user_acl and updated_at on an org-owned row and returns it; dbauthz loads the row and checks share on its RBACObject(), following the MCP server config ACL pattern. The row lock it pairs with, GetOrganizationSkillByIDForUpdate, comes from the write routes layer. LockOrganizationMembersByUserIDsForShare in queries/organizationmembers.sql locks the listed users' membership rows FOR KEY SHARE, so they can't be removed until the transaction ends; dbauthz checks read on the organization's members. codersdk/skills.go gains OrganizationSkillRole (read, or "" to delete), OrganizationSkillACL, OrganizationSkillUser, OrganizationSkillGroup, UpdateOrganizationSkillACLRequest (sparse user_roles/group_roles), and the experimental client methods OrganizationSkillACL, UpdateOrganizationSkillACL and OrganizationSkillACLAvailable. The next layer adds the routes those methods call.

The second commit generalizes the MCP server config ACL helpers in coderd/mcp_acl.go so the skill routes can reuse them. The changes: type-parameterized principal resolution (resolveACLUsers, resolveACLGroups, aclGroupMemberCounts), one validateOrganizationACLUpdate that runs acl.Validate, the org membership and org match checks, and canonical UUID rekeying with duplicate rejection, plus applyACLReadRoles and writeOrganizationACLAvailable. coderd/rbac/acl gets a named Role constraint that includes the new role type. MCP behavior is unchanged except that its 500 error messages are now generic. The duplicate mcpServerConfigACLReducedUser is gone in favor of the existing reducedUserFromPaginatedOrganizationMember, and the MCP validator type is now unexported.

Testing

  • TestMethodTestSuite: new entries UpdateOrganizationSkillACLByID (asserts share) and LockOrganizationMembersByUserIDsForShare (asserts read on organization members).
  • The existing MCP ACL tests (TestMCPServerConfigACL, TestMCPServerConfigACLAvailable, TestMCPServerConfigACLWorkspaceSharingModes, TestMCPServerConfigACLConcurrentDelete) pass unchanged against the refactored helpers. So do the chat model ACL tests and ./coderd/rbac/acl/....
  • Built and tested at each commit's own tree: go build ./..., the full dbauthz suite, codersdk, golangci-lint on the touched packages, and make gen with no diff.

Review record

  • Remote UAT round 6 through Coder Agents: PASS on the final stack tip afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.

This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.

Xum opened this PR on behalf of @ibetitsmike.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

chatgpt-codex-connector[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
ibetitsmike added 2 commits October 10, 2026 01:27
@ibetitsmike
feat: add organization skill ACL queries and SDK types
8272419
@ibetitsmike
refactor(coderd): share organization ACL helpers across resources
89babfc
@github-actions github-actions Bot assigned ibetitsmike Oct 10, 2026
@ibetitsmike
ibetitsmike added this pull request to stack #30605 October 10, 2026 01:33
This was referenced Oct 10, 2026
refactor: rename user_skills to skills #30584
Closed
feat: add organization and project owners to skills #30585
Closed
feat: add the organization_skill RBAC resource and skill queries #30586
Closed
feat: make skill types scope-neutral and add a personal skill enabled toggle #30587
Closed
feat: add organization skill read routes #30588
Closed
feat: add organization skill write routes and audit #30589
Closed
refactor(site/src/pages/AgentsPage): make skill components scope-neutral #30590
Closed
@ibetitsmike ibetitsmike changed the title mike/org skills/acl queries feat: add organization skill ACL queries and share organization ACL helpers Oct 10, 2026
This was referenced Oct 10, 2026
feat: add organization skill ACL routes #30592
Closed
feat(coderd/x): merge skills from personal, org, and workspace sources #30593
Closed
feat(coderd/x): load organization skills in chats #30594
Closed
feat(site/src): add organization skill API methods and owner-scoped skill queries #30595
Closed
refactor(site/src): parameterize the skills table by owner, copy, and edit access #30596
Closed
feat(site/src): add an enabled toggle and a view dialog to the skills table #30597
Closed
feat(site): add the organization skills settings page #30598
Closed
refactor(site/src/pages/AISettingsPage): share the ACL principal autocomplete #30599
Closed
feat(site/src): add organization skill permissions #30600
Closed
refactor(site/src/pages/AgentsPage): resolve slash menu aliases with one n-source helper #30601
Closed
feat(site/src/pages/AgentsPage): show organization skills in the slash menu #30602
Closed
feat(site/src): show organization skills on the member skills page #30603
Closed
docs(docs/ai-coder/agents): document organization skills #30604
Closed
@ibetitsmike

ibetitsmike commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@linear-code

linear-code Bot commented Oct 10, 2026

Copy link
Copy Markdown

CODAGT-1341

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T03:42:38.703857Z b0f1b46 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 89babfc1d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike
Merge the updated site-rename layer into acl-queries
be0068e
# Conflicts:
#	coderd/database/dbauthz/dbauthz_test.go
#	coderd/database/queries/skills.sql
@ibetitsmike
feat(coderd/database): add a query that locks organization memberships
b0f1b46
@ibetitsmike

ibetitsmike commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: b0f1b464ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike ibetitsmike mentioned this pull request Oct 11, 2026
feat: add organization skill sharing ACL routes #30611
Merged
@ibetitsmike

ibetitsmike commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by a five-PR restack of the same work:

  1. feat: add the organization skills data model #30609 feat: add the organization skills data model
  2. feat: add organization skill API routes #30610 feat: add organization skill API routes
  3. feat: add organization skill sharing ACL routes #30611 feat: add organization skill sharing ACL routes
  4. feat(site): add organization skill settings with a shared skills UI #30612 feat(site): add organization skill settings with a shared skills UI
  5. feat: load organization skills in chats #30613 feat: load organization skills in chats

Closing this PR. Its branch stays for reference.

Xum commented and closed this PR on behalf of @ibetitsmike.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike ibetitsmike closed this Oct 11, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ibetitsmike ibetitsmike

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ibetitsmike
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.