GeezerVison is showing github.com — feat(site): add the organization skills settings page by ibetitsmike · Pull Request #30598 · coder/coder
Conversation
ibetitsmike
commented
Oct 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Part of CODAGT-1341.
Adds the organization skills admin page at /ai/settings/skills?org=<name>, modeled on the MCP servers page. It mounts the shared SkillsTable with an organization picker in a new toolbar slot.
- Access: a new site check
viewAnyOrganizationSkills (organization_skill, any_org, read) gates the route, the Skills sidebar item (deployment admin group and the organization-admin-only case), and the AI settings navbar link. AISettingsIndexRedirect sends such a user here when no earlier AI settings page applies.
- A per-organization view check picks the organizations the picker lists.
SkillsTable takes a SkillAccess object (fullSkillAccess, readOnlySkillAccess) instead of canEdit, and each permission gates its own controls: create gates Add skill, the empty-state add action and the limit notice; update gates the Enabled switch and Edit (View otherwise); delete gates Delete. An org auditor gets a read-only table.
- With no
?org=, the page picks a readable default. A requested organization the user cannot read shows the permission-denied page instead of falling back, so a skill is never added to an organization the URL did not name.
Members with only ACL access have no role-based read and do not get this page; later layers add their view and Manage permissions.
Testing
AISettingsIndexRedirect.test.tsx: an organization skills reader is redirected to Skills (fails without the redirect). New SkillsPage.test.tsx: picking another organization sets ?org and sends the next skills request to it (fails when the picker stops setting org); a read and update only role can toggle and open Edit (fails without the fix).
- New stories: six
SkillsPage states (admin, auditor, empty, several organizations, denied organization, permissions load error), two sidebar stories, and SkillsTableView UpdateOnlyRowMenu.
tsc, biome, knip, Vitest and the touched stories pass.
Review record
frontend-review passed; coder-frontend-review (eight roles, three rounds) fixed SD3, SD1, TS6, DF1 and TS7 (the permissions load error story).
- Declined: RO2 (about 30 repeated lines of the
MCPServersPage shell, left as is), RO4 (importing the picker from MCPServersPage matches other AI settings code), and TS6 for organizationsPermissions(...).queryKey (that module keeps its key private).
- Remote UAT round 6 through Coder Agents: PASS on the final stack tip
afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
- UAT round 4: an unknown or unreadable
?org shows the permission-denied page without the picker, while MCP servers and Models fall back to the default organization; kept on purpose, as above.
- Codex: round 1 added the org switching test (43ae662); round 2 split the access gates (58268f5) and declined the page for create-only roles (needs role-based read; API access stays); round 3 declined two custom-role edges: focus after a delete-only role removes the last skill (deferred accessibility gap), limit-notice delete advice for create-only roles.
- coder-frontend-review of the Codex fixes: fixed CD1, SD1, TN5, TS3, TS5 (617595a); declined TS7 (create-only and delete-only stories add no state) and an RP6 nit (row menu extraction, left as is).
This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
Add /ai/settings/skills?org=<name>, an organization skills page modeled
on the MCP servers page: an organization picker over the organizations
the user can read, a denied page for a requested organization the user
cannot read, and a read-only table for users without create, update,
and delete. Add the per-organization skill permission checks, the
viewAnyOrganizationSkills site check behind the Skills sidebar item and
the AI settings navbar link, and route a skills-only user to the page
from the AI settings index.
This was referenced Oct 10, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-10T06:16:12.424489Z |
617595a |
Manual request |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 089a8f7b9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…izations on the skills page
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4dae72ee1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 617595ac04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Another round soon, please!
Reviewed commit: 617595ac04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|