GeezerVison is showing github.com — feat(site/src): show organization skills on the member skills page by ibetitsmike · Pull Request #30603 · coder/coder
Conversation
ibetitsmike
commented
Oct 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Part of CODAGT-1341.
The Agents settings entry "Personal skills" becomes "Skills" at /agents/settings/skills; the old /agents/settings/personal-skills redirects there (<Navigate replace />).
AgentSettingsSkillsPage keeps the editable "Personal skills" table and adds a read-only "From your organizations" section, whose description says members get the skills shared with them, and site owners, organization admins and auditors get every enabled skill. It shows one SkillsTable per organization the user belongs to (filtered by user.organization_ids, because chats only run in member organizations), with readOnlySkillAccess and only enabled skills; rows offer Download and View. An organization still loading shows the table's loading rows; a loaded one with no enabled skills is left out.
The page picks tables from a useQueries fetch of each list. A failed list with no enabled skills shows that organization's heading with an ErrorAlert and a Retry button named "Retry loading skills" instead of the table, because the table would refetch the failed list on mount and clear its error. SkillsTable gains optional enabledOnly and headerLevel.
Accepted tradeoffs: the read-only tables still show the Enabled column, each table refetches its list once after the page query loads, and the read-only copy passes empty emptyDescription/editorDescription, which those tables never render.
Testing
- New
AgentSettingsSkillsPage.test.tsx: with two readable organizations and membership in one, only the member one renders and the other list is never requested (fails without the membership filter); a failed list retried through its named Retry button loads from a second request (fails without the refetch). New router.test.tsx: the old path ends at /agents/settings/skills (fails if the redirect is replaced with the page).
- New stories for shown, hidden and error states (screenshots checked), plus
OrganizationSkillsLoading. pnpm lint, vitest under src/pages/AgentsPage, and the touched stories passed.
Review record
frontend-review passed after a page test asserting rendered tables was removed under FE1 (stories cover those states). coder-frontend-review fixed fixtures (RO1, TS3), story wiring (TS6), the error story (TS7), the router test (TS2) and a type (TN3). Declined: optional copy fields (TN2), which would spread into SkillEditor and SkillsTableView; restoring a story query helper (RO3), which conflicts with TS6.
- Remote UAT round 6 through Coder Agents: PASS on the final stack tip
afdd4a9f954 (chat); its low notes are in docs(docs/ai-coder/agents): document organization skills #30604.
- UAT fixes: round 2 made the section description name the roles that get every enabled organization skill. Round 4 limited the section to member organizations, as above, so site owners and site auditors no longer see or fetch other organizations' skills, and the description now says "auditors", which covers site-wide auditors.
- Codex round 1: fixed in 6f5ce5d, loading organizations show loading rows, Retry buttons name their organization, and a test covers Retry.
- coder-frontend-review of the Codex fixes: fixed TS1 (98f151a).
This stack adds organization skills to Coder Agents: admins publish a skill once per organization, share it with groups or members, and chats in that organization load it next to personal and workspace skills.
Stack, bottom to top: #30584, #30585, #30586, #30587, #30588, #30589, #30590, #30591, #30592, #30593, #30594, #30595, #30596, #30597, #30598, #30599, #30600, #30601, #30602, #30603, #30604.
Xum opened this PR on behalf of @ibetitsmike.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chatgpt-codex-connector[bot] reacted with thumbs up emoji
This was referenced Oct 10, 2026
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f563c3964
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codex Review Summary
This comment shows the latest Codex review activity on this pull request.
| Review |
Status |
Commit |
Review trigger |
| 📝 Code Review |
✅ Completed 2026-10-10T06:08:37.489400Z |
21e1e78 |
Manual request |
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review" or "@codex security review".
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…etry buttons on the member skills page
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. What shall we delve into next?
Reviewed commit: 204760c086
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Codex Review: Didn't find any major issues. Delightful!
Reviewed commit: 21e1e789a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|