GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121489: Export private _PyBytes_Join() again by cdce8p · Pull Request #122094 · python/cpython

Conversation

@cdce8p

@cdce8p cdce8p commented Jul 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Followup from #121489 and #121646 (comment). Export the _PyBytes_Join() again until the new public PyBytes_Join() is added. If backported to 3.13, this would make transitioning easier.

This partially reverts #107144.

/CC @vstinner

  • Issue: [C API] Private functions used by mypyc #121489

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
encukou and others added 30 commits June 26, 2024 11:36
@encukou
pythongh-73991: Skip permission test if running as *nix superuser (py…
9056597
…thonGH-120994)
@nohlson
pythongh-121040: Remove fallthrough warnings compiler option (pythong…
ef28f6d
…h-121041)

Remove fallthrough warnings
@devdanzin
pythongh-121016: Add test for PYTHON_BASIC_REPL envioronment variab…
9e45fd9
…le (python#121017)
@vstinner
pythongh-120642: Move private PyCode APIs to the internal C API (pyth…
9e4a81f
…on#120643)

* Move _Py_CODEUNIT and related functions to pycore_code.h.
* Move _Py_BackoffCounter to pycore_backoff.h.
* Move Include/cpython/optimizer.h content to pycore_optimizer.h.
* Remove Include/cpython/optimizer.h.
* Remove PyUnstable_Replace_Executor().

Rename functions:

* PyUnstable_GetExecutor() => _Py_GetExecutor()
* PyUnstable_GetOptimizer() => _Py_GetOptimizer()
* PyUnstable_SetOptimizer() => _Py_SetTier2Optimizer()
* PyUnstable_Optimizer_NewCounter() => _PyOptimizer_NewCounter()
* PyUnstable_Optimizer_NewUOpOptimizer() => _PyOptimizer_NewUOpOptimizer()
@iritkatriel
pythongh-119786: move frames documentation to InternalDocs and add de…
c878767
…tails (python#121009)
@vstinner
pythongh-121008: Fix idlelib.run tests (python#121046)
44eafd6
When testing IDLE, don't create a Tk to avoid side effects such as
installing a PyOS_InputHook hook.
@vstinner
pythongh-120593: Fix const qualifier in pyatomic.h (python#121055)
9cd2dcb
@vstinner
pythongh-120593: Fix const qualifier in _PyLong_CompactValue() (pytho…
e51e880
…n#121053)

Remove the const qualifier of the argument of functions:

* _PyLong_IsCompact()
* _PyLong_CompactValue()

Py_TYPE() argument is not const.

Fix the compiler warning:

  Include/cpython/longintrepr.h: In function ‘_PyLong_CompactValue’:
  Include/pyport.h:19:31: error: cast discards ‘const’ qualifier from
  pointer target type [-Werror=cast-qual]
    (...)
  Include/cpython/longintrepr.h:133:30: note: in expansion of macro
  ‘Py_TYPE’
    assert(PyType_HasFeature(Py_TYPE(op), Py_TPFLAGS_LONG_SUBCLASS));
@ambv
pythongh-118908: Use __main__ for the default PyREPL namespace (pytho…
d611c4c
…n#121054)
@Fidget-Spinner @markshannon
pythongh-117139: Convert the evaluation stack to stack refs (python#1…
22b0de2
…18450)

This PR sets up tagged pointers for CPython.

The general idea is to create a separate struct _PyStackRef for everything on the evaluation stack to store the bits. This forces the C compiler to warn us if we try to cast things or pull things out of the struct directly.

Only for free threading: We tag the low bit if something is deferred - that means we skip incref and decref operations on it. This behavior may change in the future if Mark's plans to defer all objects in the interpreter loop pans out.

This implies a strict stack reference discipline is required. ALL incref and decref operations on stackrefs must use the stackref variants. It is unsafe to untag something then do normal incref/decref ops on it.

The new incref and decref variants are called dup and close. They mimic a "handle" API operating on these stackrefs.

Please read Include/internal/pycore_stackref.h for more information!

---------

Co-authored-by: Mark Shannon <[email protected]>
@chaen @hugovk
pythongh-120937: Reference weakref from the __del__ documentation (p…
1c13b29
…ython#120940)

Co-authored-by: Hugo van Kemenade <[email protected]>
@ericsnowcurrently
pythongh-113433: Automatically Clean Up Subinterpreters in Py_Finaliz…
4be1f37
…e() (pythongh-121060)

This change makes things a little less painful for some users.  It also fixes a failing assert (pythongh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.
@provinzkraut
pythongh-120868: Fix breaking change in logging.config when using `…
7d9c685
…QueueHandler` (pythonGH-120872)
@encukou
pythongh-119521: Remove _IncompleteInputError from the docs (pythonGH…
1167a9a
…-120993)
@pradyunsg @blurb-it
@hugovk @ncoghlan @Yhg1s
pythongh-120888: Bump bundled pip to 24.1.1 (python#120889)
4999e0b
Co-authored-by: Pradyun Gedam <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
Co-authored-by: T. Wouters <[email protected]>
@vstinner @sobolevn
pythongh-121040: Use __attribute__((fallthrough)) (python#121044)
12af8ec
Fix warnings when using -Wimplicit-fallthrough compiler flag.

Annotate explicitly "fall through" switch cases with a new
_Py_FALLTHROUGH macro which uses __attribute__((fallthrough)) if
available. Replace "fall through" comments with _Py_FALLTHROUGH.

Add _Py__has_attribute() macro. No longer define __has_attribute()
macro if it's not defined. Move also _Py__has_builtin() at the top
of pyport.h.

Co-Authored-By: Nikita Sobolev <[email protected]>
@iritkatriel
pythongh-120686: remove unused internal c api functions (python#120687)
6f7acaa
@vstinner
pythongh-120593: Check -Wcast-qual flag in test_cext (python#121081)
b7a95df
Check the usage of the 'const' qualifier in the Python C API in
test_cext.
@Zheaoli @Fidget-Spinner
pythongh-121082: Fix build failure when the developer use `--enable-p…
223c03a
…ystats` arguments in configuration command after python#118450 (python#121083)



Signed-off-by: Manjusaka <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
@serhiy-storchaka
pythongh-121027: Add a future warning in functools.partial.__get__ (p…
db96edd
…ython#121086)
@Privat33r-dev @hugovk
pythongh-115986 Improve pprint docs formatting (pythonGH-117401)
0890ad7
* Move pprinter parameters description to the table

The change improves readability.
Suggested in the GH#116085 PR discussion.

* Make pprint doc with params markup

* Fix formatting
Indentation of code blocks made them nested
"Version changed" is better placed after the code block

* Fix formatting for tests

* fix code indentation for autotests

* Fix identation for autotests

* Remove duplication of the parameters' description

* Rearrange parameters description in a correct order

---------

Co-authored-by: Hugo van Kemenade <[email protected]>
@zhatt @arhadthedev
pythongh-105623 Fix performance degradation in logging RotatingFileHa…
e9b4ec6
…ndler (pythonGH-105887)

The check for whether the log file is a real file is expensive on NFS
filesystems.  This commit reorders the rollover condition checking to
not do the file type check if the expected file size is less than the
rotation threshold.

Co-authored-by: Oleg Iarygin <[email protected]>
@colesbury
pythongh-121065: Temporarily skip flaky test on free-threaded build (p…
4a62a33
…ython#121100)
@bessman
pythongh-121035: Update logging flow chart to include the lastResort …
237baf4
…handler. (pythonGH-121036)
@corona10
pythongh-120837: Update _Py_DumpExtensionModules to be async-signal-s…
1a2e7a7
…afe (pythongh-121051)
@kumaraditya303
pythongh-107803: add whatsnew for asyncio double linked list implemen…
58a3580
…tation (python#120995)
@vstinner
pythongh-121096: Ignore dlopen() leaks in Valgrind suppression file (p…
6e63d84
…ython#121097)
@kumaraditya303
pythongh-120804: remove is_active method from internal child watche…
ef3c400
…rs implementation in asyncio (python#121124)
@vstinner
Check for compiler warnings in test_cext on Windows (python#121088)
43709d5
On Windows, test_cext and test_cppext now pass /WX flag to the MSC
compiler to treat all compiler warnings as errors. In verbose mode,
these tests now log the compiler commands to help debugging.

Change Py_BUILD_ASSERT_EXPR implementation on Windows to avoid a
compiler warning about an unnamed structure.
@serhiy-storchaka
pythongh-121018: Fix more cases of exiting in argparse when exit_on_e…
81a654a
…rror=False (pythonGH-121056)

* parse_intermixed_args() now raises ArgumentError instead of calling
  error() if exit_on_error is false.
* Internal code now always raises ArgumentError instead of calling
  error(). It is then caught at the higher level and error() is called if
  exit_on_error is true.
@cdce8p
cdce8p requested review from 1st1, asvetlov, ezio-melotti, gvanrossum, hugovk and willingc as code owners July 25, 2024 09:04
@cdce8p cdce8p closed this Jul 25, 2024
@hugovk
hugovk removed request for a team, 1st1, abalkin, asvetlov, barneygale, berkerpeksag, brettcannon, cjw296, ericsnowcurrently, ericvsmith, freakboy3742, gpshead, hugovk, iritkatriel, jaraco, methane, ncoghlan, pfmoore, tiran, vsajip and warsaw July 25, 2024 09:06
@encukou

encukou commented Jul 25, 2024

Copy link
Copy Markdown
Member

Oh, I meant the usual process of merging to main first, and then backporting to 3.13. Merging only into 3.13 would be highly irregular.
Sorry for not being clear.

cdce8p reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

19 participants

@cdce8p @encukou @devdanzin @GoLinuxCloud1 @nohlson @vstinner @iritkatriel @ambv @Fidget-Spinner @chaen @ericsnowcurrently @provinzkraut @pradyunsg @Zheaoli @serhiy-storchaka @Privat33r-dev @zhatt @colesbury @bessman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.