GeezerVison is showing github.com — gh-119517: Fixes for pasting in pyrepl by godlygeek · Pull Request #120251 · python/cpython
Conversation
godlygeek
commented
Jun 7, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Drastically improve the performance of pyrepl when pasting large amounts of text.
CC: @pablogsal
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…uentially (pythonGH-118864) (python#118927)
The free-threaded build currently immortalizes some objects once the
first thread is started. This can lead to test failures depending on the
order in which tests are run. This PR addresses those failures by
suppressing immortalization or skipping the affected tests.
(cherry picked from commit b309c8e)
Co-authored-by: Sam Gross <[email protected]>
…ve them (pythonGH-118747) (python#118931)
This ensures we don't lose races that occur in subprocesses or
interleave races from workers running in parallel.
Log files are collected and packaged into a zipfile that can be
downloaded from the "Artifacts" section of the workflow run.
(cherry picked from commit b88889e)
Co-authored-by: mpage <[email protected]>
…nGH-118880)
Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
(cherry picked from commit d8a82cc)
Co-authored-by: I-Shen Leong <[email protected]>
I honestly forgot this slipped into 3.13, but I think it's worth highlighting more, as it is a PEP-sized change that makes the type system significantly more powerful.
@Yhg1s I think it's also worth mentioning in your release announcements.
(cherry picked from commit ee13797)
Co-authored-by: Jelle Zijlstra <[email protected]>
|
Well hm, that's not what I meant to do. I'm just gonna try that again... 😓
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hugovk
removed request for
a team,
1st1,
ambv,
asvetlov,
berkerpeksag,
brettcannon,
carljm,
encukou,
ericvsmith,
freakboy3742,
gpshead,
jaraco,
methane,
tiran,
vsajip and
warsaw
June 8, 2024 05:18
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
godlygeek
commented
Jun 8, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Don't worry about it, but please don't rebase and force push.
Ah, the thing I tried to do that failed horribly wasn't a rebase, it was retargetting the PR to main instead of 3.13 via the GitHub UI - I picked the wrong branch when creating the PR, but because I had based the change on the 3.13 branch, GitHub decided I wanted to merge all of the commits since 3.13 branched off into main. (Ok, I guess that is a rebase, I just didn't realize it was one when I clicked the button, heh.)
so no need to tidy your commits
I realize there will be a squash merge, but tidying the commits makes reviews much easier. Is force pushing before the PR has been reviewed still frowned upon? Or force pushing to draft PRs? It seems wasteful to make reviewers review known buggy commits for problems that CI catches if I can instead fix those problems before anyone ever looks at it.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
it was retargetting the PR to main instead of 3.13 via the GitHub UI
Yep, that'll reliably do it and ping every codeowner too 🙃 We'd disable that option if possible.
Is force pushing before the PR has been reviewed still frowned upon?
My main problem with force pushes is the notification takes you to an empty diff, so it costs an extra click to go to the main PR page, and it's not obvious to see what changed from the last time I checked.
Or force pushing to draft PRs? It seems wasteful to make reviewers review known buggy commits for problems that CI catches if I can instead fix those problems before anyone ever looks at it.
I feel like marking a PR as draft is enough of a signal to say it's not ready for review yet, but an explicit comment can help.
I'm not sure how often people review commit-by-commit compared to the whole diff, so I wouldn't worry about small new commits that fix earlier ones.
|
godlygeek reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|