GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119517: Fixes for pasting in pyrepl by godlygeek · Pull Request #120251 · python/cpython

Conversation

@godlygeek

@godlygeek godlygeek commented Jun 7, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Drastically improve the performance of pyrepl when pasting large amounts of text.

CC: @pablogsal

  • Issue: Odd behavior from pasting large text in the new REPL #119517

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
miss-islington and others added 30 commits May 10, 2024 20:50
@miss-islington @colesbury
[3.13] pythongh-118846: Fix free-threading test failures when run seq…
cceb758
…uentially (pythonGH-118864) (python#118927)

The free-threaded build currently immortalizes some objects once the
first thread is started. This can lead to test failures depending on the
order in which tests are run. This PR addresses those failures by
suppressing immortalization or skipping the affected tests.
(cherry picked from commit b309c8e)

Co-authored-by: Sam Gross <[email protected]>
@miss-islington @mpage
[3.13] pythongh-117657: Log TSAN warnings to separate files and archi…
7dc9e92
…ve them (pythonGH-118747) (python#118931)

This ensures we don't lose races that occur in subprocesses or
interleave races from workers running in parallel.

Log files are collected and packaged into a zipfile that can be
downloaded from the "Artifacts" section of the workflow run.
(cherry picked from commit b88889e)

Co-authored-by: mpage <[email protected]>
@miss-islington @gaogaotiantian
[3.13] pythongh-118921: Add copy() method for FrameLocalsProxy (p…
93ef7aa
…ythonGH-118923) (python#118933)

(cherry picked from commit 35c4361)

Co-authored-by: Tian Gao <[email protected]>
@miss-islington @nineteendo
[3.13] pythongh-117655: Prevent test_strptime from raising a Deprec…
d309474
…ationWarning (pythonGH-117668) (pythonGH-118956)

pythongh-117655: Prevent `test_strptime` from raising a DeprecationWarning (pythonGH-117668)

* Fix `test_strptime` raises a DeprecationWarning
* Ignore deprecation warnings where appropriate.
* Update Lib/test/datetimetester.py

This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added.
(cherry picked from commit abead54)

Co-authored-by: Nice Zombies <[email protected]>
@miss-islington @sobolevn
[3.13] pythongh-118899: Add tests for NotImplemented attribute acce…
6e855b3
…ss (pythonGH-118902) (python#118968)

pythongh-118899: Add tests for `NotImplemented` attribute access (pythonGH-118902)
(cherry picked from commit ec1398e)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington @savannahostrowski
[3.13] pythonGH-118844: Fix build failures when combining --disable-g…
9d2c10b
…il with --enable-experimental-jit (pythonGH-118959)

(cherry picked from commit 5b941e5)

Co-authored-by: Savannah Ostrowski <[email protected]>
@miss-islington @jacobtylerwalls
[3.13] pythongh-87106: Fix inspect.signature.bind() handling of posit…
a8ea966
…ional-only arguments with **kwargs (pythonGH-103404) (python#118985)

(cherry picked from commit 9c15202)

Co-authored-by: Jacob Walls <[email protected]>
@miss-islington @sobolevn
[3.13] Improve the rmtree doc for dir_fd param addition in 3.11 (p…
9418832
…ythonGH-118964) (python#118991)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington @i-shenl
pythongh-118876: Ensure PC/layout sets ns.temp before using it (pytho…
44995aa
…nGH-118880)

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
(cherry picked from commit d8a82cc)

Co-authored-by: I-Shen Leong <[email protected]>
@miss-islington @gaogaotiantian
[3.13] pythongh-58933: Make pdb return to caller frame correctly when…
09d4c07
… f_trace is not set (pythonGH-118979) (python#119007)

pythongh-58933: Make pdb return to caller frame correctly when f_trace is not set (pythonGH-118979)
(cherry picked from commit f526314)

Co-authored-by: Tian Gao <[email protected]>
@miss-islington @sobolevn @JelleZijlstra
[3.13] pythongh-119010: Adds docs about __type_params__ to `functoo…
d1aac22
…ls.update_wrapper` (pythonGH-119012) (python#119013)

pythongh-119010: Adds docs about `__type_params__` to `functools.update_wrapper` (pythonGH-119012)
(cherry picked from commit b04c497)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@miss-islington @sobolevn
[3.13] pythongh-118998: Handle errors correctly in tmtotuple in `ti…
c7628b0
…memodule` (pythonGH-118999) (python#119018)

pythongh-118998: Handle errors correctly in `tmtotuple` in `timemodule` (pythonGH-118999)
(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington @mgorny
[3.13] pythonGH-118836: Fix JIT build error when SHT_NOTE section is …
29a2f9c
…present (pythonGH-119020)

(cherry picked from commit e04cd96)

Co-authored-by: Michał Górny <[email protected]>
@miss-islington @serhiy-storchaka
[3.13] pythongh-67693: Fix urlunparse() and urlunsplit() for URIs wit…
8720006
…h path starting with multiple slashes and no authority (pythonGH-113563) (pythonGH-119023)

(cherry picked from commit e237b25)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @serhiy-storchaka
[3.13] Add yet few cases for urlparse/urlunparse roundtrip tests (pyt…
54839f0
…honGH-119031) (pythonGH-119037)

(cherry picked from commit 331d385)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @AlexWaygood
[3.13] typing tests: remove some unnecessary uses of exec() (python…
041cc2a
…GH-119005) (python#119038)


(cherry picked from commit a9328e2)

Co-authored-by: Alex Waygood <[email protected]>
@miss-islington
[3.13] Itertools docs: fix parameter names and indentation in Python …
87f683e
…equivalents (pythongh-118977) (python#119043)
@miss-islington
[3.13] Misc improvements to the itertools docs (pythongh-119040) (pyt…
8439d09
…hon#119045)
@miss-islington @JelleZijlstra
[3.13] 3.13 What's New: Add PEP 702 (pythonGH-118922) (python#119062)
dd8a61f
I honestly forgot this slipped into 3.13, but I think it's worth highlighting more, as it is a PEP-sized change that makes the type system significantly more powerful.

@Yhg1s I think it's also worth mentioning in your release announcements.
(cherry picked from commit ee13797)

Co-authored-by: Jelle Zijlstra <[email protected]>
@miss-islington @zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
e1dfa97
…pythonGH-119056)

(cherry picked from commit 94591dc)

Co-authored-by: Steve Dower <[email protected]>
@miss-islington @graingert
[3.13] Remove references to private symbols from zipimport module doc…
f85d59c
…string (pythonGH-119071)

(cherry picked from commit 7d722b7)

Co-authored-by: Thomas Grainger <[email protected]>
@miss-islington @serhiy-storchaka
[3.13] pythongh-118760: Fix errors in calling Tkinter bindings on Win…
4f81915
…dows (pythonGH-118782) (pythonGH-119072)

For unknown reasons some arguments for Tkinter binding can be created
as a 1-tuple containing a Tcl_Obj when wantobjects is 2.
(cherry picked from commit 5b88d95)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @rffontenelle
[3.13] pythongh-119009: Add gettext target (pythonGH-119006) (python#…
7c224dd
…119074)

Co-authored-by: Rafael Fontenelle <[email protected]>
@miss-islington @rffontenelle
[3.13] Use literal syntax in origin property (pythonGH-119029) (pytho…
bca7fb0
…n#119083)

Use literal syntax in origin property (pythonGH-119029)
(cherry picked from commit 66b73e9)

Co-authored-by: Rafael Fontenelle <[email protected]>
@miss-islington @serhiy-storchaka
[3.13] pythongh-119064: Use os_helper.FakePath instead of pathlib.Pat…
1dc7fcd
…h in tests (pythonGH-119065) (pythonGH-119087)

(cherry picked from commit 0152dc4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @serhiy-storchaka
[3.13] Add Tkinter tests for different events (pythonGH-118778) (pyth…
8a4730e
…onGH-119091)

(cherry picked from commit b683994)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington @hauntsaninja
[3.13] pythongh-108267: Fix object.__setattr__ regression in dataclas…
c69fe80
…ses docs (pythonGH-119082) (python#119097)

Co-authored-by: Shantanu <[email protected]>
@miss-islington @hroncok @erlend-aasland
[3.13] Explain how to install LLVM on Fedora (pythonGH-119100)
45fbca9
(cherry picked from commit ab73bcd)
Co-authored-by: Miro Hrončok <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@miss-islington
[3.13] pythonGH-118943: Fix a race condition when generating jit_sten…
acffe20
…cils.h (pythonGH-119101)

(cherry picked from commit 4702b7b)
@miss-islington @xyb @AlexWaygood
[3.13] Fix typos in documentation (pythonGH-119092) (python#119116)
ada4ad0
Fix typos in documentation (pythonGH-119092)
(cherry picked from commit 65de194)

Co-authored-by: Xie Yanbo <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@godlygeek
godlygeek requested review from 1st1, asvetlov, brandtbucher, ezio-melotti, gvanrossum, hugovk and willingc as code owners June 8, 2024 02:59
@godlygeek

godlygeek commented Jun 8, 2024

Copy link
Copy Markdown
Contributor Author

Well hm, that's not what I meant to do. I'm just gonna try that again... 😓

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@godlygeek godlygeek closed this Jun 8, 2024
@godlygeek godlygeek mentioned this pull request Jun 8, 2024
gh-119517: Fixes for pasting in pyrepl #120253
Merged
@hugovk
hugovk removed request for a team, 1st1, ambv, asvetlov, berkerpeksag, brettcannon, carljm, encukou, ericvsmith, freakboy3742, gpshead, jaraco, methane, tiran, vsajip and warsaw June 8, 2024 05:18
@hugovk

hugovk commented Jun 8, 2024

Copy link
Copy Markdown
Member

Well hm, that's not what I meant to do. I'm just gonna try that again... 😓

Don't worry about it, but please don't rebase and force push.

If to want to update from main, merge it in. And everything is squash merged at the end, so no need to tidy your commits.

https://devguide.python.org/getting-started/pull-request-lifecycle/#quick-guide

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@godlygeek

godlygeek commented Jun 8, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Don't worry about it, but please don't rebase and force push.

Ah, the thing I tried to do that failed horribly wasn't a rebase, it was retargetting the PR to main instead of 3.13 via the GitHub UI - I picked the wrong branch when creating the PR, but because I had based the change on the 3.13 branch, GitHub decided I wanted to merge all of the commits since 3.13 branched off into main. (Ok, I guess that is a rebase, I just didn't realize it was one when I clicked the button, heh.)

so no need to tidy your commits

I realize there will be a squash merge, but tidying the commits makes reviews much easier. Is force pushing before the PR has been reviewed still frowned upon? Or force pushing to draft PRs? It seems wasteful to make reviewers review known buggy commits for problems that CI catches if I can instead fix those problems before anyone ever looks at it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Jun 8, 2024

Copy link
Copy Markdown
Member

it was retargetting the PR to main instead of 3.13 via the GitHub UI

Yep, that'll reliably do it and ping every codeowner too 🙃 We'd disable that option if possible.

Is force pushing before the PR has been reviewed still frowned upon?

My main problem with force pushes is the notification takes you to an empty diff, so it costs an extra click to go to the main PR page, and it's not obvious to see what changed from the last time I checked.

Or force pushing to draft PRs? It seems wasteful to make reviewers review known buggy commits for problems that CI catches if I can instead fix those problems before anyone ever looks at it.

I feel like marking a PR as draft is enough of a signal to say it's not ready for review yet, but an explicit comment can help.

I'm not sure how often people review commit-by-commit compared to the whole diff, so I wouldn't worry about small new commits that fix earlier ones.

godlygeek reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

13 participants

@godlygeek @hugovk @miss-islington @lysnikolaou @vstinner @rhettinger @ericsnowcurrently @JelleZijlstra @barneygale @colesbury @Yhg1s @ambv @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.