GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34541: pathlib.Path.iterdir throw an exception when path is not valid by prudvinit · Pull Request #8996 · python/cpython

Conversation

@prudvinit

@prudvinit prudvinit commented Aug 29, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

https://bugs.python.org/issue34541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
miss-islington and others added 30 commits June 18, 2018 14:37
@miss-islington @ValeriyaSinevich
bpo-33663: Convert content length to string before putting to header (p…
53d1e9f
…ythonGH-7754)

(cherry picked from commit b36b0a3)

Co-authored-by: ValeriyaSinevich <[email protected]>
@miss-islington @lethliel
bpo-33365: print the header values beside the keys (pythonGH-6611)
2edcf0a
with debuglevel=1 only the header keys got printed. With
this change the header values get printed as well and the single
header entries get '\n' as a separator.
(cherry picked from commit 936f03e)

Co-authored-by: Marco Strigl <[email protected]>
@vstinner
bpo-33901: Fix test_dbm_gnu for gdbm 1.15 (pythonGH-7798)
13c79c6
Fix test_dbm_gnu.test_reorganize() on macOS with gdbm 1.15: add a
larger value to make sure that the file size changes.
@zhangyangyu
set terse to True when calling platform.platform in test.pythoninfo (p…
71ca738
…ythonGH-7797)
@miss-islington @terryjreedy
bpo-33855: Still more edits and minimal tests for IDLE (pythonGH-7784)
cbaee6f
Part 3 of 3, continuing PR pythonGH-7689. This covers 14 idlelib modules and their tests,
rpc to zoomheight except for run (already done) and tooltip (being done separately).
(cherry picked from commit 4d92158)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @terryjreedy
bpo-33907: Rename an IDLE module and class. (pythonGH-7807)
b89a376
Improve consistency and appearance. Module idlelib.calltips is now calltip.
Class idlelib.calltip_w.CallTip is now Calltip.
(cherry picked from commit 06e2029)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @terryjreedy
bpo-33907: Rename an IDLE module and classes. (pythonGH-7810)
ce52f5e
Fix-up class name duplication in PR pythonGH-7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
(cherry picked from commit 9af1836)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @vstinner
bpo-33746: Fix test_unittest.testRegisterResult() in verbose mode (py…
232add0
…thonGH-7799)

Only make sure that the result is in unittest.signals._results, don't
check the full content of unittest.signals._results.

support._run_suite() uses TextTestRunner in verbose mode, but
TextTestRunner.run() calls registerResult(result) which made the test
fail with "odd object in result set".

Call also removeResult() to restore unittest.signals._results to
avoid test side effect.
(cherry picked from commit fd8fbce)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington @srinivasreddy
bpo-33904: In IDLE's rstrip, rename class RstripExtension as Rstrip (p…
b0f3526
…ythonGH-7811)

(cherry picked from commit 9bb9223)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@miss-islington @terryjreedy
bpo-33917: Fix and document idlelib/idle_test/template.py (pythonGH-7830
a717c56
)

The revised file compiles, runs, and tests OK. idle_test/README.txt
explains how to use it to create new IDLE test files.
(cherry picked from commit 87a9273)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @terryjreedy
bpo-33906: Rename idlelib.windows as window (pythonGH-7833)
f9243a2
Match Window on the main menu and remove last plural module name.
Change imports, test, and attribute references to match new name.
(cherry picked from commit a361e89)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @terryjreedy
bpo-33924: Change IDLE mainmenu.menudefs key 'windows' to 'window' (p…
e1f0dce
…ythonGH-7836)

Every other menudef key is the lowercase version of the
corresponding main menu entry (in this case, 'Window').
(cherry picked from commit 33c7420)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @srinivasreddy @ericvsmith
Clarified the tempfile.tempdir documentation (pythonGH-7829) (pythonG…
fee52e3
…H-7841)

(cherry picked from commit 940ae60)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
@miss-islington @terryjreedy
bpo-33905: Add test for idlelib.stackview.StackBrowser. (pythonGH-7852)
d554414
Increases coverage by 44%.
(cherry picked from commit bcd3a1a)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @vstinner
bpo-30345: Add -g to LDFLAGS for LTO (pythonGH-7709) (pythonGH-7824)
1bb9dd3
Add -g to LDFLAGS when compiling with LTO to get debug symbols.
(cherry picked from commit 06fe77a)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington @vstinner
bpo-33932: Calling Py_Initialize() twice does nothing (pythonGH-7845)
3747dd1
Calling Py_Initialize() twice does nothing, instead of failing with a
fatal error: restore the Python 3.6 behaviour.
(cherry picked from commit 209abf7)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington @andresdelfino
bpo-33885: Replace "hook function" with "callable" (pythonGH-7765)
e4db730
(cherry picked from commit c45cb47)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington @andresdelfino
bpo-33877: Remove UNIX qualification for running complete programs (p…
f47d898
…ythonGH-7744)

The statement is true for Windows (and macOS) also.
(cherry picked from commit c9d43c7)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington @vstinner
bpo-33916: Fix bz2 and lzma init when called twice (pythonGH-7843)
efc6bf6
bz2, lzma: When Decompressor.__init__() is called twice, free the old
lock to not leak memory.
(cherry picked from commit 9b7cf75)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington @corona10
bpo-33805: Improve error message of dataclasses.replace() (pythonGH-7580
bbef7ab
)

(cherry picked from commit 3d70f7a)

Co-authored-by: Dong-hee Na <[email protected]>
@miss-islington @andresdelfino
bpo-33887: Add TOC to Design and History FAQ(pythonGH-7766)
070c91e
(cherry picked from commit 38cf49b)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington @terryjreedy
bpo-33950: Remove IDLE htest spec for a deleted file. (pythonGH-7881)
6b7ed31
In configdialog, the custom tabbedpages widget was replaced
by ttk.notebook several months ago.
(cherry picked from commit 5ae70f6)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington @ZackerySpytz
bpo-33451: Close pyc files before calling PyEval_EvalCode() (pythonGH…
56aaef0
…-7884)

Directly executed pyc files were being kept open longer than necessary.
(cherry picked from commit ea73775)

Co-authored-by: Zackery Spytz <[email protected]>
@miss-islington @zware
Enable GUI tests in VSTS Linux builds via xvfb-run (pythonGH-7890)
d2a9c2e
(cherry picked from commit 3f197f9)

Co-authored-by: Zachary Ware <[email protected]>
@miss-islington @taleinat
bpo-33951: IDLE test_configdialog: call page.update in setUpClass (py…
b3bac96
…thonGH-7892)

This avoids a failure in at least one case when running only a single
test method rather than all tests in the module.

The issue came up when testing the following on Windows 10 Pro 64-bit:
HighPageTest.test_highlight_target_text_mouse
(cherry picked from commit 2af9f5d)

Co-authored-by: Tal Einat <[email protected]>
@miss-islington @andresdelfino @taleinat
bpo-33943: Add references in the docs for logging.basicConfig (python…
66d77d8
…GH-7858) (pythonGH-7900)

Adds references to info about file modes, `time.strftime()`, string formatting
syntaxes, and logging levels.

(cherry picked from commit a8ddf85)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington @andresdelfino @taleinat
bpo-33952: Fix typo in str.upper() documentation (pythonGH-7898) (pyt…
80f1a90
…honGH-7903)

(cherry picked from commit 4a6e746)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington @taleinat
[3.7] bpo-33573: docs to suggest median() alternatives for non-numeri…
150cd3c
…c data (pythonGH-7587) (pythonGH-7906)

(cherry picked from commit fdd6e0b)
@miss-islington @roseman
bpo-33924: Add missed mac-specific 'windows' to 'window' changes (pyt…
ee60e36
…honGH-7920)

These should have been included in PR 7836.
(cherry picked from commit 4239773)

Co-authored-by: Mark Roseman <[email protected]>
@miss-islington @srinivasreddy
bpo-33957: Doc: Use better wording (pythonGH-7912)
829b766
(cherry picked from commit 866c168)

Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <[email protected]>
miss-islington and others added 12 commits August 17, 2018 06:02
@miss-islington @srittau
bpo-34418: Fix HTTPErrorProcessor documentation (pythonGH-8793)
05d89ef
The http_response() and https_response() methods of the HTTPErrorProcessor
class have two required parameters, 'request' and 'response'.
(cherry picked from commit c53aaec)

Co-authored-by: Sebastian Rittau <[email protected]>
@miss-islington @michael-o
bpo-34381: refer to 'Running & Writing Tests' in README.rst (pythonGH…
eeece3c
…-8797)

(cherry picked from commit cae8ff9)

Co-authored-by: Michael Osipov <[email protected]>
@miss-islington @andresdelfino @ericvsmith
bpo-34432: doc Mention complex and decimal.Decimal on str.format note…
0fd6f83
… about locales (pythonGH-8808) (pythonGH-8809)

(cherry picked from commit 93b5655)

Co-authored-by: Andrés Delfino <[email protected]>
@miss-islington @vsajip
bpo-34415: Updated logging.Formatter docstring. (pythonGH-8811) (pyth…
2e4ae8f
…onGH-8817)

(cherry picked from commit d3d3171)
@miss-islington @berkerpeksag
bpo-22057: Clarify eval() documentation (pythonGH-8812)
0e1e8db
If a globals dictionary without a '__builtins__' key is passed to
eval(), a '__builtins__' key will be inserted to the dictionary:

    >>> eval("print('__builtins__' in globals())", {})
    True

(As a result of this behavior, we can use the builtins
print() and globals() even if we passed a dictionary without a
'__builtins__' key to eval().)
(cherry picked from commit 225b055)

Co-authored-by: Berker Peksag <[email protected]>
@miss-islington @izbyshev
bpo-34435: Add missing NULL check to unicode_encode_ucs1(). (pythonGH…
1e596d3
…-8823)

Reported by Svace static analyzer.
(cherry picked from commit 74a307d)

Co-authored-by: Alexey Izbyshev <[email protected]>
@miss-islington @zhangyangyu
bpo-30411: Use --git-dir instead of -C to make git work under version…
2011dd7
… below 1.8.5. (pythonGH-8744)

(cherry picked from commit 4c85557)

Co-authored-by: Xiang Zhang <[email protected]>
@miss-islington Alexey Izbyshev
bpo-34441: Fix ABC.__subclasscheck__ crash on classes with invalid __…
d1f0ccc
…subclasses__ (pythonGH-8835)

The missing NULL check was reported by Svace static analyzer.
(cherry picked from commit cdbf50c)

Co-authored-by: Alexey Izbyshev <[email protected]>
@miss-islington @ZackerySpytz
bpo-34400: Fix more undefined behavior in parsetok.c (pythonGH-8833)
985dcd4
(cherry picked from commit 3e26e42)

Co-authored-by: Zackery Spytz <[email protected]>
@miss-islington Alexey Izbyshev
bpo-34456: pickle: Add missing NULL check to save_global(). (pythonGH…
3152bc3
…-8851)

Reported by Svace static analyzer.
(cherry picked from commit f8c06b0)

Co-authored-by: Alexey Izbyshev <[email protected]>
@miss-islington Alexey Izbyshev
bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_n…
b8e7319
…ame(). (pythonGH-8852)

Reported by Svace static analyzer.
(cherry picked from commit 28853a2)

Co-authored-by: Alexey Izbyshev <[email protected]>
maddala prudvi rajkumar
bpo-3451: pathlib.Path.iterdir throws an exception when path is not v…
7fccaac
…alid
@prudvinit
prudvinit requested review from a team, 1st1, asvetlov, ericvsmith, gpshead, gvanrossum, ilevkivskyi, ncoghlan, rhettinger, skrah and terryjreedy as code owners August 29, 2018 16:49
@prudvinit
prudvinit requested a review from a team August 29, 2018 16:49
@prudvinit
prudvinit requested a review from a team as a code owner August 29, 2018 16:49
@bedevere-bot bedevere-bot added the awaiting review label Aug 29, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 29, 2018
@prudvinit prudvinit closed this Aug 29, 2018
@prudvinit
prudvinit deleted the bpo-34541 branch August 29, 2018 16:50
@PaulPinterits PaulPinterits mannequin mentioned this pull request Apr 13, 2022
pathlib.Path.iterdir doesn't raise an exception until you start iterating #78722
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov
@ericvsmith ericvsmith Awaiting requested review from ericvsmith
@gpshead gpshead Awaiting requested review from gpshead
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@rhettinger rhettinger Awaiting requested review from rhettinger
@skrah skrah Awaiting requested review from skrah
@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

18 participants

@prudvinit @vstinner @asvetlov @MaximilianSP @the-knights-who-say-ni @bedevere-bot @miss-islington @zhangyangyu @ned-deily @chmarr @tirkarthi @JulienPalard @ammaraskar @corona10 @serhiy-storchaka @zware @terryjreedy @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.