GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Sync and bump release 4.7 to RC by DanielRosenwasser · Pull Request #49007 · microsoft/TypeScript

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented May 6, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sheetal Nandi (sheetalkamat) and others added 30 commits April 6, 2022 12:46
@sheetalkamat
Some refactoring for baselining for easy update (#48516)
3fd8a6e
* Some refactoring for baselining for easy update

* Set modified time in baseline

* Some renames per feedback
@ahejlsberg
Permit type alias variance annotations only for certain object types (#…
8f6e626
…48589)

* Permit type alias variance annotations only for certain object types

* Accept new baselines
@sheetalkamat
More refactoring of tsc baselines to help with easier updates (#48572)
4c6f25a
* Some refactoring of baselines

* Some refactoring of baselines
@Andarist
Add additional tests for intra expression inference (#48584)
702bc52
@weswigham
Ensure late painted statements are only transformed once, so inner su…
94d33ba
…bstitutions are consistently read (#48558)

* Ensure late painted statements are only transformed once, so inner substitutions are consistently read

* PR suggestion

* Fix lint
@weswigham
Preserve the distributivity of inlined conditional types in declarati…
4d2fb54
…on emit (#48592)
@rbuckton
Write more useful types in .types test outputs (#48578)
b975dfa
@jihndai
Do not reset control flow analysis on index signatures (#48427)
b18141b
* do not flag index signatures as a control flow container

* add tests and baselines
@sheetalkamat
Write version for baselining in buildinfo (#48602)
d8edd19
Also baseline buildinfo so its easier to detect mistakes
@weswigham
Fix semantic merge conflict
ca96d2e
@Zzzen
preserve this when extracting functions (#41992)
f4b99ea
* preserve this when extracting functions

* rename IsThisReferringToFunction to UsesThisInFunction

* refactor

* update tests
@lowr
disentangle the meaning of SymbolLinks.target (#47098)
b45cf0d
@csigs
LEGO: Merge pull request 48612
b1fb729
LEGO: Merge pull request 48612
@a-tarasyuk
fix(48487): allow using private names as the self-assignment entity n…
3b2fa50
…ame (#48496)
@weswigham
Update release-branch-artifact.yaml
1df8073
12 -> 14 (we have odd test errors on 12 that aren't worth debugging)
@weswigham
Update new-release-branch.yaml
ee82068
12 -> 14
@weswigham
Update accept-baselines-fix-lints.yaml
8e44746
12 -> 14
@weswigham
Update ci.yml
a33e7ac
Update node versions
@weswigham
Update nightly.yaml
b246dee
@weswigham
Update set-version.yaml
6bcc53b
@weswigham
Update sync-branch.yaml
76e6e46
@weswigham
Update update-lkg.yml
5e721d9
12 -> 14
@weswigham
Update update-package-lock.yaml
f30ce1f
12 -> 14
@weswigham
Fix semantic merge conflict
12c4ea8
@andrewbranch
Reuse type nodes from optional parameters even when not written as a …
af3e1d4
…union with `undefined` (#48605)

* Reuse type nodes from optional parameters and properties even when not written as a union with `undefined`

* Remove newly unneeded NodeBuilderFlag

* Update public API

* Update baselines from main
@csigs
LEGO: Merge pull request 48621
b797a3e
LEGO: Merge pull request 48621
@ahejlsberg
Explore fewer constraints in getResolvedBaseConstraint (#48613)
a744862
@csigs
LEGO: Merge pull request 48633
f81f63f
LEGO: Merge pull request 48633
@gabritto
don't have type annotations on suggested object literal methods (#48607)
dfb9f2f
@jablko
Don't skip tests named *Fourslash.ts (#48615)
c1db699
Mateusz Burzyński (Andarist) and others added 23 commits May 4, 2022 08:23
@Andarist
Run mocha using process.execPath instead of harcoding "node" (#…
d337cbc
…48797)
@andrewbranch
Don’t let other completions shadow type keywords in type locations (#…
d879880
…48939)

* Allow type keywords with the same names as other completions

* Only add type keywords that are the same as other completions in type locations
@sheetalkamat
When source file is redirected, set the prototype correctly in node f…
c8ec855
…actory (#48862)

Fixes #48039
@jakebailey
Revert "Don't treat a colon in a conditional expression branch as par…
f579f33
…t of an arrow function" (#48940)
@andrewbranch
Skip missing nodes in formatting (#48953)
e26bc8a
@jakebailey
Revert "feat(47595): allow using private fields in type queries" (#48959
7d60dc1
)
@sandersn
Skip ambient modules in globalThis (#48938)
46e8306
* Skip ambient modules in globalThis

Previously, globalThis mistakenly included ambient modules, even though
these are not values:

```ts
declare module "ambientModule" {
  export type typ = 1
  export var val: typ
}
type Oops = (typeof globalThis)[\"ambientModule\"]
```

This PR adds ambient modules to the kinds of things that are skipped
when constructing `globalThis`' properties, along with block-scoped
variables.

* Skip only modules with every declaration ambient

The modules are required to have at least one declaration so that our
treatment of `globalThis` stays the same, and
`globalThis.globalThis.globalThis` remains legal.
@sandersn @DanielRosenwasser @typescript-bot
No error on toplevel return in JS (#48874)
650c056
* No error on toplevel return in JS

Turns out it's only an error in modules.
It's possible to keep this error on the list of "OK for JS" errors and
make the checker code stop issuing it for JS scripts only. However, I
don't think the error is valuable enough to do that.

Fixes #48224

* Restore 'return' statement.

* Update Baselines and/or Applied Lint Fixes

* Re-add missing baselines

* No error in toplevel script files

Only issue "no top-level return" error for modules, not scripts,
regardless of whether it's TS or JS.

* Keep Disallowing return in ambient locations

* Allow toplevel return only in non-ESM JS files

* Add test of toplevel return in JS script

* Revert "Add test of toplevel return in JS script"

This reverts commit 2a6dec4.

* Revert "Allow toplevel return only in non-ESM JS files"

This reverts commit 6291ae3.

* Revert "Keep Disallowing return in ambient locations"

This reverts commit 714ea8e.

* Revert "No error in toplevel script files"

This reverts commit 2056e13.

* restore orphaned baseline

Co-authored-by: Daniel Rosenwasser <[email protected]>
Co-authored-by: TypeScript Bot <[email protected]>
@DanielRosenwasser
Remove some unused baselines. (#48964)
eb1a8b1
@sheetalkamat
Fix node16 tests (#48974)
1e157ef
@weswigham
Allow export map entries to remap back to input files for a program (#…
8e433cd
…47925)

* Allow export map entries to remap back to input files for a program

* Fix file casing issues on windows

* Implement abiguity error, doesnt quite work

* Refine selection logic in error case to use getCommonSourceDirectory, add more tests
@a-tarasyuk
fix(48878): return errorType on invalid nodes in getTypeAtLocation (#…
f8a09be
…48967)
@andrewbranch
Clear ExportMapCache on cancellation requested (#48979)
4680b54
@amcasey
Harden combineProjectOutputForReferences against empty results (#48978)
58114cf
Getting an empty result doesn't seem expected, but a deeper fix doesn't make sense until #48619 is merged.

Fixes #48963
@petamoriken
Add ES2022 Intl.Segmenter type (#48800)
4a0b083
* Add `Intl.Segmenter` type

* Update baseline

* Fix useless generics

* Fix indent size

* Fix `ResolvedSegmenterOptions`
@jakebailey
Fix more tests missing 'it' call in 'describe' (#48994)
4765355
@andrewbranch
Respect importModuleSpecifierEnding inside node_modules packages (#48995
2ffe686
)

* Respect importModuleSpecifierEnding inside node_modules packages

* Add tests for missing package.json
@jakebailey
Fix missing parsingContext restore at return in parseDelimitedList (#…
8d0393d
…48999)
@RyanCavanaugh
Flag resolution mode assertions in non-nightly builds (#49002)
1a4643b
* Flag resolution mode assertions in non-nightly builds

* Add checker check
@DanielRosenwasser
Merge branch 'main' into release-4.7
c99b802
@DanielRosenwasser
Bump version to 4.7.1-rc
34e93a1
@DanielRosenwasser
Accepted baselines.
6c13ec8
@DanielRosenwasser
Update LKG.
ca59c9b
@typescript-bot

TypeScript Bot (typescript-bot) commented May 6, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping Sheetal Nandi (@sheetalkamat), Andrew Casey (@amcasey), Matt Bierner (@mjbvz), Mine Starks (@minestarks) for you. Feel free to loop in other consumers/maintainers if necessary

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 6, 2022

Copy link
Copy Markdown
Member Author

This should be merged, not squashed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request May 6, 2022
TypeScript 4.7 Iteration Plan #48027
Closed
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit a5ec725 into release-4.7 May 7, 2022
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the bump-4.7-rc branch May 7, 2022 00:21
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 22, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Daniel Rosenwasser (DanielRosenwasser) Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@DanielRosenwasser @typescript-bot @omarwbassam @sheetalkamat @ahejlsberg @Andarist @weswigham @rbuckton @jihndai @Zzzen @lowr @csigs @a-tarasyuk @andrewbranch @gabritto @jablko @JoshuaKGoldberg @jakebailey @patrickszmucer @jlusty
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.