GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29704: Fix asyncio.SubprocessStreamProtocol closing by 1st1 · Pull Request #415 · python/cpython

Conversation

@1st1

@1st1 1st1 commented Mar 3, 2017

Copy link
Copy Markdown
Member

Base PR is #405

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Mariatta and others added 30 commits February 12, 2017 15:18
@Mariatta @berkerpeksag
[backport to 3.6] Support "bpo-" in Misc/NEWS (python#42)
c2328ec
(cherry picked from commit 79ab8be)
@berkerpeksag
bpo-27122: Fix comment to point to correct issue number (python#48)
89b1824
It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)
@Mariatta
bpo-29474: Improve documentation for weakref.WeakValueDictionary (pyt…
308f789
…hon#22)

There were some grammatical errors in weakref.WeakValueDictionary
documentation.
@Mariatta
[backport to 3.6] bpo-28929: Link the documentation to its source fil…
f66c81f
…e on GitHub (python#37)

* bpo-28929: Link the documentation to its source file on GitHub

Change the documentation's `Show Source` link on the left menu
to GitHub source file.

(cherry picked from commit 23bafa2)

* remove if statement
@methane
bpo-29438: fixed use-after-free in key sharing dict (python#39)
89ddffb
@Mariatta
A few README tweaks (python#73) (python#79)
2d0c228
* Add a paragraph at the top for users, not builders, of Python.

* Use nicer rst url syntax to avoid borking paragraphs in the plain text.

Contributed by Ned Batchelder @nedbat

(cherry picked from commit 3cdbd68)
@Mariatta
bpo-28556: Various updates to typing (python#28) (python#77)
0230e64
various updates from upstream python/typing repo:

- Added typing.Counter and typing.ChainMap generics
- More flexible typing.NamedTuple
- Improved generic ABC caching
- More tests
- Bugfixes
- Other updates
* Add Misc/NEWS entry


(cherry picked from commit b692dc8)
@Mariatta
Fix some sphinx warnings (python#9) (python#81)
9268855
* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)
@Mariatta
bpo-29521 Fix two minor documentation build warnings (python#41) (pyt…
db3deb9
…hon#83)

Much of bpo-29521 was fixed in parallel with commit
e7ffb99 .  This cleans up the rest.

Apply parallel change to Doc/make.bat to read
"set SPHINXOPTS=-D latex_elements.papersize="
I don't have a Windows system on which to observe the warning,
but it should be necessary.

The warning:

.../workspace/cpython_github/Doc/faq/windows.rst:303:
    WARNING: unknown option: -t

In the Windows FAQ, `How do I keep editors from inserting tabs
into my Python source?`, contained a reference to a Python -t
option. In Python 2.x, this caused Python to issue warnings
about lines with mixed spaces and tabs, but as of Python 3.6
it does nothing.

Per discussion at http://bugs.python.org/issue29387, take
their wording. Python [3] raises an IndentationError or
TabError. Tabnanny is now a module.
(cherry picked from commit 3d707be)
@methane @vstinner
Update URL of Mersenne Twister Home Page (python#20) (python#115)
7d5587e
@zware
Backport master's README.rst to 3.6 (pythonGH-86)
1e8cc88
Includes pythonGH-2, pythonGH-70, pythonGH-73 (pythonGH-79), and pythonGH-21.
@Mariatta
bpo-29481: add versionadded 3.6.1 to typing.Deque docs (python#108)
7224a04
(cherry picked from commit 7e147f1)
@Mariatta @vstinner
bpo-29521 update Misc/ACKS (python#110)
02e3357
(cherry picked from commit 6420088)
@vstinner
Backport36 doc fixes: PR#68 and PR#124 (python#125)
b300c66
* Travis CI: run rstlint.py in the docs job (python#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.
(cherry picked from commit 2b50186)

* Doc/Makefile: set PYTHON to python3 (python#124)

rstlint.py run by "make check" doesn't support Python 2.

"make venv" runs "$(PYTHON) -m venv", whereas Python 2 doens't
provide the venv module: it's a module of Python 3 standard library.

(cherry picked from commit 91b0e7d)
@zooba
bpo-29579: Removes readme.txt from the installer. (python#161)
d372cda
@ncoghlan
[3.6] bpo-29571: Use correct locale encoding in test_re (python#149) (p…
0683d68
…ython#153)

``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
@methane @ncoghlan
[backport to 3.6] bpo-29529: Add .travis.yml to 3.6 branch (python#25)
3337d33
* Add .travis.yml to 3.6 branch

* Travis CI: run rstlint.py in the docs job (python#68)

Currently, http://buildbot.python.org/all/buildslaves/ware-docs
buildbot is only run as post-commit. For example, bpo-29521 (PR#41)
introduced two warnings, unnotified by the Travis CI docs job.

Modify the docs job to run toosl/rstlint.py.

Fix also the two minor warnings which causes the buildbot slave to
fail.

* Only run CI checks when appropriate files have changed (python#74)

Closes python/core-workflow#14

* Use 'make check' instead of 'python3 tools/rstlint.py' (python#96)
@berkerpeksag
Tweak PEP 519 documentation in stdlib (python#164)
b121d73
* Drop duplicate word 'object' in lzma docs
* Fix typo in os docs: fpr -> for

(cherry picked from commit d4d4874)
@methane
bpo-29520: doc: fix deprecation warning from 'defindex' template (pyt…
7970cd4
…honGH-178)
@orsenthil
Change some mercurial/ hg.python.org references. (python#8) (python#185)
a4afdfc
(cherry picked from commit b2ee40e)
@zhangyangyu
bpo-29347: Fix possibly dereferencing undefined pointers when creatin…
9a4577a
…g weakref objects (python#128) (python#186)
@methane
bpo-24274: fix erroneous comment in dictobject.c (pythonGH-200)
ce552e2
lookdict_unicode() and lookdict_unicode_nodummy() may raise exception
when key is not unicode.
@mdickinson
bpo-29602: fix signed zero handling in complex constructor. (python#203…
d9b3cdd
…) (python#206)

* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
@methane
doc: fix compile error on "shoddy" example extension (pythonGH-216)
51a477c
(cherry picked from commit fb8fe72)
@serhiy-storchaka
bpo-29532: Altering a kwarg dictionary passed to functools.partial() …
e48fd93
…no longer affects a partial object after creation. (python#209)
@methane
bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX (pythonG…
3ab24bd
…H-219)

(cherry picked from commit 3a9ac82)
@Mariatta
bpo-29453: Remove reference to undefined dictionary ordering in Tutor…
9b49133
…ial (pythonGH-140) (python#208)

As of Python 3.6 **kwargs are ordered, thus, remove the paragraph stating that
ordering is undefined and change snippet to remove the unecessary sorted call.

* Add sentence mentioning guaranteed output order of kwargs

(cherry picked from commit 32e8f9b)
@berkerpeksag
[3.6] Add .codecov.yml (python#210)
e9c0e55
@berkerpeksag
bpo-29554: Improve docs for pstat module and profile. (python#88) (py…
b067a5e
…thon#227)

Clarify that methods take a string which is interpreted as a regex,
not a regex object.

Also clarify what the old `-1`, `0`, `1` and `2` options were.

(cherry picked from commit 8fb1f6e)
@vsajip
Fixed bpo-29565: Corrected ctypes passing of large structs by value o…
3cc5817
…n Windows AMD64. (python#168) (python#220)

Fixed bpo-29565: Corrected ctypes passing of large structs by value.
(cherry picked from commit a86339b)
berkerpeksag and others added 25 commits February 26, 2017 19:09
@berkerpeksag
bpo-28518: Start a transaction implicitly before a DML statement (pyt…
76995ca
…hon#245) (python#318)

Patch by Aviv Palivoda.

(cherry picked from commit 4a926ca)
@Mariatta
bpo-26184: import.rst: Improve versionchanged note (pythonGH-277) (py…
deea29e
…thon#320)

(cherry picked from commit 6b4a5f4)
@berkerpeksag
bpo-28624: Add a test that checks that cwd parameter of Popen() accep…
6b81003
…ts PathLike objects (python#157) (python#323)

(cherry picked from commit d5c11f7)
@methane
[3.6] bpo-29110: Fix file object leak in aifc.open (python#310)
c9131b6
(cherry picked from commit 03f68b6) (pythonGH-162)
(cherry picked from commit 5dc33ee) (pythonGH-293)
@Mariatta
bpo-26184: import.rst: Improve versionchanged note (pythonGH-325) (py…
7e4897a
…thonGH-326)

(cherry picked from commit 1f5639c)
@zhangyangyu
bpo-29376: Fix assertion error in threading._DummyThread.is_alive() (p…
4b6c417
…ythonGH-330)
@zhangyangyu
bpo-29662: fix wrong indentation in timeit.Timer's doc (pythonGH-333)
8aa1ad8
@Mariatta
Asyncio documentation: remove self from method signatures (pythonGH…
bc10e6b
…-334) (pythonGH-337)

(cherry picked from commit 091b84f)
@berkerpeksag
Delete accidentally merged entries from Misc/NEWS (python#338)
046041e
@mjpieters @berkerpeksag
bpo-28598: Support __rmod__ for RHS subclasses of str in % string for…
53039ad
…matting operations (python#95)
@berkerpeksag
bpo-27788 : synchronise platform.py version number (python#246) (pyth…
bb59d89
…on#341)

Was bumped in the docstring by b9f4fea
but not in `__version__`

(cherry picked from commit 6059ce4)
@berkerpeksag
bpo-29655: Fixed possible reference leaks in import *. (python#301) (…
7accf20
…python#348)

Patch by Matthias Bussonnier.

(cherry picked from commit 160edb4)
@zhangyangyu
bpo-29661: fix contradiction in timeit.Timer.autorange's docstring (p…
c4a786b
…ythonGH-331) (pythonGH-353)
@dstufft
Disable mention-bot for maintenance branches (pythonGH-365)
d413aa7
@Mariatta
correct documentation for enum.html (pythonGH-358) (pythonGH-367)
8458b2b
(cherry picked from commit 6265842)
@Mariatta
Fixed a handful of typos (pythonGH-343) (pythonGH-364)
1b93ed4
(cherry picked from commit 1cf2a80)
@methane
bpo-29684: Fix minor regression of PyEval_CallObjectWithKeywords. (py…
023532e
…thonGH-378)
@Mariatta
email.compat32-message.rst: Fix typo in the word message (pythonGH-379
b05d48e
) (pythonGH-380)

(cherry picked from commit da62373)
@dstufft
bpo-29697: Don't use OpenSSL <1.0.2 fallback on 1.1+ (python#397)
784ba7c
@alex
In SSL module version examples, don't use a legacy version. (python#381…
65bd0bd
…) (python#400)
@brianfcoleman @serhiy-storchaka
bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is (p…
a6e8493
…ython#402)

allocated.

On PyMem_Realloc failure, _PyCode_SetExtra should free co_extra if
co_extra->ce_extras could not be allocated.
On PyMem_Realloc success, _PyCode_SetExtra should set all unused slots in
co_extra->ce_extras to NULL.
@1st1
bpo-29703: asyncio: Fix creating new event loops in child processes. (p…
01e5230
…ython#404) (python#410)
@1st1 Yury Selivanov
bpo-28893: Set __cause__ for errors in async iteration protocol (pyth…
dea5101
…on#407)
@1st1 Yury Selivanov
bpo-29271: Fix Task.current_task and Task.all_tasks to accept None. (p…
13802a3
…ython#406)
@SethMichaelLarson Yury Selivanov
bpo-29704: Fix asyncio.SubprocessStreamProtocol closing (python#405)
604faba
@1st1 1st1 added the cherry-pick for 3.6 label Mar 3, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 3, 2017
@1st1 1st1 closed this Mar 3, 2017
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview @Mariatta
Bump gidgethub from 4.1.1 to 4.2.0 (#415)
3b1f7f9
Bumps [gidgethub](https://github.com/brettcannon/gidgethub) from 4.1.1 to 4.2.0.
- [Release notes](https://github.com/brettcannon/gidgethub/releases)
- [Changelog](https://github.com/brettcannon/gidgethub/blob/master/docs/changelog.rst)
- [Commits](gidgethub/gidgethub@v4.1.1...v4.2.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Mariatta <[email protected]>
SonicField added a commit to SonicField/cpython that referenced this pull request May 15, 2026
@SonicField
W-PERF Class A F-1: codegen-time gate-correctness instrumentation
315bdce
Phase B prereq item 4 per supervisor 06:27:29Z dispatch + theologian
06:28:41Z DRAFT + 06:29:45Z (B)-confirm.  Closes the catch-class gap
that exposed Phase A 5830b49 inert-scaffolding via librarian
00:04:37Z grep at frame_asm_c.c:527-532 (gate_passes_full_inline
computed then (void)-cast).  Pythia python#412/python#415/python#417 named the same
class repeatedly: "scaffolding-tier code can fail correctness while
passing every behavioural test."

F-1 attaches two pydebug/env-gated falsifiers to the existing gate
computation, both production-zero-overhead:

F-1.a oracle agreement (pydebug-only):
  assert(gate_passes_full_inline
         == frame_asm_c_full_inline_gate_oracle(hir_func));
The oracle in the new file Python/jit/codegen/frame_asm_c_oracle.c
re-derives the 4-condition predicate from theologian's design intent
(lightweight + non-generator + numCellvars==0 + numFreevars==0)
without re-reading the production gate.  Structural independence:

  - separate translation unit
  - reverse condition ordering (cellvars/freevars first; frame mode
    middle; generator last)
  - jit_get_config()->frame_mode lookup against JIT_FRAME_LIGHTWEIGHT
    enum vs. production's jit_hir_func_get_frame_mode +
    FRAME_MODE_LIGHTWEIGHT local #define
  - co_flags & {ASYNC_GENERATOR|COROUTINE|GENERATOR|ITERABLE_COROUTINE}
    bitmask spelled out in-line vs. production's jit_hir_func_is_gen
  - sequence of early-exit returns vs. &&-chained boolean compose

Production builds compile out the assert; the oracle then has no
caller and the linker may strip it.

F-1.b population coverage (env-gated PYTHONJITGATESTATS=1, both
build modes):
  per-JIT-compile fprintf to stderr with verdict + running true/false
  totals + each input field + qualname.  A single Phoenix smoke run
  produces a distribution that verifies >0 functions take each
  branch and shows which input decided each false case.

F-1.c sample test cases for theologian review post-build:
  - simple identity (lambda x: x): gate MUST be true
  - closure factory (def outer(): x=1; def inner(): return x; return
    inner): outer gate MUST be false (cellvars), inner gate MUST be
    false (freevars)
  - simple generator (def g(): yield 1): gate MUST be false (non-gen
    requirement fails)

F-1.d cross-arch: same input → same boolean on x86 and ARM64; per-
codepath counter distribution must match cross-arch within ±1.

Q1 oracle scope clarified pre-implementation per
[feedback_query_before_pivot]: gate is the 4 codegen-time
conditions only (theologian 06:29:45Z (B)-confirm); hasRtfsFunction
stays a runtime branch in Phase B (F0 measures its true-rate).

Auth chain: supervisor 06:27:29Z F-1 dispatch; theologian 06:28:41Z
F-1 design DRAFT + 06:29:45Z scope clarification; F-1 PASS gates F0
runtime branch-rate per supervisor 06:27:29Z.

Removal of F-1 instrumentation per I-F1.4 is a separate post-Phase-B
commit; this commit lands the instrumentation only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@1st1 @the-knights-who-say-ni @Mariatta @berkerpeksag @methane @zware @vstinner @zooba @ncoghlan @orsenthil @zhangyangyu @mdickinson @serhiy-storchaka @vsajip @153957 @warsaw @benjaminp @mjpieters @dstufft @alex
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.